Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <a4439005-29f0-b458-6a3a-b6c2758a38bf@nvidia.com>
Date:   Sat, 21 May 2022 12:16:29 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH 1/6] ASoC: tegra: Add binding doc for OPE module
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
        catalin.marinas@arm.com, will@kernel.org, perex@perex.cz,
        tiwai@suse.com
Cc:     jonathanh@nvidia.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <1652895372-29885-1-git-send-email-spujar@nvidia.com>
 <1652895372-29885-2-git-send-email-spujar@nvidia.com>
 <049173a1-0fa6-510b-9169-ebe869b8a3b3@linaro.org>
 <90680cfb-c611-63cd-ab5f-5afb86c91cec@nvidia.com>
 <a0eed04a-1380-d96a-a406-217f053354b9@linaro.org>
From:   Sameer Pujar <spujar@nvidia.com>
In-Reply-To: <a0eed04a-1380-d96a-a406-217f053354b9@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHV3ZHJ3QjBWV3JUQm9DeE5hb2lRb3EwajJTNzJLdGlScENpVjFzaVVKUkVY?=
 =?utf-8?B?TS9jZ0dpQVdEamNmSnZMcFpvQllEZVRGalh6Vy9ZejFBZ2lQZElkejZmNVN0?=
 =?utf-8?B?V1lvbjJ5c0lMZ3E4bHRyUHI3N1R0QURncUFKMmtVd0drQTFsRkhpUUZ4U0JE?=
 =?utf-8?B?WFdhUjFZRy8zakhsejRNbmdIV09aR1VNSnZydC9XSDZ3Mko0ZnlESFcxc2lF?=
 =?utf-8?B?MHlaL1BwYzdhUXFJc1RhenhaazFGVVZZNTg5bndXSDRYRFhVemhBYmtZNUZN?=
 =?utf-8?B?MlpSR3o3U2Fqc3NwTlFjM1dnWnlNMm5qL1RVa2ZmR1YyVlBGQW03ZENPZkNS?=
 =?utf-8?B?ODBkeC9HUGhlM0N5R0tEUTBkYy9WQzRPSmxlNXYwdU1jNk9qc1E1Ly81ZGdL?=
 =?utf-8?B?b2I0dFlwMHpjUjcyU2o1UFByaVlsdFRnWmJBY2hzc3l3ci9CQTFTTmErRVlR?=
 =?utf-8?B?K203MnlkbHM0OHdYTlpKbU1qWUJ0SUhQdXkwQXk5NGVwbk11NHI4YUY2Q1FQ?=
 =?utf-8?B?SmQ1ejBvUTEwSTdkaS9TS25aRVBtTmhLSHpFZkZQaWRuZ2VmUUNETXdoSDdz?=
 =?utf-8?B?eVBqbFkrZmZMczlaYUtrRHArenZCbVVyNzBJKzFIeU9LNm5ubGFUbzRGd0xt?=
 =?utf-8?B?VUNFOVhsZHMwektZOThhRS9qOVcvNTdDRTF2RGNTRkVYUm5IdDlCMUxIZnpC?=
 =?utf-8?B?OUsrUERkZU5mVjcxZ1hlRk10Y1RYUkkyRW05RmxYQWV6eUd6WUttYTZuWHNE?=
 =?utf-8?B?bkMwK1E4Y2NMclRTRFRQT21GL1NrNUFsRmNxRmhWQnNXelBtSlkyZ0Y1TUsy?=
 =?utf-8?B?Q2MvMDFLb2s2Ump3aVM2eWhnRGZyQWtMVE9OMjZaUDh5V1JuUkE3QWNaSlc5?=
 =?utf-8?B?RWdNNGFvY2FEME53UzZEVGRmdElWeHo4SW1ZOGQ5L0JCN0paRU0rWlEzZC9w?=
 =?utf-8?B?ZCt6RmF6ck5xdVFsdW9mQ2YxREZndXJPU2twOWNNSXBkMEtFSU42Z2xZclUx?=
 =?utf-8?B?akljd3NyVGFVd25tRFdaQTNxWWxyVm9pZmNyckh3Y1IwaVhTdFU1ZHFUZHNk?=
 =?utf-8?B?MXJ1SUkzekhWWUlUSUVvVEdvZTJZTGpCdk44Q00zMnhGb0dTTDhEZDZnSHBh?=
 =?utf-8?B?aVJWYlN2SWx0Y0RqVGF6YWVWU2ZPMlprdnQ4M0dEeXA0WnZXczFlQTNLVjhh?=
 =?utf-8?B?bGR5cWtZT3ZVcTZQZzlpR1dwbWI0My9uMnVxQkd5Q0RNMmk4SE54aXVGc0Yz?=
 =?utf-8?B?ZERCY2t0WGdLZHlhU1RqRFNnM3NjS2k5bzlhSWJpR0o0bklwUmNyU3R1NVVD?=
 =?utf-8?B?cWZWRmtFNWhlc3BSQkpPU3JKV2VBMTB4VXc3bzcwNXNQYzZ1YzBVQTBManIx?=
 =?utf-8?B?NjdTMFFaRk40MmI5K3h6NkhzdGlNTUZNdW80NXpCOFVuZG9WOGdSeFVxcHRE?=
 =?utf-8?B?WjY1ZTM1ZWhSRVhMUHUvOGxBTmpxZVJDa29NQWFiVXk0SmJxRGFyL1JEY0Zm?=
 =?utf-8?B?SU5lTG5qbitzdE14Lzd6TTRWbzgvL2hVQ1EwNUhPOEY4U0dVMU1VSzVPd2RC?=
 =?utf-8?B?M3FaUEtXb2lha0lZMEJ2eUN3VEJmVTJzQlNwRXdYUVBuSGI3U3F3U1pFZHNB?=
 =?utf-8?B?R081RnhQMWI3Y2RZaWtPaEhCWWk0eUFROEdwVm5yeXF4M0k2RjNycjA5cGRr?=
 =?utf-8?B?Wm1rWlZPTk5odStCcHJJbytnc0E5elN2T1N2YTV2Y2taZWtpblE5K21INU13?=
 =?utf-8?B?WERKVWJHSkIzbjZCRFhuZDh2NXFXMUdUQzFWcFJYRnJ0YjZOYkp4ZjVBblA0?=
 =?utf-8?B?SURKUkF0ejNCN2RRRW9QYUgzWWkrSDhNN1dhTHJSTkFFa3Q0eXJFdmVBRWFl?=
 =?utf-8?B?bUkxZ1dEUUIyeFloelNLY0pBVVhrblpJV2RTT0R6dkk1L1RwMVZWZjdSa0RN?=
 =?utf-8?B?UmJWaVcyakU2ckQvby9HeVQ2TjJkTUYraGt1T1ltNjVOaHdqbVVVcVMzUXoz?=
 =?utf-8?B?RWlwdFE0NTFsamJ0akV4a3loeG5QcUMzMllid3J5OS9CVXRJMmw0ZkVBb0t3?=
 =?utf-8?B?S3ZoSCtlcGt3cjg4OU1TSDFjd0xpcDAwTGlWUGtHZVJMUFBUS1dOTWkyQlRN?=
 =?utf-8?B?SFgxakFQVmwzaUliLy96S2ZtUmV3ejhXU2dLTW1zbjhZTkRkd1I2bC9jeVdm?=
 =?utf-8?B?U0tWdGtPdlhldFdDOG9xcE9UWDMvOGJORHRUWXcwN0p5bU5jdVp2dDJXTjRK?=
 =?utf-8?B?QVJSV0s5TlR6T3RJdW1hRnFTeHhMYVNlekgzbVd6T0dXNVJlWSsvUklGSTFL?=
 =?utf-8?B?VW1hd21EdVRiZGF2QU9ITk43cms5YjBOVlpJQ2xxNzhrNFIrdWpGQT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36317875-6c13-48c2-8fcc-08da3af5a9b6
X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1576.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2022 06:46:41.8652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y26uyUUVD31P8dTBbX36F/fTPcVn/bHvYer+IV0V3K8ktKQq5d2SYH9iViM4cZLrtozum6yDc4KFrAIcmk34kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3420
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 20-05-2022 12:21, Krzysztof Kozlowski wrote:
>
>>> On 18/05/2022 19:36, Sameer Pujar wrote:
>>>> +description: |
>>>> +  The Multi Band Dynamic Range Compressor (MBDRC) is part of Output
>>>> +  Processing Engine (OPE) which interfaces with Audio Hub (AHUB) via
>>>> +  Audio Client Interface (ACIF). MBDRC can be used as a traditional
>>>> +  single full band or a dual band or a multi band dynamic processor.
>>>> +
>>>> +maintainers:
>>>> +  - Jon Hunter <jonathanh@nvidia.com>
>>>> +  - Mohan Kumar <mkumard@nvidia.com>
>>>> +  - Sameer Pujar <spujar@nvidia.com>
>>>> +
>>>> +properties:
>>>> +  $nodename:
>>>> +    pattern: "^mbdrc@[0-9a-f]*$"
>>> Why? We enforce only generic names in shared schemas and this is neither
>>> shared schema nor is it generic name.
>> Idea was to keep these node names consistent across DT files and parent
>> node can allow a given list of child nodes with strict checks. Does name
>> like "dynamic-range-compressor@xxx"
> The checks are not coming from device node name, but from matching
> schema to compatible. Why do you need consistent names across DTS files?
> They should be anyway generic but what happens if they differ?

The IP is re-used in many Tegra SoC generations and thus it is nice to 
use the same name. But,


> Additionally, the parent schema enforces nodes of children, so if this
> is included in other schema, then the change is pointless.

I see your point. Since parent schema already enforces the child node 
names, another place from child schema to enforce similar rule is not 
really necessary for now. I will drop this. Thanks.