Date: Tue, 15 May 2007 19:51:05 +0100 (BST)
From: Hugh Dickins <hugh@veritas.com>
To: Andi Kleen <ak@suse.de>
cc: Andrew Morton <akpm@linux-foundation.org>,
       Christoph Lameter <clameter@sgi.com>,
       William Lee Irwin III <wli@holomorphy.com>,
       David Miller <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: [PATCH] i386: don't check_pgt_cache in flush_tlb_mm
Message-ID: <Pine.LNX.4.64.0705151946550.30826@blonde.wat.veritas.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1042
Lines: 27

No other architecture calls check_pgt_cache() from within flush_tlb_mm(),
and i386 is already calling check_pgt_cache() from the usual places,
tlb_finish_mmu() and cpu_idle() (the latter being odd, but not unusual).
flush_tlb_mm() has no business to be freeing pages: remove that line,
which sneaked in with slub's i386 support.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
 arch/i386/kernel/smp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 2.6.22-rc1/arch/i386/kernel/smp.c	2007-05-13 05:40:51.000000000 +0100
+++ linux/arch/i386/kernel/smp.c	2007-05-15 17:49:48.000000000 +0100
@@ -421,7 +421,7 @@ void flush_tlb_mm (struct mm_struct * mm
 	}
 	if (!cpus_empty(cpu_mask))
 		flush_tlb_others(cpu_mask, mm, TLB_FLUSH_ALL);
-	check_pgt_cache();
+
 	preempt_enable();
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/