Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <679693c4-8c4c-85b0-e4f2-7f34be3bad12@samba.org>
Date:   Sun, 22 May 2022 16:09:10 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH -next] cifs: Return true/false (not 1/0) from bool
 functions
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>,
        David Howells <dhowells@redhat.com>
Cc:     linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220504130634.101239-1-yang.lee@linux.alibaba.com>
From:   Steven French <sfrench@samba.org>
In-Reply-To: <20220504130634.101239-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Do you remember which patch caused this? Perhaps one of Dave Howell's 
iov_iter cifs patches that was temporarily in for-next? I don't see it 
anymore

On 5/4/22 08:06, Yang Li wrote:
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions. This fixes the following warnings from coccicheck:
>
> ./fs/cifs/file.c:4764:9-10: WARNING: return of 0/1 in function
> cifs_release_folio() with return type bool
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   fs/cifs/file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 580a847aa8b5..a9123cefd84f 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -4761,7 +4761,7 @@ static int cifs_write_begin(struct file *file, struct address_space *mapping,
>   static bool cifs_release_folio(struct folio *folio, gfp_t gfp)
>   {
>   	if (folio_test_private(folio))
> -		return 0;
> +		return false;
>   	if (folio_test_fscache(folio)) {
>   		if (current_is_kswapd() || !(gfp & __GFP_FS))
>   			return false;