Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760643AbXEOS7x (ORCPT ); Tue, 15 May 2007 14:59:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755950AbXEOS7q (ORCPT ); Tue, 15 May 2007 14:59:46 -0400 Received: from holomorphy.com ([66.93.40.71]:39969 "EHLO holomorphy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755873AbXEOS7q (ORCPT ); Tue, 15 May 2007 14:59:46 -0400 Date: Tue, 15 May 2007 11:59:47 -0700 From: William Lee Irwin III To: Hugh Dickins Cc: Andi Kleen , Andrew Morton , Christoph Lameter , David Miller , linux-kernel@vger.kernel.org Subject: Re: [PATCH] i386: don't check_pgt_cache in flush_tlb_mm Message-ID: <20070515185947.GY19966@holomorphy.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 17 On Tue, May 15, 2007 at 07:51:05PM +0100, Hugh Dickins wrote: > No other architecture calls check_pgt_cache() from within flush_tlb_mm(), > and i386 is already calling check_pgt_cache() from the usual places, > tlb_finish_mmu() and cpu_idle() (the latter being odd, but not unusual). > flush_tlb_mm() has no business to be freeing pages: remove that line, > which sneaked in with slub's i386 support. > Signed-off-by: Hugh Dickins Acked-by: William Irwin -- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/