Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 21 May 2022 12:24:16 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Alifer Moraes <alifer.m@variscite.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        eran.m@variscite.com, festevam@gmail.com, kernel@pengutronix.de,
        linux-imx@nxp.com, linux-i2c@vger.kernel.org,
        linux@rempel-privat.de, pierluigi.p@variscite.com,
        s.hauer@pengutronix.de, shawnguo@kernel.org,
        gaopan <b54642@freescale.com>,
        Fugang Duan <B38611@freescale.com>,
        Vipul Kumar <vipul_kumar@mentor.com>
Subject: Re: (EXT) [PATCH] i2c: imx: add irqf_no_suspend
Message-ID: <Yoi90G5cphagcxpp@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        Alifer Moraes <alifer.m@variscite.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        eran.m@variscite.com, festevam@gmail.com, kernel@pengutronix.de,
        linux-imx@nxp.com, linux-i2c@vger.kernel.org,
        linux@rempel-privat.de, pierluigi.p@variscite.com,
        s.hauer@pengutronix.de, shawnguo@kernel.org,
        gaopan <b54642@freescale.com>, Fugang Duan <B38611@freescale.com>,
        Vipul Kumar <vipul_kumar@mentor.com>
References: <20220307143630.28697-1-alifer.m@variscite.com>
 <3676803.kQq0lBPeGt@steina-w>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bW5lVs4zqF9WjfiD"
Content-Disposition: inline
In-Reply-To: <3676803.kQq0lBPeGt@steina-w>
Precedence: bulk


--bW5lVs4zqF9WjfiD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi everyone,

> > The i2c irq is masked when pcie starts a i2c transfer process
> > during noirq suspend stage. As a result, i2c transfer fails.
> > To solve the problem, IRQF_NO_SUSPEND is added to i2c bus.
> >=20
> > Signed-off-by: Gao Pan <b54642@freescale.com>
> > Signed-off-by: Fugang Duan <B38611@freescale.com>
> > Signed-off-by: Vipul Kumar <vipul_kumar@mentor.com>

The SoB from Alifer Moraes is missing, too.

> > goto rpm_disable;
> >=20
> >  	/* Request IRQ */
> > -	ret =3D request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED,
> > +	ret =3D request_threaded_irq(irq, i2c_imx_isr, NULL,
> > +				   IRQF_SHARED | IRQF_NO_SUSPEND,
> >  				   pdev->name, i2c_imx);
> >  	if (ret) {
> >  		dev_err(&pdev->dev, "can't claim irq %d\n", irq);
>=20
>=20
> I stumbled across Documentation/power/suspend-and-interrupts.rst which st=
ates:
> > For this reason, using IRQF_NO_SUSPEND and IRQF_SHARED at the
> > same time should be avoided.
> Given this IMHO at least a comment should be inserted why this is fine. I=
 dont=20
> have a full picture about the situation, but to me it seems there is a=20
> reference missing, or why/how does some PCIe start some I2C transfer when=
 the
> controller is suspended already? Do I miss something?

Thank you for this comment, Alexander. I second you, this needs
explanation.

Happy hacking,

   Wolfram


--bW5lVs4zqF9WjfiD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmKIvcwACgkQFA3kzBSg
KbYBVw//eUEuyxhP5NHyCEWeN7/A9Rbd45Wch8anz2ZxTHwrQ/d5jocPR0ZZjb7H
pGhesAIMaw+LH88Bhw49U8TpbjKNRUwB8J9uaREwtI8X7rlmx8iHLqMadis83HPM
RZblDYVbe+69+EAKHfKu3WrzMWhGc+tO+hinRPaxCY26h1isuQPaELPBfTyuqiJ5
NHYfDhVV/qZtMYZI8xfEf8UAN/wGYaVL4Zhputw/XL5ZjCAuczavsInFdwzkzRyX
JlRb+VXvJAqI5CAz6AYGuaWlMO7hZB81fpGm4+5B6UVPQA6jWl9e9s/L7sVZ1Zjs
cJYjL3BD3/j0XQArEoMhySZAfs2KNeoXHWnc0zVas1lHHh4HwbEWLFRrK/sv5Wkz
KkR1mMiLjlFsmxHwFIh+eWN0KDM8pTWCYEaiiCuYaQfeQH6RTE9Ju1l/+tb03mu7
dPOK6S9Vl+nJ6qYGAS/HDj9nq6GQIX1i3T/bkYvLYE1/lK81AJt/7TuQdV7ulmwF
jQHd5hpFjh8Bx25oyaK3kqQeCV6PUVtqdxoNCPffqH9BJwRWPdy275ucpZR9+7p9
ysOhQQ+HDc3kXAVgpWE1AJgj95w/O7WVSpf7D5zwfpjiRyHaNp8qTB1IbcSC6Ty4
frxbSqyQa4wbGBJfcsiuAe8linmZkmoZfCa3+Sh0vggMmpBM9Pg=
=CxIu
-----END PGP SIGNATURE-----

--bW5lVs4zqF9WjfiD--