Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d796b54d-7559-f9ff-bb4b-4e75a707db2d@nvidia.com>
Date:   Fri, 20 May 2022 10:10:49 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v1 1/1] gpiolib: cdev: Fix kernel doc for struct line
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, thierry.reding@gmail.com
References: <20220520164726.60638-1-andriy.shevchenko@linux.intel.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20220520164726.60638-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1gvaEZGbGYybWh2MHhLTENyaU0xTXQxblI5aGlkTmJQZGdSVmpleU9nRHNC?=
 =?utf-8?B?QmRnYlF4bTA0Z3NtZUREUW9STnlENkVWdFVDY0Y5NU1KRnl3YUJGWFlpZkRP?=
 =?utf-8?B?aGUwbDE5Nm5EZlllTTJXbXlGRVZLbHAxWEx2cUIrZkRQUmkzdFpKeGsxUnhQ?=
 =?utf-8?B?UlNMeWpOcXlaa3U0ekdJZjZpWTRRL2Z3LzhPRmk1SDBFeWovSEpBeW5HOENG?=
 =?utf-8?B?eHllZXVoZjRibjVadEM0UVBUdUxZdnJFbmJKckFpT1k5UlpDalU2TXJiT0RB?=
 =?utf-8?B?RjJUYlBGdWlPR1NwREJndmNVeXdmM1N3T1BjOE5OT2h3Uy82OVc4bU5mRWlx?=
 =?utf-8?B?MWNhZGc2bUFTdDBSVER0UDczWXdLeWZmTGtKY0ovK01KNjV6MGsxQXZxbnVY?=
 =?utf-8?B?T2FDVmNhSVhmUnJMS2FOcWNxTjhMMWJVakFCdW4yZFBiZllVRVdqbGRPOUZS?=
 =?utf-8?B?ZkV5OElKQXZ3TkVKUVExZ0I1TE14ZVZwSUFPWHF2ak1Eb2FLUzd5Vk5GUnZq?=
 =?utf-8?B?THFrVWdEbkYrVGZ3NytqYXgyUXpwNTgyenk3aUIrdUVrVXFYTkN6bWFzM3p6?=
 =?utf-8?B?bStyOU9XbHBBeGlJbVkrMFNmcWRKUHlQUDVmakFCMU1jR2Z1bjFhTUptM1RX?=
 =?utf-8?B?UnpYdk1YRWJaNTVVWnloaU1GR1E2VFR2aWRpSVE3OWE3bjluVTYwa2I0d1Fz?=
 =?utf-8?B?NnFqZTFGa0l0QmU0d2ZwZTF6M0l1Wk9TSEhkK214SVZ4TmxmSnVsNGc3MkVy?=
 =?utf-8?B?VVJ1NjRDUVJhaG91SW43bU5PSVFSc3dPRTNYQTVrd1Fld2lXS2xXYXlqczhI?=
 =?utf-8?B?Ym9SWjJCZ3NGWHVDRDNEM01mY0dmTHk3MnpiUFF1K01LSGJuZzN1WHk3bVlN?=
 =?utf-8?B?ZUVPaUNSeHIzZ3dxU3pzUnNSdVdFK3E3VG55MFRsUUV3VzVabCtpNEhZd3NM?=
 =?utf-8?B?MTZlY3FiZUt0SzhUKzB2cU9LZ0VEVytya1lNcTQ4KzZjL01rU0MyQk9MRk9N?=
 =?utf-8?B?SlV1bzJQTzVwUm4xelg4TXhBeDNRcHRxMjJLT2MwQ0hjR3QvK2ZYQWRnc3Qz?=
 =?utf-8?B?QTB3ZEIwcHN6eEZyOTg4WlpPVm1kMkQ2NElpMHRRMFI2aUdXejM2RW1GdnM0?=
 =?utf-8?B?b1hUdjhhSnMzcHVVdEpvZXJJTjJ4bHFOQkthR0NGa2hBcVZmOHVvcGxRK2E2?=
 =?utf-8?B?ekdZOWFoSFVHSkF4U2RKUlM1NU5QTW5OWlpzU3AyUElNcUF4RVQ4VCtLeDRy?=
 =?utf-8?B?QVVoR0k4N0dWUGlrYmRIa1hZN3NObVV0eEtkYysrUThPY0VJWlRUcUltV25z?=
 =?utf-8?B?UUNOTlhzazNCNU84bFBhcW4vL3VsRjVONzdmSHVxbE9uTUJwZXJ2dnErdmdF?=
 =?utf-8?B?K1BlQ2dHWThWeUFiRmgzYlROd0ZIcWN1L1JCK2Vnb0JuNjJCOE1md1pNSTFq?=
 =?utf-8?B?dDdzYXYxeUJMQWEvRDQ3K0RBQUJhNzlwSStOVnowSnMra0NKQzNqcUhBTHR6?=
 =?utf-8?B?dy9URjJGV1lxWHp5alJQcFR1Sm9pd0pnK29NZTMrdFpmR2tHOWgwK1U1YUpa?=
 =?utf-8?B?TXQ0dGowNHR1Wk1EUXZoQU93S3RBS1A3ckNQV2dwdzFoTjcrQlpBaGVtc2pB?=
 =?utf-8?B?UzFPT0w0WXcvUlB3eExnL2dXTlA1elZMaGFtMEFJQ3hmMTRCeTUrZU1pd2h6?=
 =?utf-8?B?Snh4Yit1QWVNcUd5WWwzRE50Ukx5ZHIwcVlyenMvb0czenlUNEYyUytkNTNk?=
 =?utf-8?B?eXlCUXFzbkppRGp4aHBPUUNyeE9oUVJvaUQzT1dPTWc2L1ZWL1RzWEJGU1Vi?=
 =?utf-8?B?L2Vab2dSL0IrSENySjVTVElyeHpmSjZCL3ZINExsc0I4N0s3RUY2YnVNdEov?=
 =?utf-8?B?N25LcjV3Sjd1NzFZcktoVnliWXprc21Wemd3Q21WQXV6dWxPa2k4ZUJDbDJs?=
 =?utf-8?B?czRjQVl3ZTYrK3NMZDJZak5iVDRYcHlkdDR3K1c2eUlwdVZPeFFGUWNmNnRh?=
 =?utf-8?B?OStTZmZkbWU5elJKYkZaYmZzZ29pUEFKQ1dYUVhEaFhNYTZGWGRLbFJjd3Jt?=
 =?utf-8?B?UE9ucG9lMGJpemQyVk1ibWxmb2tFaGtjMXFsWmY2Yy91RlM2VGowVVBoT1pk?=
 =?utf-8?B?UmMxRnVkbEtuZXlJWmR5R0hPRXJEVkJSTVVpRjRNMWNtWEluMFBxK0c3NVJt?=
 =?utf-8?B?VHlxTG5pOGljOFBBQ2JMY09wenR5Q3FvbnpmZzZkbGs5c1dNTVVJb2VyRjA5?=
 =?utf-8?B?c29WTmU5V05UNEEvclFiYW5rWEs2RGxpMkVETDhrZ0szZGVnbzBTUi9CWVor?=
 =?utf-8?B?KzB4REhNWnEyTi9YUDN1RmV2c2lZeXdWakZEdmZjeUxRaVdZRjU2Zz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e175d1f-08cb-4a36-98b5-08da3a83b2d2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 17:10:54.3337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7KXemgT9QBGucmFhVDDhuI/moSTRWOBQWQggQCLmNJbTB0if1muyU0rKK4NxLbQElWt5MOSUhkAJO9FjihovcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5189
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Acked-by: Dipen Patel <dipenp@nvidia.com>

On 5/20/22 9:47 AM, Andy Shevchenko wrote:
> Kernel doc validator is not happy:
>   gpiolib-cdev.c:487: warning: Function parameter or member 'hdesc' not described in 'line'
>   gpiolib-cdev.c:487: warning: Function parameter or member 'raw_level' not described in 'line'
>   gpiolib-cdev.c:487: warning: Function parameter or member 'total_discard_seq' not described in 'line'
>   gpiolib-cdev.c:487: warning: Function parameter or member 'last_seqno' not described in 'line'
>
> Describe above mentioned parameters.
>
> Fixes: 2068339a6c35 ("gpiolib: cdev: Add hardware timestamp clock type")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpiolib-cdev.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index f5aa5f93342a..d0dc68d04059 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -421,6 +421,10 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
>   * @work: the worker that implements software debouncing
>   * @sw_debounced: flag indicating if the software debouncer is active
>   * @level: the current debounced physical level of the line
> + * @hdesc: the Hardware Timestamp Engine (HTE) descriptor
> + * @raw_level: the line level at the time of event
> + * @total_discard_seq: the running counter of the discarded events
> + * @last_seqno: the last sequence number before debounce period expires
>   */
>  struct line {
>  	struct gpio_desc *desc;