Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <90680cfb-c611-63cd-ab5f-5afb86c91cec@nvidia.com>
Date:   Fri, 20 May 2022 09:49:26 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 1/6] ASoC: tegra: Add binding doc for OPE module
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
        catalin.marinas@arm.com, will@kernel.org, perex@perex.cz,
        tiwai@suse.com
Cc:     jonathanh@nvidia.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <1652895372-29885-1-git-send-email-spujar@nvidia.com>
 <1652895372-29885-2-git-send-email-spujar@nvidia.com>
 <049173a1-0fa6-510b-9169-ebe869b8a3b3@linaro.org>
From:   Sameer Pujar <spujar@nvidia.com>
In-Reply-To: <049173a1-0fa6-510b-9169-ebe869b8a3b3@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjlVYzNJNGFkTzdKSDlneTZ4MFJybmlhTFU1Zi9mQkxrRUVOb3FKQ1BDN0cz?=
 =?utf-8?B?N3k0Tzg1OVJvNFhPRW9BYmgvdE91YnZjbU0xLzFUVVRPWGJueTVxRVNKTGdq?=
 =?utf-8?B?TExjYTUvVXc1UFZUTDcyT1RWdzJPOS9kRTBUV3BZUDhHYnlGVE4wdkluaVF6?=
 =?utf-8?B?d3MzdUt2TjZ6V0FnTGRVVGxtR21samR3ZUc4QnNseklPMGlmTnNXeEQ4QzNk?=
 =?utf-8?B?U3dIb2NZQUMwNC9GU2E2ZFNjS3hOM1Q4SWxYd1FsNEh0SUc0VTdDVy81eTY0?=
 =?utf-8?B?Z0QyaW5ZTDllSWZBcFNla1l0ajhhc0F0OEhCdnpxS1JDdnJUamFyaDFOSkxu?=
 =?utf-8?B?ekVEY1o2YUhtOEFoSTdYTTdlQnFkZjVwNHNvSU9aVnQwWUh5ckQrdFhZZU04?=
 =?utf-8?B?ZE41ZlY4SFRmWkV4eXVYdTNkWi9LeWlmQktvOU9FeUM3bERRRSs0OGRJcTlh?=
 =?utf-8?B?cWlyVTZIYStVSXhjbWtDelJJclpnY3IxcWdXQXFqQk5SZ3BmdjdDMnRzWG00?=
 =?utf-8?B?dkt6Qm1sVlVPcElac2xVTlZqNG50c1l3RmRBUXlKL0UweFdXSDY0QmVTdnBF?=
 =?utf-8?B?aktNTnIxbEdlL3pJMklnOSttUFoyUVlBZExGMjAvNkptVGpaT0pOMk9jNm8r?=
 =?utf-8?B?b3ltL1IrK0lwY3NMRmpjYzZVOFlkbEFoTzNHL2pGVElya2labFlTVVo2STZJ?=
 =?utf-8?B?Z1BZa2YxYVd6Y1pDWEpYWXBuNFg5TEhOdWx4MW5kaDZVbkx5WFdyZENITzEx?=
 =?utf-8?B?U0t1RGFMaGMvR1QzMVBzdC9Bd2xVakNMMitVR2c0UHRXZkJNUHFWdmN2aVJr?=
 =?utf-8?B?Z0RRVW9TWU9BL1M2UDI4azF6MTd2YW9uaElENHc4R0V0ZTFSZnZra2REOVNr?=
 =?utf-8?B?cDk4SlFrckRXVGpsMFp0MG1DWDQwUHpGQkVHMXlZb05qQWg5VlBBUHJRNGZQ?=
 =?utf-8?B?Y2FpSk1Jd0FUeFdmaFlLMGV3YVpPUDRtclgvNkw2aWw3T21VczNZWXJkeEt4?=
 =?utf-8?B?MERQSDhjWlhGRmpEeUhjVmFqNUVYejJjQUFaYzJGTlgrWVlQSWxrOC8reEMx?=
 =?utf-8?B?dzZVREYvL2lvVTZKalRUK1BXeTdHOHN2SnRVS2tSL3Zmd3haM1lhM1huWE11?=
 =?utf-8?B?OFF3NUJmM2cxT0xWMkxxaUtUUkpFcElHbEJPZTBJUjJsUWtzVHpYMWcwM1VV?=
 =?utf-8?B?bjU0Y1F3Wkx6KzVhVXI1bWMyblhONFIxdlJ5Q00zeXdxcWx1em0rUC9qMGlG?=
 =?utf-8?B?TXowdWdjbDVTTWFTK3ZzaTZTLzlPTklBSE0zT24ydHc3L3AwaTdDRnNzZy9D?=
 =?utf-8?B?dm9IZW5pQkluNVFTVkZQbzlWeVVMSC9aelZjS1VDRitjRlQ5Rk1RQmJySDkw?=
 =?utf-8?B?SnFhcm0rZDRzMkt0UUZreHVjM0xFWWM2TGNOSEE0eTJWSEFUWWtVbEZUZVUv?=
 =?utf-8?B?OFY1WDU0Sm9Fdit6K09YTEp3UVhBbmNaQTdoUytQWUs0YTBmdmtnbmcvNjdZ?=
 =?utf-8?B?cU51eDFrSytuUDFwS2NxOEsrQXgybTdqWVJLcGtNZXlEbit4WEVvODdSUGZi?=
 =?utf-8?B?Z1JQd1lVV1cxY3IzUGhxNFdjTlFPenl1bVhzT01BOTN2UDg0eitKS3ZLeWYr?=
 =?utf-8?B?Z3IzblM2dTJpeEV4S2g4VEppMlRPM2xITHlnMzZ5clV5SHZNUmtUSkppcHFP?=
 =?utf-8?B?R3RYNlJIdmZUSjJvMjB2eHFITHVGOXErWUdFdHIzbGlJaFdwZmNLNG5ubjhR?=
 =?utf-8?B?c1puTE9NbHdyempMRzNPeGhvR1Y0VDNtTUFQNmFWd0RjeWJKK0ZLZERVZm1N?=
 =?utf-8?B?d24yUDBSa3pUMGxCSTZLNWtLME9MaStDMDNVdjh1RHM1ZUVYMXVFZm1BeHhT?=
 =?utf-8?B?QWhkQUwzR3lhZVNCNlRDamp0UmhxZTN2Y1BSUWNEWTd3SWs0a1UzZWFCdFhs?=
 =?utf-8?B?NlhjUzE3djdsem5HRFdNL3JUUjY0N3pWcXM4UlVGanQ3MEZPMDJyK0dCd3l4?=
 =?utf-8?B?bXZVZkxieXR1Y24yUEVrN0VxQTNubnVhc0F5MmR3bEh2dnZQeHVLcFR4N1JS?=
 =?utf-8?B?Ulhub29NdCtlUTBnU0FsdUhQRlI5MnpaZmNxTlF5cm0xYmRtOStTNDhUNjVP?=
 =?utf-8?B?Y0VyZnpGbFQyU25qVGdpY2Jha0hZYVBYMnY4b01XdUtnSzlTYnFEd2hTeHE4?=
 =?utf-8?B?aXhJN0tsbnhCeUtLUTJCQ3ZsSHZ6eWZHT1pnc0trUTltbk94ZU9tZlJlYW9H?=
 =?utf-8?B?dlN3eThaQzRUV21oUy8xK25oWm5Cb0ZnSFZXcmczdnFWc1JKdXNUUEo4dnJN?=
 =?utf-8?B?Rm5VSXBuOGcwNkwwMzJ1K3dEOUlPbitYUGpSTEtpZTRJZVJIcGxPdz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dfb085d-a150-4178-fddd-08da3a17f4b9
X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1576.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 04:19:39.4897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XF5EvtqDwxU1hJTgS+gqWkdfA/jCer+vHhHCGiXl0cLdwx6Cki2weWwyG6BHrwmXqNj6esUJMBPtitzqo6+KHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4014
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Krzysztof for review.


On 19-05-2022 17:10, Krzysztof Kozlowski wrote:
> On 18/05/2022 19:36, Sameer Pujar wrote:
>> +description: |
>> +  The Multi Band Dynamic Range Compressor (MBDRC) is part of Output
>> +  Processing Engine (OPE) which interfaces with Audio Hub (AHUB) via
>> +  Audio Client Interface (ACIF). MBDRC can be used as a traditional
>> +  single full band or a dual band or a multi band dynamic processor.
>> +
>> +maintainers:
>> +  - Jon Hunter <jonathanh@nvidia.com>
>> +  - Mohan Kumar <mkumard@nvidia.com>
>> +  - Sameer Pujar <spujar@nvidia.com>
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "^mbdrc@[0-9a-f]*$"
> Why? We enforce only generic names in shared schemas and this is neither
> shared schema nor is it generic name.

Idea was to keep these node names consistent across DT files and parent 
node can allow a given list of child nodes with strict checks. Does name 
like "dynamic-range-compressor@xxx"

>
>> +
>> +  compatible:
>> +    oneOf:
>> +      - const: nvidia,tegra210-mbdrc
>> +      - items:
>> +          - enum:
>> +              - nvidia,tegra234-mbdrc
>> +              - nvidia,tegra194-mbdrc
>> +              - nvidia,tegra186-mbdrc
>> +          - const: nvidia,tegra210-mbdrc
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +
> No need for space

will remove


>> +
>> +  compatible:
>> +    oneOf:
>> +      - const: nvidia,tegra210-ope
>> +      - items:
>> +          - enum:
>> +              - nvidia,tegra234-ope
>> +              - nvidia,tegra194-ope
>> +              - nvidia,tegra186-ope
>> +          - const: nvidia,tegra210-ope
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    const: 1
>> +
>> +  ranges: true
>> +
>> +  sound-name-prefix:
>> +    pattern: "^OPE[1-9]$"
>> +
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    properties:
>> +      port@0:
>> +        $ref: audio-graph-port.yaml#
>> +        unevaluatedProperties: false
>> +        description: |
> No need for |

will remove.


>
>> +    ope@702d8000 {
> I would suggest generic node name, if it is possible.

May be "processing-engine@xxx" ?


> peq@702d8100 {
> Generic node name, so this is "equalizer", I guess?

Yes, I can use this name.