Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 22 May 2022 12:28:15 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Jialin Zhang <zhangjialin11@huawei.com>
Cc:     <prabhakar.mahadev-lad.rj@bp.renesas.com>, <lars@metafoo.de>,
        <biju.das.jz@bp.renesas.com>, <linux-iio@vger.kernel.org>,
        <linux-renesas-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: rzg2l_adc: add missing fwnode_handle_put() in
 rzg2l_adc_parse_properties()
Message-ID: <20220522122815.60f09ab7@jic23-huawei>
In-Reply-To: <20220517033526.2035735-1-zhangjialin11@huawei.com>
References: <20220517033526.2035735-1-zhangjialin11@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 17 May 2022 11:35:26 +0800
Jialin Zhang <zhangjialin11@huawei.com> wrote:

> fwnode_handle_put() should be used when terminating
> device_for_each_child_node() iteration with break or
> return to prevent stale device node references from
> being left behind.
> 
> Fixes: d484c21bacfa ("iio: adc: Add driver for Renesas RZ/G2L A/D converter")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jialin Zhang <zhangjialin11@huawei.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/rzg2l_adc.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
> index 7585144b9715..5b09a93fdf34 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -334,11 +334,15 @@ static int rzg2l_adc_parse_properties(struct platform_device *pdev, struct rzg2l
>  	i = 0;
>  	device_for_each_child_node(&pdev->dev, fwnode) {
>  		ret = fwnode_property_read_u32(fwnode, "reg", &channel);
> -		if (ret)
> +		if (ret) {
> +			fwnode_handle_put(fwnode);
>  			return ret;
> +		}
>  
> -		if (channel >= RZG2L_ADC_MAX_CHANNELS)
> +		if (channel >= RZG2L_ADC_MAX_CHANNELS) {
> +			fwnode_handle_put(fwnode);
>  			return -EINVAL;
> +		}
>  
>  		chan_array[i].type = IIO_VOLTAGE;
>  		chan_array[i].indexed = 1;