Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 20 May 2022 15:12:45 -0700
From:   Saeed Mahameed <saeedm@nvidia.com>
To:     Guan Jing <guanjing6@huawei.com>
Cc:     davem@davemloft.net, leon@kernel.org, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] net/mlx5: Fix build error of multiple definition
Message-ID: <20220520221245.bsf3abwo566l3yzs@sx1>
References: <20220520073423.35556-1-guanjing6@huawei.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20220520073423.35556-1-guanjing6@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LZepl6KdLUelwrjGb75X8POoTTfRLXEU3DaS8cMy1SdgF0SokiuZAwsUsUyw?=
 =?us-ascii?Q?rbbSUzmvxORu0E6Ed+B43uCMfaOG1qOCJvJJmqrJZiiBaaY7z1I3GjAzjYfn?=
 =?us-ascii?Q?RuCAlVuRtzIcMlT01trBrl/W5GFOtMrcZ9gUW3OF468d97R1gdgoDYyqgQ9I?=
 =?us-ascii?Q?TJzjrNXUKvQqZ7ivKepIeHjTvTBBrWPvZ9heDY23ua1jzIvQc93dCwLWYqDS?=
 =?us-ascii?Q?/SSgTygM6YWRMJwAkLiKwc14Grgona9izSwtaGL1NsjvZiJ8eFRkX3CVE9tj?=
 =?us-ascii?Q?Xrp2kr+QOlnyRiaZ1wiqzwGdgTCPh4ty1k1xkbEVKwEXjGjVHXws3Bw63bZf?=
 =?us-ascii?Q?GckkfdvStPlNdJG3Fl8NK+39vg85dARztwBe74yGY60qBAmmYXK+ZS5L2a7N?=
 =?us-ascii?Q?YPpMpU8gHAg0kxiqXGXTKaRZPdPTPRd2BhfI+7zNMnosDQsjoJ9StPKittrS?=
 =?us-ascii?Q?Yg/b+JxjINJKUHDHxZbGAdyq+/X9abLUz7NRt/b3CyW1a/Bn+kwNx3da8XPl?=
 =?us-ascii?Q?IKUKYugSMLsCQ+SKdLcT004MRODNAiPN9aM/LsBEot8fuV89oiDa8Bdp69I4?=
 =?us-ascii?Q?bG9XSVwcsq4a6nvMGtqUTlVmPfTCsfvGRrFE2JHy/atJLAmoCh5Qp4ejaAX5?=
 =?us-ascii?Q?uAuk09Sb3Vq5PzR6Z5hSSYPQVufjhYJ7QOYD4Yxa5ceRcCtWv20BOGSjMUsQ?=
 =?us-ascii?Q?SL+P8giTDvBSEiKPl+zUzRWQuvCrchSxFDeqk+QosSIdV+BFS+GLaom2OTPH?=
 =?us-ascii?Q?HRvJiKVcyijGhkWW8PJfLw0mj4TjrQTpqRy/L/WlTtAi7eJ5TumcIwgxWhFF?=
 =?us-ascii?Q?NdIkFTQJufxA4Ml+EUjcxFNkDTNC4NWoxPghW3mFdojORPAprcphi7kGTXCv?=
 =?us-ascii?Q?GDwRd1w/cFHtIipRtOkwGLRf31MVd604+bg+Hqs71/g0mYuC9ZjVEtXGLWYX?=
 =?us-ascii?Q?enaGlV4gIzCMnF2xX4EC+cORxHYg5/YBX8F5pqLHolmyHJ85jWmkXpen5g7T?=
 =?us-ascii?Q?OZuPOKWhIDfURBlj7qCu8jSy9UkTvTy4f44ViLCaVpDJrs/WOXoH8M5r08bO?=
 =?us-ascii?Q?5zqcX0I+IRniwzS7BotBzwmUpxFk7MXkbLYNJ4zJrXYRkVjR39zAAbfXNXJK?=
 =?us-ascii?Q?PFFSqS1/5ck9yVIwohfVojY8u8Gq/8i08sP5YTUoSXFYgH4Zotwyahq3006h?=
 =?us-ascii?Q?cYU7QefyetAaGr2TzPgmq5b2o9rzgANRlg+GqI4I2NP1hTYutI114zJVY0RM?=
 =?us-ascii?Q?xJW/t3Klj3FMXq1wvCa6XKiiglYKlfefJfwekRWugaNh45J/Lw2fBXkUX/JB?=
 =?us-ascii?Q?snIMinDYz315tk3rNPj7ouy7lhSLS5xDwf/t8Cemim4f+x3V8n7iVMiQrkIr?=
 =?us-ascii?Q?p0F3r4K1MJ6FrQHLx4xpUIPA2MIipbFAPqSQdMDaHBtzSGGwNc8/Ha4BItWP?=
 =?us-ascii?Q?B7kqLrEPVvsuqIKHYuONWSDVNOltcPEkUYuF+QbvRxbXrPYt32QW1mWG1sco?=
 =?us-ascii?Q?aM7B+8FSzU/A4lFr48vFTS/gHE19c34+qmhWfEbV5tsHGqRFEC/8LsRGf44h?=
 =?us-ascii?Q?JbLt5TVeFMb7kppOUhz1VA6qVVQvCLx0/6nwAcry4uKHPn2K+mYBnZ+fSYso?=
 =?us-ascii?Q?ZZBCYD1PVqVHq80Y8uvbEgafP2WZby07eAMp4zrdgHmYGq16yjqrUvomgOga?=
 =?us-ascii?Q?ZiGyEfpSUtJ0OodzAeziuw6AkhUFF7OHYqKkXiBVxaPMa/aJUEQ/P7LDGxU9?=
 =?us-ascii?Q?pP4ZSgIcpRUpokKTUpjOmwOE6KL5pUEvkhFLcHqDdv05h80pYE6G?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4f0f0b5-ed24-43ae-6bf9-08da3aaddeb4
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4209.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 22:12:46.8965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bPkv0KIg+Ihszl1+zZdGc9u9r093OlSRKvAzyCi5okryQEZ8qiZNz4id8q1/n9luacEA79wLSOMnwcLxrEiS5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1178
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20 May 15:34, Guan Jing wrote:
>There are some errors like:
>
>drivers/net/ethernet/mellanox/mlx5/core/lag/lag.o:
>In function `mlx5_lag_mpesw_init':
>lag.c:(.text+0xb70): multiple definition of `mlx5_lag_mpesw_init'
>drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.o:debugfs.c:(.text+0x440):
>first defined here
>drivers/net/ethernet/mellanox/mlx5/core/lag/lag.o: In function `mlx5_lag_mpesw_cleanup':
>lag.c:(.text+0xb80): multiple definition of `mlx5_lag_mpesw_cleanup'
>drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.o:debugfs.c:(.text+0x450):
>first defined here
>
>So, add 'static inline' on the defineation of these functions.
Already fixed by:
commit d935053a62fa11d06c757c1725782e46e7e823db
Author: Jakub Kicinski <kuba@kernel.org>
Date:   Wed May 18 11:30:22 2022 -0700

     net/mlx5: fix multiple definitions of mlx5_lag_mpesw_init / mlx5_lag_mpesw_cleanup


Thanks.