Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 22 May 2022 21:27:52 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Adam Li <adamli@os.amperecomputing.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Like Xu <likexu@tencent.com>, Ian Rogers <irogers@google.com>,
        Alyssa Ross <hi@alyssa.is>, Kajol Jain <kjain@linux.ibm.com>,
        Li Huafei <lihuafei1@huawei.com>,
        German Gomez <german.gomez@arm.com>,
        James Clark <james.clark@arm.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Ali Saidi <alisaidi@amazon.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 9/11] perf c2c: Sort on peer snooping for load
 operations
Message-ID: <20220522132752.GC715382@leoy-ThinkPad-X240s>
References: <20220508092346.255826-1-leo.yan@linaro.org>
 <20220508092346.255826-10-leo.yan@linaro.org>
 <fefc1f23-ea1c-6339-77c4-b0974cbd6e93@amperemail.onmicrosoft.com>
 <20220518061221.GA430350@leoy-ThinkPad-X240s>
 <e87bc3d7-6664-a1b7-faee-6117aa1d121c@os.amperecomputing.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e87bc3d7-6664-a1b7-faee-6117aa1d121c@os.amperecomputing.com>
Precedence: bulk

On Thu, May 19, 2022 at 05:06:18PM +0800, Adam Li wrote:
> Hi Leo,
> 
> Thanks for the update.
> On 5/18/2022 2:12 PM, Leo Yan wrote:
>  
> > Please note, in the total statistics, all remote accesses will be
> > accounted into metric "rmt_hit", so "rmt_hit" includes the access for
> > remote DRAM or any upwards cache levels due we cannot distinguish
> > them.
> >
> 
> Agree that "Load Remote HIT" makes more sense than "Load Remote DRAM".
>  
> > From my experiment, with this updating the output result is promised
> > for the peer accesses and it's easier for inspecting false sharing.
> > 
> > As you might see I have prepared a git repo:
> > https://git.linaro.org/people/leo.yan/linux-spe.git/ branch:
> > perf_c2c_arm_spe_peer_v3, which contains the updated patches for both
> > memory flag setting and perf c2c related patches.
> > 
> > Could you confirm if the updated code works for you or not?
> > 
> 
> I tested v3 patch (perf_c2c_arm_spe_peer_v3 branch) on 2P Altra system.
> 
> Compared with v2, "Snoop Peer" can better indicate cache false-sharing,
> for the 'false_sharing.exe' test case.

Thanks a lot for the testing and confirmation, Adam.

I will update the patches based on the comments from Joe and James,
after get ready will send out the patch set and loop you.

Thanks,
Leo