Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Xu, Yanfei" <yanfei.xu@intel.com>
To:     "Christopherson,, Sean" <seanjc@google.com>
CC:     "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "wanpengli@tencent.com" <wanpengli@tencent.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Wang, Wei W" <wei.w.wang@intel.com>,
        "Liang, Kan" <kan.liang@intel.com>
Subject: RE: [PATCH] KVM: x86: Fix the intel_pt PMI handling wrongly
 considered from guest
Thread-Topic: [PATCH] KVM: x86: Fix the intel_pt PMI handling wrongly
 considered from guest
Thread-Index: AQHYaH+s6PwCFUVqKUabQKcfsjJv5a0hiOoAgAX7yBCAAHiMAIAAwFlA
Date:   Sat, 21 May 2022 04:31:34 +0000
Message-ID: <DM6PR11MB4138BE4A5AC7BF9AFA8CD369F0D29@DM6PR11MB4138.namprd11.prod.outlook.com>
References: <20220515171633.902901-1-yanfei.xu@intel.com>
 <YoJYah+Ct90aj1I5@google.com>
 <DM6PR11MB41380A9DD32D6542CBC3A90BF0D39@DM6PR11MB4138.namprd11.prod.outlook.com>
 <YofCfNsl6O45hYr0@google.com>
In-Reply-To: <YofCfNsl6O45hYr0@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oC9sU87P0sj2+jcG7+qR32H1RiKdtXFtVQm9tvhF/5SLZUXAfGrQn2oc9BtD?=
 =?us-ascii?Q?3Iw0X/CR5hvg5/XzFXaY8ICTZzVMGRbNg37O2CqSl2JgFZJdy0FU2TRidFJd?=
 =?us-ascii?Q?4+RVX5t2acM1ETkaixoPNMnyYBU+Yug1OiWZwdt5lyjzEiUEubb8c6ByhCvm?=
 =?us-ascii?Q?3SSdCrVi3vIC30bGJZXLkUj2Yla0lToGUd5nuRZb5tIIQSReZ6DZb2Sk2pIp?=
 =?us-ascii?Q?yT1L3ZdPqoDDl8xP/vxRhfKFhKqky50zUkR3i7NbR72FHWBq9YYm2374Ger6?=
 =?us-ascii?Q?n5Xgy7nz0NlEBW6AEuyE/yacq8s6plJdTZE3bU7xcVI+q3gpaW6tXWTtHf40?=
 =?us-ascii?Q?zFfQGB6UI+7SL4Vj02AnEli70+5VlZic+xlDOR9TcjC3G0JX1umY+GFEB5Ij?=
 =?us-ascii?Q?/Mh9QJqRkYETwFELTaAFIVf6tEEM+ZmywRdiae0lYXoEiW9fp1Y2VU7b+ZeN?=
 =?us-ascii?Q?kV7QcFtBiU6PH8cuJ/lMQtvu2G3WCsvvVxWocOX7Fu81JjsETauTtn/enyoF?=
 =?us-ascii?Q?ZKfeUtBMwftEOR3ldGtvJ8DigN4EOqYgKPOm+HGUZqUYRkyAYc4xrKWgQor8?=
 =?us-ascii?Q?KC/GpNsjEJX5oBVn+4gnDJSTS9p2ZpS/f0b6JcKp3hZu1u6ckpr2EATfoDBh?=
 =?us-ascii?Q?PJ9f+zk4FmRLLKQyZGfBzM2Hg9pqNHj95e//P0herpge4mEiZeSOgInR17lu?=
 =?us-ascii?Q?gTeWnlSTmiYrMK1oN/BE4WSmwky4ezajsqJnzhHUms1yIUlKeWVPqn8TkpSU?=
 =?us-ascii?Q?hEfB2YhXf3vhWqrGcwkZ+fDfH/rMYdnWy0hKPobWdNn13izoFib1GXhVVm4V?=
 =?us-ascii?Q?JKTB9gy3bWeleVCS/lveWplSVDn0rlBhHh/QIhMqjqOX+gWrjViwWnRkiZZL?=
 =?us-ascii?Q?C7XwsYf4SO6h97BKvid4ExUAtfyeK0joY8ta78QFc4q9pDIB56Twwe6mvLLn?=
 =?us-ascii?Q?Q6b5AesS5FeM3Me4fTuXweDJCekLQLss/a9SW/b0yfjUeb3ErpdvsRe6sG4G?=
 =?us-ascii?Q?0EgMvk5a02aF+TV6P+WESAA3X3JmfOFoqkrkXWTNxK+l/HaoUbqfvHfsT4DN?=
 =?us-ascii?Q?coTjYE+pcW6ovVfyLh1mMhaNeDa74ZpJVA/kecjKxv/aD9nt5Y9GlbLkSELb?=
 =?us-ascii?Q?WP4t5hvQsdry15ys8pDavQFd0sOq1u8ldqb+bj9p4YcHk+TnwdI3v4WVONxt?=
 =?us-ascii?Q?JhVcZgvJ8HLWwoSIcq3U0U/ojYGRGYoWzYuBVHhdU07G/8Ct+t+DD7QlTJE4?=
 =?us-ascii?Q?tNq46vct9euA0Qw6DyqbwJRpQNe96h8IaNoS6fYM36lO2JnqWsygbuRCAz8q?=
 =?us-ascii?Q?CDS8z/IndVjCCsCWHfZUGQhnPxo/soB49XFTj/VRIGGPBmZfCiwF1Y114bbp?=
 =?us-ascii?Q?eilKeh38HLNc6I6kdS0dWBM4uSg8Sdn0BsWP8wiU8wfHQd0VBmLnT6ZPvVwO?=
 =?us-ascii?Q?BGpnPy5S6QVT880QZhBLsQfSE3X8dRWRKMKSlNN6MaY7MyEOre18vQ8tDMiJ?=
 =?us-ascii?Q?KFrURPxpFZoC2uI45a+nn7D45YKGXCG4FBfjDwGMdwIVY/8NLQekdaRhu8QH?=
 =?us-ascii?Q?KKgAWuXmhrhLAxdYEYJD1Jz+oEVA64vvWnRU4ztRd6vgHnvLz7KUBnFMo/YT?=
 =?us-ascii?Q?jtreOwaKlHHvfH/WMoxdxv+GqZ1bXoSAgkQjoYfXlZ686ty6LHotgbFCEobw?=
 =?us-ascii?Q?4p+7pNgRGdUKpc+YNjai3M/RuPfzgSNl9IN5y9/imu5j55WcyjPzP2U5BamT?=
 =?us-ascii?Q?OJIg39MxYg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4138.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5df273a3-cfde-4a8b-3396-08da3ae2c983
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2022 04:31:34.3872
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fSeL6RTt5/H+RYnqqcl7TTdJWqRVkEY+JRs2qjG3esO3CQyeBCwBYtuMYVVugTHPR43cnE5Y+/yzFJ4eMFmX9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4476
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Sean Christopherson <seanjc@google.com>
> Sent: Saturday, May 21, 2022 12:32 AM
> To: Xu, Yanfei <yanfei.xu@intel.com>
> Cc: pbonzini@redhat.com; vkuznets@redhat.com; wanpengli@tencent.com;
> jmattson@google.com; joro@8bytes.org; tglx@linutronix.de;
> mingo@redhat.com; bp@alien8.de; dave.hansen@linux.intel.com;
> x86@kernel.org; kvm@vger.kernel.org; linux-kernel@vger.kernel.org; Wang,
> Wei W <wei.w.wang@intel.com>; Liang, Kan <kan.liang@intel.com>
> Subject: Re: [PATCH] KVM: x86: Fix the intel_pt PMI handling wrongly cons=
idered
> from guest
>=20
> Please don't top-post.
Got it, just correctly configured my mailbox with prefix each line of origi=
nal message.

>=20
> On Fri, May 20, 2022, Xu, Yanfei wrote:
> > From: Sean Christopherson <seanjc@google.com> On Mon, May 16, 2022,
> > Yanfei Xu wrote:
> > > diff --git a/arch/x86/include/asm/kvm_host.h
> > > b/arch/x86/include/asm/kvm_host.h index 4ff36610af6a..308cf19f123d
> > > 100644
> > > --- a/arch/x86/include/asm/kvm_host.h
> > > +++ b/arch/x86/include/asm/kvm_host.h
> > > @@ -1582,8 +1582,14 @@ static inline int
> kvm_arch_flush_remote_tlb(struct kvm *kvm)
> > >  		return -ENOTSUPP;
> > >  }
> > >
> > > +enum kvm_intr_type {
> > > +	/* Values are arbitrary, but must be non-zero. */
> > > +	KVM_HANDLING_IRQ =3D 1,
> > > +	KVM_HANDLING_NMI,
> > > +};
> > > +
> > >  #define kvm_arch_pmi_in_guest(vcpu) \
> > > -	((vcpu) && (vcpu)->arch.handling_intr_from_guest)
> > > +	((vcpu) && (vcpu)->arch.handling_intr_from_guest =3D=3D
> > > +KVM_HANDLING_NMI)
> >
> > My understanding is that this isn't correct as a general change, as
> > perf events can use regular IRQs in some cases.  See commit dd60d217062=
f4
> ("KVM:
> > x86: Fix perf timer mode IP reporting").
> >
> > I assume there's got to be a way to know which mode perf is using,
> > e.g. we should be able to make this look something like:
> >
> > 	((vcpu) && (vcpu)->arch.handling_intr_from_guest =3D=3D kvm_pmi_vector=
)
>=20
> > Hi Sean,
> > You are right, the change of kvm_arch_pmi_in_guest is incorrect, becaus=
e it
> should cover two cases of PMI.
> > For the PMI of intel pt, it certainly is the NMI PMI. So how about fixi=
ng it like
> below?
>=20
> Yep, that works.  I did enough spelunking to figure out how we can fix th=
e
> generic issue, but it's per-event and requires a decent amount of plumbin=
g in
> perf.

Agree, it's per-event for the generic issue...
>=20
> perf_guest_handle_intel_pt_intr() doesn't bother with perf_guest_state() =
since
> it's such a specialized event, so fixing this in vmx_handle_intel_pt_intr=
() would
> likely be the long-term solution even if/when the generic case is fixed.

Will send the v2.

Thanks,
Yanfei