Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1676845ioo; Mon, 23 May 2022 00:01:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVslTKYZ4TmN7QA7cb2GFujL/U10x0jXNP1ityKCEzwILKdifHod+KFRUWqblOULqGrwo/ X-Received: by 2002:a65:6a15:0:b0:3f6:1815:f540 with SMTP id m21-20020a656a15000000b003f61815f540mr18648177pgu.45.1653289260064; Mon, 23 May 2022 00:01:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653289260; cv=none; d=google.com; s=arc-20160816; b=w2UYKcd7XrIcJtClmgU0lWDAZasgf7a4/6goA0ZLEbsKrkVE+BEKlStvt3Q26LKtRS jPo3nZmVKuWLCZgiA2p2l/Hu1BIIQJkah3rrwFNynSLZCoSQ5oysw3fxEPw1xRem6abV pGvt8TKBRRewvXJO7qwl5lQe7zXCAlrjJ+ot4J0D5p7sZb+VVuMSrXETpi+1jRc52KAQ kj0wo5e0rBaJz7VwM5ce78WfZqsso4hR93BXPA8RA/KWZlwaJQSwm4KMql3ELc6fz93k RSa0Iw5y+GgkEZv1EyqU+XZZbdm0BEyFD1maa9erbABQZQz1dMb27Mbf1hQo2j+mSy3b UcRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bVD0y6J3Jxfr9SznsS07NePMoeuEYEpcA6UqHaJNxic=; b=MDt/Uc3MxCUwzz6sWrAZORC5W8nVBK2+zO3YlAcrSu3z91NeL9As9GxGdYLfcWcVZB hEs2PhELz1IMHpCcwpDIp0YfSDF4/if13EWBgoo+FEVBsFtoOzPwTDeGOXNNLkBjxAAN lXvbNsGACRAULh6q9m46Eju6QBP7BgVN/AGasHvtMEzhRuExKmwPCKLQbiP7F9Fj5N2d bx62cjiHVKTJGV6u+xWmv8MPBZtiEKEdCAMS0l5yOiz8ydKHI4T9qOaL7tohPAnslS7W SJC6BMGyFTQaaMXADIzW3nuavqGyLLfU0vecN60ElyUr/VQCwzsxDXo+lnOhmwae2YxF qy2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fqMcbs48; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id m10-20020a056a00080a00b005188b59f9f6si7161610pfk.24.2022.05.23.00.00.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 00:01:00 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fqMcbs48; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 201C7644E9; Sun, 22 May 2022 23:25:31 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243043AbiEVKJA (ORCPT + 99 others); Sun, 22 May 2022 06:09:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbiEVKIz (ORCPT ); Sun, 22 May 2022 06:08:55 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 063683EB86; Sun, 22 May 2022 03:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653214135; x=1684750135; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+ldVfAkI63e7T9H9+Tu6rkR3XDiV/+stA3qHNtz8ShU=; b=fqMcbs48cA3u/tkSq0h0hOc/tsat7AIBWsHThBL2I3/Mte54HeMaXpXe K+ovU99hntEQEHj50yvPvfSryz40huKAtsNRrSlbyT4HkfP3w1PLVpmTu 8FDIFop5Bltlh9FI2lSRA9djUsfzq7K3W2QfLrZNQRzUEZe5Uygm+W+P0 9IqRpo6uPsvSM+fcr5opM8HtiMD9XVknclTxM7/zDyyqFbgyC3elICCFZ wjxLx59jCQKtaQw1bndoDnQsXqB6gbv/NBnsMe95aplRu6JL3U/yhCumX EFzbb+B/yyzfZV8JiVzmqGiH4BOMSeHb6Z7zvNpJpPecfg1Cf+/58R6bh g==; X-IronPort-AV: E=McAfee;i="6400,9594,10354"; a="272956338" X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="272956338" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2022 03:08:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="628872786" Received: from q.bj.intel.com ([10.238.154.102]) by fmsmga008.fm.intel.com with ESMTP; 22 May 2022 03:08:50 -0700 From: shaoqin.huang@intel.com To: pbonzini@redhat.com Cc: Shaoqin Huang , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] KVM: x86/mmu: Check every prev_roots in __kvm_mmu_free_obsolete_roots() Date: Sun, 22 May 2022 19:09:48 -0600 Message-Id: <20220523010948.2018342-1-shaoqin.huang@intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shaoqin Huang Iterate every prev_roots and only zap obsoleted roots. Signed-off-by: Shaoqin Huang --- arch/x86/kvm/mmu/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 45e1573f8f1d..22803916a609 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -5168,7 +5168,7 @@ static void __kvm_mmu_free_obsolete_roots(struct kvm *kvm, struct kvm_mmu *mmu) roots_to_free |= KVM_MMU_ROOT_CURRENT; for (i = 0; i < KVM_MMU_NUM_PREV_ROOTS; i++) { - if (is_obsolete_root(kvm, mmu->root.hpa)) + if (is_obsolete_root(kvm, mmu->prev_roots.hpa)) roots_to_free |= KVM_MMU_ROOT_PREVIOUS(i); } -- 2.30.2