Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 23 May 2022 11:13:24 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Daniel Vetter <daniel@ffwll.ch>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        David Airlie <airlied@linux.ie>, qwen@analogixsemi.com,
        Jonas Karlman <jonas@kwiboo.se>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Chen-Yu Tsai <wenst@chromium.org>, bliang@analogixsemi.com,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
Message-ID: <20220523031324.GA3738288@anxtwsw-Precision-3640-Tower>
References: <20220422084720.959271-1-xji@analogixsemi.com>
 <20220422084720.959271-4-xji@analogixsemi.com>
 <CAG3jFytWGSUM9mevHewdmEe-hq3JgB74s7_f0fsEQqkXr9VUHg@mail.gmail.com>
 <CAG3jFyvEYbwkdGtiNR-6vFEXTLjcyT_viqp9qeVxFTu0PrJEVA@mail.gmail.com>
 <CAGXv+5E1cCNWD98fMDjC38y2UztZd=PNQ+=G=wrBYfoXkswvHA@mail.gmail.com>
 <20220425091419.GA967110@anxtwsw-Precision-3640-Tower>
 <CAG3jFyvTim7P_y2G1Br5j3Pwz4KzvRjWgci_qQ3m_YW=3Bog8A@mail.gmail.com>
 <CAKMK7uFHyYTnGtP+vCzo2Uan90DW-QZpPFPn5S9bQ5aPiY=qzA@mail.gmail.com>
 <CAKMK7uHFGsPMZf2SUF4HDXo3XuOLjP3-DLfyp=gB2qpKR964Eg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKMK7uHFGsPMZf2SUF4HDXo3XuOLjP3-DLfyp=gB2qpKR964Eg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PIVf0o0XhooShCnitK4RpeZHwr9AgDe831lWB+dVyuLWGgBJbAMvqNNArIuW?=
 =?us-ascii?Q?0cKPHurJpAgpGe8k3cjxg+C6R56gqdqMTwnwHg+pu1LISLWD0w0JLv99s0td?=
 =?us-ascii?Q?UvtDQAy7PeFLG2vCGdIPr0m19dnRpALvsdEQ0a+dtmjEAbgX8zakJPt4q4Gt?=
 =?us-ascii?Q?T/2GMGiSntHLCDI6HfvFix8GMd3UUujwN+IuQMKy5PXedDogW0GGRNnpZ8Ca?=
 =?us-ascii?Q?PotSYPggSw7fTCmfqolRIw4q/VCsb3YdQw+h+uhuSBHeLxBQ+0CncL+Gs1zt?=
 =?us-ascii?Q?3oOczqRqs3zt0vKnNcVm15DyAcgCgVfj4EskskSpgn9o6UK60qg5GZ1ReqVD?=
 =?us-ascii?Q?PSdvj0q0utCmrJPzLp1byXpCqjJPYC8pBqA+KQZtJ3WLpO6IQd29igjTvskA?=
 =?us-ascii?Q?/9f5JcbHopopGqQWtIItqagrCpY0Nnk5bm/EkvGrhyCOO2JPDCWDS5rUrjRo?=
 =?us-ascii?Q?g0SEdw7XVZwoi/XlaOsZUc+N3ujoj47xOKs4zfk0ZQjhSggno5L8p3scNwR1?=
 =?us-ascii?Q?aM936Cls9WGy6bSPp2JSBKhiuBwH0JXdXAeoO3mv8qA4uB9Yt1TZX7vRm6+u?=
 =?us-ascii?Q?ZeEdYLH60KrBAf66RDUGgBfXZP/geuxahleeE1j3jPVA345AoBpt9O/XLaW1?=
 =?us-ascii?Q?sScr511JJ1s3JR8+6WBb34y/KnQ7ZiyklQvvReEjamGR9Ku5hb+at0sGafXo?=
 =?us-ascii?Q?dFjk8KOh3FW4YgeY4EtxlfW98sI1UTyujBhACH5wZ358oKTClpGLNX4lcuPy?=
 =?us-ascii?Q?bk66yrKK+6W/RESiGTBVzgMnxZSQqPiryh3WBDfUtVC8dortOfpPbXYLdzBb?=
 =?us-ascii?Q?0njD+4P0wd8JuC5hORU1WPSfTwEQozbB/q351NEQ36vNou4gvbVJQyqj5eoV?=
 =?us-ascii?Q?6zEfy/yvbFiuPiKV2a6Z1I7TDXEpceKNgtEbhMz/pd4f4WVus8prqSlAcKWR?=
 =?us-ascii?Q?xMIY09q6LwbWiZFMqtyaiq54NTdnmA8CVgFSLi4JHDmW0+uwGVKro3knk4aR?=
 =?us-ascii?Q?xU+tAP+FcEbhvy+3N4icaAk/OpPbj08sHOD4yv7CAIHUBP1TBac5UYMalZj4?=
 =?us-ascii?Q?ToaTHorOtN65DIo2BizzCotNsD77+6ZUstpXd3TUFAp4fWvVtiLbG1XwFhkv?=
 =?us-ascii?Q?50B8nj8kM7DJL+ddK1HOJlVM2bHUJbs+gk9vaxGlsGD2s9q4JOVIssXpj+UG?=
 =?us-ascii?Q?ixfD17cgwzjDgvVwVE+6uU2Ztb0fbZoSjxKmrgwG8uhNiSBzeIhKb3h6tkl6?=
 =?us-ascii?Q?oU7OJXt4Rlb0dDZdBdc8d+JsLYDK5P1798PP6S7SyV3VaDUDwzRbtdaBWc2l?=
 =?us-ascii?Q?m8hao8TA4L+iZ1uoqLtE9lQaZ/Fv4OWRAnwF8GYmNIQbAKFDoc6k3cmhLxMI?=
 =?us-ascii?Q?BUg5bVs7x1EYzx24r3UYUC1/VkD0MlSMzqjvXq/9MGR7G6wWwokyG/9PydhU?=
 =?us-ascii?Q?wE/8hvg22GMdw0WMfn6F0dpRzm/HPBipTeoVUc4l8MPcniEtjVRBlFwddbbJ?=
 =?us-ascii?Q?isyk0KJAdE5jxxB9tRwysiOESVVa9BtYdwCFMgL3m0vSQ0Yr8bVsvCq9pBL+?=
 =?us-ascii?Q?3+QLRKcZiCwz7VBkXj2zYVyDt7sIFjinNmm9MrxqflKCYo/P71E8AVRRXlnD?=
 =?us-ascii?Q?6gDNtCZzmu24g4TOLNPD8ynFWkKkt9AoAlbYZjOBGsYS8bdWN1KnGM1D2a7g?=
 =?us-ascii?Q?/Ct1Wg+GTgVXhbqoTiDvrbNAqR8l0gdiRHxhpl7lz4hpYj0L1J3AOPBhzMCv?=
 =?us-ascii?Q?xNG6KoHjJw=3D=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 803b5aed-5a6e-49de-00fb-08da3c6a3824
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 03:13:33.6960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 47C/ln+CwoClgbEtS+F7lsSAlPDjjrRKjHrqJqY3B1wD5h/J2xvdkXH/eGRZUYHYsSCtujSSUv2wysi3DIx08g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0401MB3509
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > >
> > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > >
> > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > >
> > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > ---
> > > > > > > >  drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > >
> > > > > > > >         anx7625_get_swing_setting(dev, pdata);
> > > > > > > >
> > > > > > > > -       pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > +       pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > >         pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > >         if (!pdata->mipi_host_node) {
> > > > > > > >                 DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > >                 return -ENODEV;
> > > > > > > >         }
> > > > > > > >
> > > > > > > > -       bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > +       bus_type = 0;
> > > > > > > >         mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > >         ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > >         if (ep0) {
> > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > >                 mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > >         }
> > > > > > > >
> > > > > > > > -       if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > -               pdata->is_dpi = 0;
> > > > > > > > +       if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > +               pdata->is_dpi = 1;
> > > > > > > >
> > > > > > > >         pdata->mipi_lanes = mipi_lanes;
> > > > > > > >         if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > >
> > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > >
> > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > >
> > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > >
> > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > mainline (next-20220422).
> > > > >
> > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > each patch. In the case of this series, they should have been sent
> > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > everyone has the same, full view of the patches.
> > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > Thanks,
> > > > Xin
> > > > >
> > > > > ChenYu
> > >
> > > Applied 3/4 + 4/4 to drm-misc-next.
> >
> > This patch doesn't even compile. Can you pls fix this up asap? Also
> > pls compile-test before pushing ...
> 
> Marek says the prerequisite landed through linux-media, and that's why
> it compilers on linux-next but not in drm-misc-next.
> 
> Don't do that.
> 
> Instead:
> - merge all patches through one branch, with the foreign patches acked
> for that merge patch
> - wait until you can backmerge all the dependencies
> - do a topic branch
> 
> This probably needs to be reverted here and instead merged through
> linux-media. Or you wait until -rc1 and then apply it to
> drm-misc-next.
> -Daniel
Hi Daniel, I use git send-email to upstream patch and automatically
generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
these 2 patches already merged in linux-media.

Thanks,
Xin
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch%2F&amp;data=05%7C01%7Cxji%40analogixsemi.com%7C80ac2fb262a5407ded4208da3b46ff62%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637887473373535347%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=lYWBVSLPiHKN%2BYnyWqgeM5cgH17OjxpXGVQ1kt2bZrU%3D&amp;reserved=0