Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sun, 22 May 2022 12:04:09 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Vincent Whitchurch <vincent.whitchurch@axis.com>, kernel@axis.com,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: trigger: sysfs: fix use-after-free on remove
Message-ID: <20220522120409.5e169a8e@jic23-huawei>
In-Reply-To: <d777d12c-7fd2-07d8-60ee-d2dc8f73f6c7@metafoo.de>
References: <20220519091925.1053897-1-vincent.whitchurch@axis.com>
        <d777d12c-7fd2-07d8-60ee-d2dc8f73f6c7@metafoo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 19 May 2022 11:58:03 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:

> On 5/19/22 11:19, Vincent Whitchurch wrote:
> > [...]
> >   
> >
> > Fixes: e64e7d5c8c86e ("iio:trigger:sysfs Move out of staging.")
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>  
> 
> Thanks for the patch!
> 
> Strictly speaking the Fixes: should be
> 
> f38bc926d022 ("staging:iio:sysfs-trigger: Use irq_work to properly 
> active trigger")
> 
> 
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
I've changed the fixes tag and applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> 
> > ---
> >   drivers/iio/trigger/iio-trig-sysfs.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/trigger/iio-trig-sysfs.c b/drivers/iio/trigger/iio-trig-sysfs.c
> > index 2a4b75897910..3d911c24b265 100644
> > --- a/drivers/iio/trigger/iio-trig-sysfs.c
> > +++ b/drivers/iio/trigger/iio-trig-sysfs.c
> > @@ -191,6 +191,7 @@ static int iio_sysfs_trigger_remove(int id)
> >   	}
> >   
> >   	iio_trigger_unregister(t->trig);
> > +	irq_work_sync(&t->work);
> >   	iio_trigger_free(t->trig);
> >   
> >   	list_del(&t->l);  
> 
>