Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3280426lfo; Mon, 23 May 2022 00:35:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkjyu0LZ8o2x6i0gMSuuCD4k1WBjSDcF57eR/O1L56WqAk2XRoOIC/7z2Opp9o9KRhDuCA X-Received: by 2002:a63:688a:0:b0:3fa:6738:7d7b with SMTP id d132-20020a63688a000000b003fa67387d7bmr2278049pgc.545.1653291311402; Mon, 23 May 2022 00:35:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653291311; cv=none; d=google.com; s=arc-20160816; b=EPwkxZX9C8Qcoav35QoMvuNic0IKrRmvMjO88K1qAcDHTtKIqAAWBLgUPwiRMcGpAP PnbZoozwcUaWLtyZ9W8v8As4LT5iHMgEHK0A9LRYQD26zdwOa972e3rnZ0sVUYPP15X5 gE8FUw833Y0k1XoKa6N2VyQiOtQeHgdVx2U2KgCnWOssT5e1qQVyf4t/WLFHqiD208bl JaCpRJB59QOFKT2LHKyNt3GYE/8Jk6iM0U/7uay3OVEpVn/t2EaqfWWphGlTXiEqgcXj DnqswHt4PRtIQp9sS7MUoMNkbwZ+nOLw50aSofGXpvUi7XpQAzJOGtrQu06t7fh0Nszr zAhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=sIDkt1OCI8X0BLZktYQl8dg6BjT6OxWGAMz17UCt98M=; b=C9a5sEDKPzbJFVVmAFa0vQgmo545ksxhhHSnhm39Mhng1KO3kW1a8szmhdY2+BY/3o wnzgjx+LnNKtxhxOhz27jl5OOmyLZWKFS7TYQGx297VdSUfK7CuyAhDf1xiVpGIsvTVL bmqE+4Ubh/zPLME3rlTp1gJeQYbf7wt5xhT36xnSZHZcVOO+cdWnF5fTi4kzQ9Ge8FEe x5f9Hin4LBz3I+ZT0BilUclbUEfFoFiXo5JHCpBNgPG3uNMvjaq4zayJCqeYrjU1ZsAb S+fAXN/hcBGMMT2QNR3c1RWDYDuXtr3F18/uqR+37rRF+7JHN6ZS6s2q1jzxnYRSD3Ml iCCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=JQg6UnLz; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n5-20020a170902f60500b00153b2d16579si9556877plg.385.2022.05.23.00.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 00:35:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=JQg6UnLz; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9A1A51B0918; Sun, 22 May 2022 23:45:06 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245656AbiESXYJ (ORCPT + 99 others); Thu, 19 May 2022 19:24:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241874AbiESXYI (ORCPT ); Thu, 19 May 2022 19:24:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BD5910657C for ; Thu, 19 May 2022 16:24:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 53DE7B828D4 for ; Thu, 19 May 2022 23:24:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B393EC34116 for ; Thu, 19 May 2022 23:24:03 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="JQg6UnLz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1653002640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sIDkt1OCI8X0BLZktYQl8dg6BjT6OxWGAMz17UCt98M=; b=JQg6UnLzgnyN5LuZaqol0hfI0aypwpw6NiFctHfnyIWdQUIumE7QFeOcNcyrHt8aMamxZr 8vqyXHpPTW4UNLSSQKjkc25aldwBakcq+B4cnTYBZQoV+ixmxhWJddcPB5cg65l3LgHDCz P8i6YJCnWE9jKvpfWlPkEoGe+LTkFwk= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 0d9390c8 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Thu, 19 May 2022 23:24:00 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id t26so11565919ybt.3 for ; Thu, 19 May 2022 16:23:59 -0700 (PDT) X-Gm-Message-State: AOAM532QXILdzqH5vvVtSUIbXwCa0Q7n40ifXaHFqsRnw2SSzU8XAK6u njk1Pw2GmmApcoaprPmxMyUIIktchCB5FA1Et0M= X-Received: by 2002:a25:bf85:0:b0:64a:422c:24e7 with SMTP id l5-20020a25bf85000000b0064a422c24e7mr6982080ybk.637.1653002639398; Thu, 19 May 2022 16:23:59 -0700 (PDT) MIME-Version: 1.0 References: <20220519193133.194138-1-axboe@kernel.dk> <3553b935-0aca-3d3e-2495-12288f601b53@kernel.dk> In-Reply-To: <3553b935-0aca-3d3e-2495-12288f601b53@kernel.dk> From: "Jason A. Donenfeld" Date: Fri, 20 May 2022 01:23:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHSET 0/2] Fix splice from random/urandom To: Jens Axboe Cc: "Theodore Ts'o" , Christoph Hellwig , LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jens, On Fri, May 20, 2022 at 1:19 AM Jens Axboe wrote: > The source and destination for the copies are exactly the same with the > change as before, so no changes there. The non-user copy is a different > helper. Oh, okay. Maybe a silly question but: should we wire up that helper too? (If I'm understanding your meaning right.) Seems like it'd be a good idea to just wire up all the things while we're at it. Jason