Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 20 May 2022 10:36:30 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Matthew Rosato <mjrosato@linux.ibm.com>
Cc:     alex.williamson@redhat.com, cohuck@redhat.com,
        borntraeger@linux.ibm.com, jjherne@linux.ibm.com,
        akrowiak@linux.ibm.com, pasic@linux.ibm.com,
        zhenyuw@linux.intel.com, zhi.a.wang@intel.com, hch@infradead.org,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org, linux-s390@vger.kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kevin Tian <kevin.tian@intel.com>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM
Message-ID: <20220520133630.GG1343366@nvidia.com>
References: <20220519183311.582380-1-mjrosato@linux.ibm.com>
 <20220519183311.582380-2-mjrosato@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220519183311.582380-2-mjrosato@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SdJhQN3qKKVUyKaPOZLCHGaPuFJALx0NnKFS3NG4WcAvmJtn8qV3pgPilAwq?=
 =?us-ascii?Q?xTee3n5lMKCOkD76Kxt2VxdzCD/Je/FO8v/szZ5Q2OI+hYctk5KhCnam6qj1?=
 =?us-ascii?Q?YB8TIZI/KKXXU92WCnTgWbNq9Y5SfgT5Pe82e3JM9PFoihDdcTjjkL4FRrhq?=
 =?us-ascii?Q?DQmMfj4DsUMXjjw9Q/11Pi03m/7JZ8bD8sxv+7UyfzTWvr8pCYTIZhbbAnUg?=
 =?us-ascii?Q?r+WmgjyKTA8LzZH68J/tRpxoGnzNkZmHB75YJUk/6v5Hrd9dM7VK4M0nZUeo?=
 =?us-ascii?Q?vr//aeFW1mAQ3d0Nqj0ItrZZ5WzQsJ4q+MbGWJCEJi14huZoz1MiHWeGF90M?=
 =?us-ascii?Q?avUuCVLBtYDBrk4hyhhw66TlRlPVs54BsFxopeOVd+ODh4FjLHyuilYwJiIW?=
 =?us-ascii?Q?xiGQh8E2VH2iFC2xONp22l0sYNy7rnmw8ajrPsSh8Ju8SCqfWXg3Sp/MbEcP?=
 =?us-ascii?Q?YfSKnBACCnNr/Qg+cPFJtOTOQ1sTgYY6pFgRwxyjHdasr07EMn3AKzGr7XMv?=
 =?us-ascii?Q?rq0KuRY1LGgXVNAvQsvEewiIfc909cnT2+eg2Meq1GEetdfFxKbgonTR9ofW?=
 =?us-ascii?Q?Z6vdPWMcZoEP4UBVvCiHBS6WOcUntGE59aFgb2jp+BXpJUEd2binPrKJ1UI2?=
 =?us-ascii?Q?ysF7zWRL8Z0GhViVJL6BW2mhCrzX0IOzBZoTbzsgvVQbtRI//M7Go7swbBhY?=
 =?us-ascii?Q?tHM02YMnlJ5UoS75sblfvMQ460ap8H7rhjvIbo2s3FBYEBT5i6XLL1Gge4h/?=
 =?us-ascii?Q?wrPwUr/rpsTTOOJPA4yhlkFWOKHVXJkg6KSEQP3gSl7BWwmN+IPT21zRwcjf?=
 =?us-ascii?Q?w+zsDLOqS/vklx82C4AXvXHGFB1YEBvsNobUu+1xy9uCVIwCu6T+Ah1avyAb?=
 =?us-ascii?Q?S+V9FOoA7Ns8i6iRzZog+qyOY3kQxF/UHtF5KLBt0CaxX1ndp7+U8XyO3Gur?=
 =?us-ascii?Q?aMfnfcMm6QIZ8BqWqrMY2hyxU1rDuSn5iCZcfyCJwQgrSQbY2yZYdpUg4xYH?=
 =?us-ascii?Q?A6JY0Mrs1wxZVg2cywSfeTW9pyUHmJCVw7paE+kqaodmUfdg1D2tajE/G8N+?=
 =?us-ascii?Q?Qq1qqqB/9aoHfuzIXz//ry+acR50HlxMIMzfS2BMIivEkCEFFKVE+VA91VgG?=
 =?us-ascii?Q?VfpH60XTmQhcILZ3/KJuCyAAj8o+BJ2gBEdPPsmKgSMmbi22P4tBy3X5/Dwy?=
 =?us-ascii?Q?iJoOJQDbs6xn/gnlGKickUnHgdK/a9k5VxQE06MN4xB5HKPW9CqcwTn/wp8x?=
 =?us-ascii?Q?9DpLsGJ97zKcLIPw2G6JDvZInGpLBYdB1N3KbwON4t3/RTM3txtbO6oeKPk+?=
 =?us-ascii?Q?miCO5CYE5gcQSyYbx8zyqQMZ7PSzmZuQMthE1jMi52HLcnVI99Clhl9IIeUV?=
 =?us-ascii?Q?EEBvkSP8X6g+pme7FLDCiHkOPi1Reqo2DX+1RDY0vvw5RJPWE5FGgeIRnfzl?=
 =?us-ascii?Q?Qyz1V+Gb6ve7w5eezLCavKa9cmOYaYDp8X0G8qgfynYDR+8SBC37ki2lJQgO?=
 =?us-ascii?Q?XY6tuESA7JKZAdCGufX9B41VPLcABw2C6PppSfSY+HI/vE5zJOYM4ou8KBYG?=
 =?us-ascii?Q?+wQateJw+0ccCi0A3cpf2y5LhvfHaEqqAVnM4dje5M0AW+FHlu+HyaKgiYjw?=
 =?us-ascii?Q?ZaLAsjd+r6Y5I6SyWsgMvYuBqFm7Vxkd1WyOtR24TEuWA0NMgLzHI2gXCwsy?=
 =?us-ascii?Q?lk3fhwNVPMIWRrKa/LyQoN3S02uDAGmyo4+EB8sqBu6C7PK1lrp61gmE+7pJ?=
 =?us-ascii?Q?7aVniwLTgg=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6450de01-6887-4214-6ec7-08da3a65c061
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:36:32.1783
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6qdNHD2vr6Nb93Dd4fGdOJmd6gCsTlqRBB6iVfcCy1LJBod4lVhAInHlnbajGGao
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB4977
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 19, 2022 at 02:33:11PM -0400, Matthew Rosato wrote:
> Rather than relying on a notifier for associating the KVM with
> the group, let's assume that the association has already been
> made prior to device_open.  The first time a device is opened
> associate the group KVM with the device.
> 
> This fixes a user-triggerable oops in GVT.
> 
> Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
>  drivers/gpu/drm/i915/gvt/gtt.c        |  4 +-
>  drivers/gpu/drm/i915/gvt/gvt.h        |  3 -
>  drivers/gpu/drm/i915/gvt/kvmgt.c      | 82 ++++++--------------------
>  drivers/s390/crypto/vfio_ap_ops.c     | 35 ++---------
>  drivers/s390/crypto/vfio_ap_private.h |  3 -
>  drivers/vfio/vfio.c                   | 83 ++++++++++-----------------
>  include/linux/vfio.h                  |  6 +-
>  7 files changed, 57 insertions(+), 159 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason