Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 22 May 2022 22:09:35 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Tali Perry <tali.perry1@gmail.com>
Cc:     Tyrone Ting <warp5tw@gmail.com>, avifishman70@gmail.com,
        Tomer Maimon <tmaimon77@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org,
        rafal@milecki.pl, sven@svenpeter.dev, jsd@semihalf.com,
        jie.deng@intel.com, lukas.bulwahn@gmail.com, arnd@arndb.de,
        olof@lixom.net, Tali Perry <tali.perry@nuvoton.com>,
        Avi Fishman <Avi.Fishman@nuvoton.com>,
        tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
        kfting@nuvoton.com, OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Linux I2C <linux-i2c@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 08/10] i2c: npcm: Remove own slave addresses 2:10
Message-ID: <YoqYf0KdNEabT7Mu@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Tali Perry <tali.perry1@gmail.com>, Tyrone Ting <warp5tw@gmail.com>,
        avifishman70@gmail.com, Tomer Maimon <tmaimon77@gmail.com>,
        Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Rob Herring <robh+dt@kernel.org>, krzysztof.kozlowski+dt@linaro.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org,
        rafal@milecki.pl, sven@svenpeter.dev, jsd@semihalf.com,
        jie.deng@intel.com, lukas.bulwahn@gmail.com, arnd@arndb.de,
        olof@lixom.net, Tali Perry <tali.perry@nuvoton.com>,
        Avi Fishman <Avi.Fishman@nuvoton.com>, tomer.maimon@nuvoton.com,
        KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Linux I2C <linux-i2c@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220517101142.28421-1-warp5tw@gmail.com>
 <20220517101142.28421-9-warp5tw@gmail.com>
 <Yoh/nEYPu++LZSvb@shikoro>
 <CAHb3i=uKwe1RdvzQA=oO6zNmEvyA_awx09+C2w8kbRq_NGi54w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ADMt7ReWlnMJvaGx"
Content-Disposition: inline
In-Reply-To: <CAHb3i=uKwe1RdvzQA=oO6zNmEvyA_awx09+C2w8kbRq_NGi54w@mail.gmail.com>
Precedence: bulk


--ADMt7ReWlnMJvaGx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Tali,

> So when we encounter a deadlock with this spinlock we decided to get rid of this
> unused feature and get both a stable fix for the issue + performance benefits.
> We work closely with all our customers so we know that this HW
> feature is useless to them.

Okay, fair enough. Thanks for the detailed explanation!

> > Why do we keep this array if we drop the support?
> >
> This array represents the HW so we left it as-is. But I agree it can
> be shortened to one\two.

Would be nice, I think.

> OK, we will move the last two to a separate patch. BTW, this change
> appears in the title as well.

Yes, but I still think it should be a seperate change.

> But now I'm not sure: if you already apply for-next patches [1:7], and
> we change patch [8:10]
> do we need to re-submit [1:7]?

Nope, they are already in linux-next. They seemed like good fixes even
without the support for the new SoC, so I applied them right away. I
hope this was okay.

> Thanks, Wolfram, for your review!
> Much appreciated

You are welcome :)

Happy hacking,

   Wolfram


--ADMt7ReWlnMJvaGx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmKKmHsACgkQFA3kzBSg
KbYIFQ//T8e9vEjUkF1e/qapo9hAzPMaLW6dsVuIFb2K9pfQQMmA8ZZsG8Lp2uwP
MdHX2nnZrtHiC9oMo8CshGv5yK2pGsZOqGBdEqyZ2/VobZYqXRzk4iaTYZMXsP0z
NedO8w4D86f09sl9iJXUdAba21fEjsJusZsOSkctsLCOXhCWPO3uPTKAQB6pB14Z
9PKs4E6UVDA9VDLo9FllxLjVOecx/A95l+0qpyjiQxtWKWeFi6gC6zI++LJ9aboi
5qoyXIQleMJvOMjm0uxWRT4LeVog9uVp7+LOTo2C24QIn0LCM//NVcytIOonx7Zb
80fATJ4mrpBBICLdd4Hy3lZV8BnpxhPeh7Iq913fkff6B3H7Y/CleHGPIvzEKgaC
YICyGbtAKHh9rdOQimoqjRnks1E8EesgzmGxSMz+ySNgP984vXURsaJSF4Roz2II
9hJC+FOEeAgPyGbL/zEVhbitI723CqOg3TKyfv5tV4WZVFyRQkFNLS8If+fDziD8
B//2/6LuFiZREGASOKSqpXC8hDVutEZWvHOjjjpivsVZ425QdC09N4BQ+SRgzlMQ
yrzDygQrqSkJILWh+K+MMx/ArQO8FF0O2LVI8b8ANLMAhxfCaDGNesK4R3DR4eLo
+FZ09CL6DcX7nu9XMAu6qammXWDwcPK9dBaRA9oTPPq7+JM7YWw=
=dZim
-----END PGP SIGNATURE-----

--ADMt7ReWlnMJvaGx--