Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Shung-Hsi Yu <shung-hsi.yu@suse.com>
To:     netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
CC:     Shung-Hsi Yu <shung-hsi.yu@suse.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Shuah Khan <shuah@kernel.org>
Subject: [PATCH bpf-next 0/4] bpf: verifier: remove redundant opcode checks
Date:   Fri, 20 May 2022 19:37:24 +0800
Message-ID: <20220520113728.12708-1-shung-hsi.yu@suse.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zga13PmJo5TnWzFFOzjAuIfGeXYcl2AsIp/Xl/558ndfHetw/nXxCI9bB5oy?=
 =?us-ascii?Q?sOgVIhhwiuXM4gXeLr5aTrnHd6ieDOLCA2JNyNoFtAcnUDS5rc/tMPfiIfM+?=
 =?us-ascii?Q?foQEFQgPJXt3bm1m8utxaF0GOqIRBWmALjMIdjWBST2Nv8RpcgF6w90tm6qc?=
 =?us-ascii?Q?Usxg56C29eLkbB4PinxZnxiMEnmFu/t7gZz/7iPtF7pZBHYbu89wzyGJqNXo?=
 =?us-ascii?Q?xuJ6BqJiD1Ji7DLcS0alAFxshmqd/c3fpIYs0sHCGk4wtGYYJ221JvTv3jj6?=
 =?us-ascii?Q?JiD0H5+GcqKZF+H0zOI7DMFIcMLCEnuNI4uA8QTC6fCirhOvA+eh4feYwi/P?=
 =?us-ascii?Q?N1CQTFR7U8tKLvaLJwRJGky84TGCCDosrYJHrdM/vJSlYxcJcPHZHwl/d/55?=
 =?us-ascii?Q?ut3WgvzBZeOS5mqVZNDIg2xRgB13N2EXARiM7TBW+Y4/ENTz7iNFthhoSBlM?=
 =?us-ascii?Q?jMR1ui0ZU/qoJBgGcGYIpjxqRhIyxIQKG1ykIIQ7sTzWuvEyysDzxrvqcZWl?=
 =?us-ascii?Q?19XMt7poUBjYNc0Y7mtLRRZeL+3JXpDYWaIH8xCtzPWVrXs14V8ojvLSUNyA?=
 =?us-ascii?Q?rKH0kQSVuwpJoncojLxqzLe2lzFM9Bq1zwB3cZ2kh/fnSCN6rTqu9s6RQWFE?=
 =?us-ascii?Q?FgiXSoUSQM/1Sf3ZH+VzkPGZeOE8Rc8cmPxOf2ZEfLOPFTPK//YaDuk5fSST?=
 =?us-ascii?Q?sk7gptbPK39Rx9T8MCrdcnCqegpig5/jL8GELziohbSLV1nMnrm+1ML8shR8?=
 =?us-ascii?Q?2kRefRjk7rhZFTi5rgtmjP/czCuGv2c7j/VVR5d/oiMSIcpAZQOK5Q7qpFxh?=
 =?us-ascii?Q?svLlJtgWd8YQx0BPABpdeBqy8F3ol89VYyCzIveTnEo0fXhjBmLDdc3tEUI/?=
 =?us-ascii?Q?VjOfH8UYJMQfndQxqzZ13mUVJ1TH/YrIvSfT4+o0z9U2jel2WLRM+mOLMPyr?=
 =?us-ascii?Q?DBqTleFeuLV5SteNNTrMluagC89zmlQJYcr22xm2cdVte3VvSX/ZbZ2QAiiO?=
 =?us-ascii?Q?OsqnuCQbu52nAiP8aotzcYq2DEbsKuY7FoXjVGiH4zf/Mp5jj7DO2BnJ2sVL?=
 =?us-ascii?Q?WEt5Rdq+M7C6+UEabeAri5+tN/n95d98Qdk24au3XGciAEwnfThDXfrP7UKI?=
 =?us-ascii?Q?PEB/Ki4SWqwzeVpL7NieAH3B5Ag7PmV6Q18P/pdDnNPmotiUVJ06ZTu+t7gX?=
 =?us-ascii?Q?JlXp34LIWv4e0d6dReZB3EbqzrsixZ8weMt3Bal7CA5y5CxZcbLrVdPEpn3U?=
 =?us-ascii?Q?uEuSkcF0ePE/84Uomsgo4odYoXYiIc2PSyanv5CdGm2YKAwp0k1bT+lylxs5?=
 =?us-ascii?Q?cPxmjOoZnIIh/NIa5RJjUXA4y+uBuWwxhfj9QO+M1W6LG3BoYVMGQ9W762qF?=
 =?us-ascii?Q?h72oyGiHnqDLdlZ5oW9omp9ubLfn0Pa2rQPn1UehQxc8lEJv4k5NxLKl5sNL?=
 =?us-ascii?Q?KUzb3Fe/i+GeO029ftTaqftRMBI33SHgTMTjBnnaxyaa0LG/fbaN7V2hy4/N?=
 =?us-ascii?Q?k3ImRMWgwoLV3eyvv9wAebmRLVvTYhcv2RLFT9ZrXX4jx1rxsSfJLMEXjOPp?=
 =?us-ascii?Q?V5A9E4piiCdm2Awzg67BVkIF9ebPKnvJ50mKPOMDNwfhAkAL+IIkO3NSByHh?=
 =?us-ascii?Q?NlpREWuFpTgGlJZ+oqUuT4LDcMKMgd3mJP9s0DrBLBoQ14gGxRCbgyZ1joMY?=
 =?us-ascii?Q?nym5e8AgxgnpYRXDBzG1dn1ZnmzUMFFBGMWqRhNCXGEz3xsyUZhCY4zc2auH?=
 =?us-ascii?Q?JSuTrP4C8Q=3D=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b1c26e2-56fb-4bf6-1803-08da3a552989
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8107.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:37:47.3409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j7PgS+rjxOZgN68nV2VEd9N+c+HQ9rfVuANCd115SURji+14j9I5RUJxGWYKPXxs4hw1yvuajY0z+2zaDgTbHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2297
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch set aims to remove opcode checks in BPF verifier that have
become redundant since commit 5e581dad4fec ("bpf: make unknown opcode
handling more robust"), either remove them entirely, or turn them into
comments in places where the redundancy may not be clear.

The exceptions here are opcode check for BPF_LD_{ABS,IND} and
BPF_JMP_{JA,CALL,EXIT}; they cover opcode validation not done in
bpf_opcode_in_insntable() so is not removed.

After apply the patch set test_verifier passes and does not need further
modification:
  Summary: 1348 PASSED, 635 SKIPPED, 0 FAILED

Also, add comments at places that I find confusing while working on the
removal, namely:

  1. resolve_pseudo_ldimm64() also validates opcode
  2. BPF_SIZE check in check_ld_imm() guards against JMP to the 2nd
     BPF_LD_IMM64 instruction
  3. reason behind why ld_imm64 test cases should be rejected by the
     verifier


Shung-Hsi Yu (4):
  bpf: verifier: update resolve_pseudo_ldimm64() comment
  bpf: verifier: explain opcode check in check_ld_imm()
  bpf: verifier: remove redundant opcode checks
  selftests/bpf: add reason of rejection in ld_imm64

 kernel/bpf/verifier.c                         | 33 ++++++++-----------
 .../testing/selftests/bpf/verifier/ld_imm64.c | 20 ++++++-----
 2 files changed, 25 insertions(+), 28 deletions(-)


base-commit: 68084a13642001b73aade05819584f18945f3297
--=20
2.36.1