Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3295179lfo; Mon, 23 May 2022 00:58:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNMis06jByjJS6WNc0KmcrOifNBtE+COYB+7IV+a+jOlVHbcsHwQadBpnE8xBHg5XIwnug X-Received: by 2002:a17:90a:5792:b0:1e0:63f3:b3ba with SMTP id g18-20020a17090a579200b001e063f3b3bamr312214pji.102.1653292691315; Mon, 23 May 2022 00:58:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653292691; cv=none; d=google.com; s=arc-20160816; b=TyfNGNCkktxniNkhOXY4DNIt0hM7SIl3rKhCoKqK2B77n5dFe2Oq0cYGRKHQ5LPrII dFWAFo3+KxDGDTENSyC7pmQmO+GdQwhmNf98NV8RputHolcmvgSxpL5C/Vw24L+MPApv S3DCdCWwKCEuGC+wf7ylh2W2nU5Uaq0Dykxt9Zr/dXNW8SCuJHcas40s8CBv9NAQo6RE 6yiCl58vJIEk87Lv8R7Ba40dJiw/pjdyMs2u4a88+Jf7bSkULZLXq28i6u4Lv9JvUFZt ECQzDOCF0sy2uJYDC8kI7gJicn99R/bTkEadHpk1CISztTNhU3B3lkaAgv76hBCjSaOb +oHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Oz4jyYgcdPnHqeYXhsxnndTsxU1YZpmX/v9xz8spcmE=; b=M49vI+pw1m+47sJw51336/2Ls8mAik7ORApb1tgNAO4A7l/FOsNsRn4eUUZAnOucdn mohNIcjoktJ67cuNKnXJw4J0nnvWcVoabS+zgRtfP3s3thwp+N2TfBwl2ZTDwn9aHEl/ kfCgmv2sTHFGGwl7vhLDJmmvgKcg3RHPM6e4YzsTUy81DI9LhOKNDqb4vQm6AsMqk3Lu +dHRIxdoZBalXTOunEly2Mp0lf/Qtpm6FXaCkLMSbpUbjnKD1UCUPRKJukhwHRjK0OmO YCegeULtO1zD0TM+jFPQNygEII4brO59DCx9nPK2JN8kZKRAYsQ0h6WzVUOXXRxGO0LT 2v7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=C9agVZPW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o5-20020a656a45000000b003c5fe31b771si10682432pgu.733.2022.05.23.00.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 00:58:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=C9agVZPW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2041724AC53; Sun, 22 May 2022 23:59:41 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343850AbiETAIW (ORCPT + 99 others); Thu, 19 May 2022 20:08:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiETAIV (ORCPT ); Thu, 19 May 2022 20:08:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D6DB1A3A6 for ; Thu, 19 May 2022 17:08:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11C4161A22 for ; Fri, 20 May 2022 00:08:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16BADC385AA; Fri, 20 May 2022 00:08:18 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="C9agVZPW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1653005297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oz4jyYgcdPnHqeYXhsxnndTsxU1YZpmX/v9xz8spcmE=; b=C9agVZPWmSYDBJk/Aiw7BnWiKGhMuCHa/ZZahQF4StRzcxU+6c8V7UF4HvRqMuvr8XhWtg Upb4nMG+IKYu+uwG9/unl2prZSVZjseTnxW525+5wb84wrx1xJCiFEGwQ/GK8dBHA+sdSU NLCqXUft4DkpQ8PXn5d7y8ZCXKvgiHk= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 072d2e63 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 20 May 2022 00:08:17 +0000 (UTC) Date: Fri, 20 May 2022 02:08:15 +0200 From: "Jason A. Donenfeld" To: Jens Axboe Cc: LKML Subject: Re: [PATCH] random: convert to using fops->write_iter() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jens, On Thu, May 19, 2022 at 05:43:15PM -0600, Jens Axboe wrote: > -static int write_pool(const char __user *ubuf, size_t len) > +static size_t write_pool(struct iov_iter *iter) > { > size_t block_len; > int ret = 0; Changing the return value to size_t isn't quite right, as this can return -EFAULT. So at the very minimum, it should return a ssize_t. Jason