Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3295484lfo; Mon, 23 May 2022 00:58:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaGOX0OA79OeR7+6u2+N3hAg8z4MQIdWlxvlCQ//iio7HqtVuPMB3uXGDuFBNWhDwMzjaa X-Received: by 2002:a17:902:d547:b0:162:306f:ae15 with SMTP id z7-20020a170902d54700b00162306fae15mr1231869plf.154.1653292719698; Mon, 23 May 2022 00:58:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653292719; cv=none; d=google.com; s=arc-20160816; b=y+/1cYLliZy+UUpQUFZCkjYe8/DtlP09OQg5bD5BzKpmC1A8jaJ5uiJnnY04Ob6eYR 7LXQ9tR3t7kUCirLo/Oabcpea5MXXEnvxqRxbCcnqPqHBFAgULvlrPvwGLM2JUXchexK lsOX7LzROpOe8hfewi/fifbx4MbOdMC/j9sXooMIXNLLDLPTyCdQqYQXBPsd1HCYjICA BwfH7NQSdIOZJq9S3EZ/WOV9xpDv+zBmI5SFm4RUMbMMBGrZfK3TnIcM6pMWIjMFSoPD VFHj5KXVNRZF/tosla78gRxNmWyaOXAZKICMetWWfBK4c165zXViKJYwgrhthF1xVIx3 PPrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=2izbHAVLxjfIQ4nE7KtVx0G/LeLm4sP4jvs3tHEwwQg=; b=jWUmvcl/pzWNmxhL9gWXkNHoj2ZVIdlfS6kiqfpNeb7tifIOS41j58AmKEMsMpQiyo SeILbfWMn8Ttpt4lVQf3CY2Z7ia0TT/9lu82IO6gxdUGI2XEQwJaESJH4x5C2KdrHoY3 JEYicyGJ3qbLNUxUcpxgYX1YxjRYvofyOgqey8S0ok9/9g5cGXLKAO3duzkWzJlXc8dT 2uePICdEBhXU3ghoIW3Jmg50uJ0WvKXf1grgCpULQqR1KLIBbZNv7vzEe7tZ/thrgRVx bBu7xPbMgfDKnHG9Bb1cPyITmW/rtw9ZvGs7bF29Oag7gMGwlUmjAfWiG/TyL4xWgdWZ CR4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=PucUE0jy; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i18-20020a170902c95200b00158c30f7edasi10705009pla.137.2022.05.23.00.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 00:58:39 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=PucUE0jy; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7615A5A582; Sun, 22 May 2022 23:58:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244400AbiESTOW (ORCPT + 99 others); Thu, 19 May 2022 15:14:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244356AbiESTNc (ORCPT ); Thu, 19 May 2022 15:13:32 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C36BEAFAE0; Thu, 19 May 2022 12:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:MIME-Version:References:In-Reply-To: Message-Id:Date:Cc:To:From:content-disposition; bh=2izbHAVLxjfIQ4nE7KtVx0G/LeLm4sP4jvs3tHEwwQg=; b=PucUE0jySTymemwY6c2oM8PZx1 10kjD92u46Ja4+evLsSLs1AqLuFsS13QtmhPjUF0u0i6ykVCtqpv4wILC6p9yngE9PbfJFcj9KNAd BhekV83goq0zE9u+cZsM2DTgS1X9fScOJRWw9iHRGkkV38SDuyG/XS8zNe8awUUpH7Vwl9QuAH4Mk Gam4tIumx0JXDk//8+z8xy4b8EMVPUX3h4pUwSJJTvw0pkneONHE6CNXq4TPRz2K43PmNMuwRhQgo HO7X2JzjkQ3KTfLxBthZ1E+9+2Y68oUpfAiePGlg6tQzZGd7F4WlcDE0+8hrbk3kVhTdrVaTfWiDY a/4iGuZw==; Received: from cgy1-donard.priv.deltatee.com ([172.16.1.31]) by ale.deltatee.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nrlaK-002TqS-0O; Thu, 19 May 2022 13:13:22 -0600 Received: from gunthorp by cgy1-donard.priv.deltatee.com with local (Exim 4.94.2) (envelope-from ) id 1nrlaE-0004TU-8x; Thu, 19 May 2022 13:13:14 -0600 From: Logan Gunthorpe To: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Song Liu Cc: Christoph Hellwig , Guoqing Jiang , Xiao Ni , Stephen Bates , Martin Oliveira , David Sloan , Logan Gunthorpe Date: Thu, 19 May 2022 13:13:03 -0600 Message-Id: <20220519191311.17119-8-logang@deltatee.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220519191311.17119-1-logang@deltatee.com> References: <20220519191311.17119-1-logang@deltatee.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 172.16.1.31 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, song@kernel.org, hch@infradead.org, guoqing.jiang@linux.dev, xni@redhat.com, sbates@raithlin.com, Martin.Oliveira@eideticom.com, David.Sloan@eideticom.com, logang@deltatee.com X-SA-Exim-Mail-From: gunthorp@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 Subject: [PATCH v1 07/15] md/raid5-ppl: Drop unused argument from ppl_handle_flush_request() X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ppl_handle_flush_request() takes an struct r5log argument but doesn't use it. It has no buisiness taking this argument as it is only used by raid5-cache and has no way to derference it anyway. Remove the argument. No functional changes intended. Signed-off-by: Logan Gunthorpe --- drivers/md/raid5-log.h | 4 ++-- drivers/md/raid5-ppl.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/raid5-log.h b/drivers/md/raid5-log.h index ccfbf8814753..f26e6f4c7f9a 100644 --- a/drivers/md/raid5-log.h +++ b/drivers/md/raid5-log.h @@ -41,7 +41,7 @@ void ppl_write_stripe_run(struct r5conf *conf); void ppl_stripe_write_finished(struct stripe_head *sh); int ppl_modify_log(struct r5conf *conf, struct md_rdev *rdev, bool add); void ppl_quiesce(struct r5conf *conf, int quiesce); -int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio); +int ppl_handle_flush_request(struct bio *bio); extern struct md_sysfs_entry ppl_write_hint; static inline bool raid5_has_log(struct r5conf *conf) @@ -108,7 +108,7 @@ static inline int log_handle_flush_request(struct r5conf *conf, struct bio *bio) if (conf->log) ret = r5l_handle_flush_request(conf, bio); else if (raid5_has_ppl(conf)) - ret = ppl_handle_flush_request(conf->log, bio); + ret = ppl_handle_flush_request(bio); return ret; } diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c index 973e2e06f19c..4f5bdb4cad2b 100644 --- a/drivers/md/raid5-ppl.c +++ b/drivers/md/raid5-ppl.c @@ -679,7 +679,7 @@ void ppl_quiesce(struct r5conf *conf, int quiesce) } } -int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio) +int ppl_handle_flush_request(struct bio *bio) { if (bio->bi_iter.bi_size == 0) { bio_endio(bio); -- 2.30.2