Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c8835a1c-2266-0131-7fd6-e6449750353b@openvz.org>
Date:   Sat, 21 May 2022 10:28:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 3/4] memcg: enable accounting for struct cgroup
Content-Language: en-US
To:     Roman Gushchin <roman.gushchin@linux.dev>
Cc:     =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>,
        Shakeel Butt <shakeelb@google.com>, kernel@openvz.org,
        linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>,
        Michal Hocko <mhocko@suse.com>, cgroups@vger.kernel.org
References: <Ynv7+VG+T2y9rpdk@carbon>
 <a17be77f-dc3b-d69a-16e2-f7309959c525@openvz.org>
 <20220519165325.GA2434@blackbody.suse.cz>
 <740dfcb1-5c5f-6a40-0f71-65f277f976d6@openvz.org>
 <d28233ee-bccb-7bc3-c2ec-461fd7f95e6a@openvz.org> <Yog4jCygrYPtPXg5@carbon>
From:   Vasily Averin <vvs@openvz.org>
In-Reply-To: <Yog4jCygrYPtPXg5@carbon>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/21/22 03:55, Roman Gushchin wrote:
> On Fri, May 20, 2022 at 11:16:32PM +0300, Vasily Averin wrote:

>> common part:
>> 16  ~   352     5632    5632    KERNFS (*)
>> 1   +   4096    4096    9728    (cgroup_mkdir+0xe4)
>> 1       584     584     10312   (radix_tree_node_alloc.constprop.0+0x89)
>> 1       192     192     10504   (__d_alloc+0x29)
>> 2       72      144     10648   (avc_alloc_node+0x27)
>> 2       64      128     10776   (percpu_ref_init+0x6a)
>> 1       64      64      10840   (memcg_list_lru_alloc+0x21a)
>>
>> 1   +   192     192     192     call_site=psi_cgroup_alloc+0x1e
>> 1   +   96      96      288     call_site=cgroup_rstat_init+0x5f
>> 2       12      24      312     call_site=percpu_ref_init+0x23
>> 1       6       6       318     call_site=__percpu_counter_init+0x22
> 
> I'm curios, how do you generate these data?

trace_cmd + awk + /dev/hand

> Just an idea: it could be a nice tool, placed somewhere in tools/cgroup/...

I'm agree, nice idea. I'll try to implement it.