Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3304257lfo; Mon, 23 May 2022 01:11:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIq0BP104fSVQd6x/bFyB4GBGOkk5SzVCN63gpS3G2wwvM+pI9C0nHSbFYXFBMSOj1zv15 X-Received: by 2002:a17:902:d58e:b0:161:ea63:6649 with SMTP id k14-20020a170902d58e00b00161ea636649mr16951657plh.168.1653293471985; Mon, 23 May 2022 01:11:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653293471; cv=none; d=google.com; s=arc-20160816; b=aXr5bSydplL8zRJhSIs3C4eluNDEmDVlgiF4yk2UCItPqb5lH++U1ivQBsr98bI2i7 MWzzYTS4W6gHcmyWFlqWl6NY31w2RQaBr5fblsywO6ZqeArzFNivx5hIp2cuiP8ejiHn WDPpW+JCl/+0f/geD6HZ6cd5niZCEbYBd4+osVlprNuNUMAwQO3t6c2CI2eXUSVEXEbz yKHAJnjxTvOsRJw5r3vBxYEPVDxt8ksgwGrZXTR4c5xSfMlr9tl7g38uYngz8+Pzj5Dn OXQRIQ6ArKwIMTsglvjY9/+G4xoARCcBxzkfCOQ5lx9/r4XcJ1OihLzUn7ePHWluEK5R VRjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=430W0NyRi8yr3SBYLcmF45GkQILubarLJhbXCz2oytc=; b=vwxRGggNfjt1OwtkHwG6N1ajHI/Pd/yOo0rM8EWvjMpBS+SQxpLlpUg7KS5R4ogUsT kFCvFk0DFiwMT6gXNCLNea3rJWcQG/5SoU34crmAoTySwUfOi6gKgCDNtkvVRyW9IbPt gRA9UrYw44g44oLuh5LfZR5sk6KkkJZu2anHetXMw4avFF/cx0/KlGoBVZ68D+xjoqzj rZWF/c6KTAOFLiO0zudP52HVOBVgPSSXbms4f9SWFiVSFXQC+RTk9zWZV81vdEe9ysN6 ueNcd+tgzXMEXOfM6GUfBARdQj9VGCTcqpVxFBbY3HRgr7dJs8mdgYuAnWr8AOLfTFtI lkNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hxUufeXe; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id t6-20020a056a0021c600b0050a6c1711d7si12917616pfj.336.2022.05.23.01.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 01:11:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hxUufeXe; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9DB3817FC26; Mon, 23 May 2022 00:06:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243520AbiEUOnj (ORCPT + 99 others); Sat, 21 May 2022 10:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231202AbiEUOnh (ORCPT ); Sat, 21 May 2022 10:43:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9DBF69B50 for ; Sat, 21 May 2022 07:43:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4273360C20 for ; Sat, 21 May 2022 14:43:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C66C385A5; Sat, 21 May 2022 14:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653144214; bh=kp04KzMieJ18XnexXdu5LUhR570BkXGpoAN8ftuQXLE=; h=From:To:Cc:Subject:Date:From; b=hxUufeXed/8BibFRMvPVuPNVWZhCW0hg/ec2BAnCRLe8rg/v+CydDZ3sNuJwTNMe8 TrW1+88mkRmWmjFCnkzddmXjx5XJxp6xI1rYIfu1VkzJ6KAP5zYjK6vbH/bS1MHgKL uQ++qTMc8bIQ9O1mssvGQPMpLP9fJ0opWXJ9eWxutBE2wYs3SPA5CUKoIKTGW1B3b9 aryukQDd1malgAT7jOC5fFvcz+lktKplPzTSGLgXgDwYT6h3m5RS34vmvl5+fsHloV msJojy5klTTRAz6C7BPR9NifW5tfkKh1Qzj/niVVWlHNGmGqDSGa/N8pc2xNM75ixo vdRPd67ynivRw== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Alexandre Ghiti , Anup Patel , Atish Patra Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: [PATCH v4 0/2] use static key to optimize pgtable_l4_enabled Date: Sat, 21 May 2022 22:34:54 +0800 Message-Id: <20220521143456.2759-1-jszhang@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pgtable_l4|[l5]_enabled check sits at hot code path, performance is impacted a lot. Since pgtable_l4|[l5]_enabled isn't changed after boot, so static key can be used to solve the performance issue[1]. An unified way static key was introduced in [2], but it only targets riscv isa extension. We dunno whether SV48 and SV57 will be considered as isa extension, so the unified solution isn't used for pgtable_l4[l5]_enabled now. patch1 fixes a NULL pointer deference if static key is used a bit earlier. patch2 uses the static key to optimize pgtable_l4|[l5]_enabled. [1] http://lists.infradead.org/pipermail/linux-riscv/2021-December/011164.html [2] https://lore.kernel.org/linux-riscv/20220517184453.3558-1-jszhang@kernel.org/T/#t Since v3: - fix W=1 call to undeclared function 'static_branch_likely' error Since v2: - move the W=1 warning fix to a separate patch - move the unified way to use static key to a new patch series. Since v1: - Add a W=1 warning fix - Fix W=1 error - Based on v5.18-rcN, since SV57 support is added, so convert pgtable_l5_enabled as well. Jisheng Zhang (2): riscv: move sbi_init() earlier before jump_label_init() riscv: turn pgtable_l4|[l5]_enabled to static key for RV64 arch/riscv/include/asm/pgalloc.h | 16 ++++---- arch/riscv/include/asm/pgtable-32.h | 3 ++ arch/riscv/include/asm/pgtable-64.h | 60 ++++++++++++++++++--------- arch/riscv/include/asm/pgtable.h | 5 +-- arch/riscv/kernel/cpu.c | 4 +- arch/riscv/kernel/setup.c | 2 +- arch/riscv/mm/init.c | 64 ++++++++++++++++++----------- arch/riscv/mm/kasan_init.c | 16 ++++---- 8 files changed, 104 insertions(+), 66 deletions(-) -- 2.34.1