Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Steve Wahl <steve.wahl@hpe.com>,
        Baolu Lu <baolu.lu@linux.intel.com>
CC:     Dimitri Sivanich <sivanich@hpe.com>,
        "Rodel, Jorg" <jroedel@suse.de>,
        "Anderson, Russ" <russ.anderson@hpe.com>,
        Mike Travis <mike.travis@hpe.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        Will Deacon <will@kernel.org>
Subject: RE: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Thread-Topic: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config
 setting
Thread-Index: AQHYZhLniAt2grbgkE6/+ZNTpYBKuq0b32AAgAAxggCACQY6gIAG/JPg
Date:   Mon, 23 May 2022 06:43:28 +0000
Message-ID: <BN9PR11MB5276747991B624B62B8CD1248CD49@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220505194658.246121-1-steve.wahl@hpe.com>
 <20220512151309.330068-1-steve.wahl@hpe.com>
 <Yn2UYst0ETp42uzq@swahl-home.5wahls.com>
 <2c65b8cf-3813-3ddf-3f5b-c374cc842678@linux.intel.com>
 <YoVP3w5cJWriLBlu@swahl-home.5wahls.com>
In-Reply-To: <YoVP3w5cJWriLBlu@swahl-home.5wahls.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MZ61yCPap4232q939l+pGMTz/l3/cnBSGFRGo3RPdrixTquRB4KDbRgln/73?=
 =?us-ascii?Q?kjwtRrkgFNOBlOmvcMTwmQHYyevDJA7K6J2ELRM8MDH2+xA0FGGUZt556qqd?=
 =?us-ascii?Q?VCFam1R9WCToG9b1i7wjwnv1G8YqA7YC39nU7J57N+YGMHn+RiEiMmig6jAv?=
 =?us-ascii?Q?LATWPwBRxCrx78/afHSzyoS4C3z+ZGuiniNI3VSGDRwH4N9JEY5DXv1nosUW?=
 =?us-ascii?Q?KZ+P6KBfigPV9Bk4zzj7whFsx1LL5wPQM2Fyhornr6M51o0deUxqblp0tzzB?=
 =?us-ascii?Q?fzo3urrrqrRdaBnurywjMB9+fPVyWu8OgQqr2/hsuhrEknC33Y9DZ0ZJR4nH?=
 =?us-ascii?Q?lJdnE9hmD9WuQGjK+CHVwfHZqIaX8+cttadrs7jCZgBQJmAdZ8cVM49vCP4E?=
 =?us-ascii?Q?LBxnFPqYtFxbOXU5r0FEdY0XgmbYHM6tS8latQzsG6HXz4oVXCz0PupQEGf3?=
 =?us-ascii?Q?zUp1SoTjGLIG88z/uafBdA3DQsSkrDnuFMz9RG0q19e4Ux0vmQS6a8GLvtaa?=
 =?us-ascii?Q?wM7wJqfoI3LH61kyiXLo9WOcDynHDkYBJHnQ8rJouj3S306fheYYuUN1am+0?=
 =?us-ascii?Q?AH08TPM1F+cNwO/ausHhQsBPButG2JX4EH1X4M24+9/FDRVdUQBUJS72u7fO?=
 =?us-ascii?Q?me3g4e9S7OzxUvt67tFsEUUflHb6N/mY5RZTditsebsCeqB8WxIq30QYGusc?=
 =?us-ascii?Q?LOeLnjmFxJOsGfTt2a9G9lfvvo0UwlA5HE+ti8zMPhRELEbP/qYrHcz1zpsb?=
 =?us-ascii?Q?vT7tUGC5hlIMY+MKQP03gDNMC5ZvJPt53O8b2HPS+Lu+CoYCXyD8lP6vrHWp?=
 =?us-ascii?Q?JacB2o4rAIDsUrHJ0azVCuzN8li/f839LN2fIQBkJOZec11nzMAg20igjW/m?=
 =?us-ascii?Q?H+YJhZMk96DreWGkdQnkOoWaLiFhD3eazrLYKg2AH/yPV0b/xo8F3OaxMb8z?=
 =?us-ascii?Q?zlU4yQwXRx/XFe8BP+WO0xYj20Yd8d8NaRRVHHj2U8UYZK982A1bdOzQLqk7?=
 =?us-ascii?Q?nWdXdQanwKW42jES+iWw6lHWrO46dToGJB4szJnFXUOcu5zUeWCqpXDewi+n?=
 =?us-ascii?Q?tf4rrQyveNtw5Dys2WDDlU5DgvOr2HR9MO6TIG7pLmhuidda/uO4S/s3yhjD?=
 =?us-ascii?Q?1XQUKMKCJXmHTKddM8/cH1Yb5svvS9P0oJ/aXbMlMSyYKsIwTSspoJpjCLU3?=
 =?us-ascii?Q?AmEjca/Uqz8a0Xh7wwjHQogImUPb4AiiG34Kz1Am6aWEUbyoqg2/THlT9hcO?=
 =?us-ascii?Q?i+NYqcaQOC+B/EMs9BTJGbIm1vZ6orRkhPlBstmFV8Q98Z/qRVhk3QGKnVK5?=
 =?us-ascii?Q?miu1k2ETPLkOBGwi8xOl/GNuK04BIDU9QHAN559ged2o6TSqR0WhAiWcbcjr?=
 =?us-ascii?Q?prJ6gtWPZ2LlNgC2kZsvzrYRez/msBmcd3hi8kx2ByPSdsqmUs224fNnA1mH?=
 =?us-ascii?Q?P0NJh0gFo7QCBrG2D20qVZAx3dS8ivKRV9wJZV9D6FZh2T3QS8bYAopUUEc4?=
 =?us-ascii?Q?bmjNLQsjqk89/yHgPlz+Ou+9A0VFTcNvaZUk06J3dGtvs4aVfMn4KSjCUtmc?=
 =?us-ascii?Q?rGpLxpNLrCRPFBf4y+vy0qY0qoAABFDOPen4amB7e3YFX6VJq20Y99+fhZOm?=
 =?us-ascii?Q?hCl0unN5zy6egn/AWRgCVb5QLnhql6h68df7p9wKG8ErUd2DDdd62l3RXRWT?=
 =?us-ascii?Q?a78CPklOdwf5JB1GJFq5ydDTbEuP7jhiGn4IyRLnQpuxGcxN/VjD8siEOuS8?=
 =?us-ascii?Q?4TD+NYATJw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2957abd2-4cc0-4892-7a37-08da3c878b5c
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 06:43:28.2379
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9jvirq312kblhA0d4mCI5tlc6Ymzy/ziJKKSslZOUhrWmvn61MU0rEzK9levtItPDpTVrC3ObzH2dh31h6w9Sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4222
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Steve Wahl
> Sent: Thursday, May 19, 2022 3:58 AM
>=20
> On Fri, May 13, 2022 at 10:09:46AM +0800, Baolu Lu wrote:
> > On 2022/5/13 07:12, Steve Wahl wrote:
> > > On Thu, May 12, 2022 at 10:13:09AM -0500, Steve Wahl wrote:
> > > > To support up to 64 sockets with 10 DMAR units each (640), make the
> > > > value of DMAR_UNITS_SUPPORTED adjustable by a config variable,
> > > > CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when
> MAXSMP is
> > > > set.
> > > >
> > > > If the available hardware exceeds DMAR_UNITS_SUPPORTED
> (previously set
> > > > to MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed t=
o
> > > > allocate seq_id", "DMAR: Parse DMAR table failure.", and "x2apic: I=
RQ
> > > > remapping doesn't support X2APIC mode x2apic disabled"; and the
> system
> > > > fails to boot properly.
> > > >
> > > > Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
> > >
> > > I've received a report from the kernel test robot <lkp@intel.com>,
> > > that this patch causes an error (shown below) when
> > > CONFIG_IOMMU_SUPPORT is not set.
> > >
> > > In my opinion, this is because include/linux/dmar.h and
> > > include/linux/intel-iommu are being #included when they are not reall=
y
> > > being used.
> > >
> > > I've tried placing the contents of intel-iommu.h within an #ifdef
> > > CONFIG_INTEL_IOMMU, and that fixes the problem.
> > >
> > > Two questions:
> > >
> > > A) Is this the desired approach to to the fix?
> >
> > Most part of include/linux/intel-iommu.h is private to Intel IOMMU
> > driver. They should be put in a header like drivers/iommu/intel
> > /iommu.h. Eventually, we should remove include/linux/intel-iommu.h
> > and device drivers interact with iommu subsystem through the IOMMU
> > kAPIs.
> >
> > Best regards,
> > baolu
>=20
> Baolu's recent patch to move intel-iommu.h private still allows my
> [PATCH v2] to apply with no changes, and gets rid of the compile
> errors when CONFIG_IOMMU_SUPPORT is not set, so the kernel test robot
> should be happy now.
>=20
> Is there another step I should do to bring this patch back into focus?
>=20

This looks good to me.

Reviewed-by: Kevin Tian <kevin.tian@intel.com>