Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <bbb5d2b0-7fbc-0b7d-d58e-355ef1871a1e@nokia.com>
Date:   Mon, 23 May 2022 09:15:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] i2c: core: Workaround false-positive LOCKDEP in
 delete_device
Content-Language: en-US
To:     Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220517075518.43613-1-alexander.sverdlin@nokia.com>
 <Yoi17igIZH7y2Hy0@shikoro>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
In-Reply-To: <Yoi17igIZH7y2Hy0@shikoro>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGp6ZU93N0laRkJrTkZVSUwvcmwxa015d0RDL3lHcXY1WnQ1ZkJiSXZwY0wv?=
 =?utf-8?B?aEprSDFHQ0pweXJhMnFsc2N4T3htNHhHTDl4ZXRHd1VQa1F2MHpiUkxCbjNv?=
 =?utf-8?B?Z3F5ZGQ4OXN1S1RNZm1Qc3R5NkZ3eW9RbG5NMGE1N3IwZ04wYlloQjVXdzJu?=
 =?utf-8?B?ZlhPUFRMK0g5TjJTRHlRVWg1Tzdhd21RaHhkYmFrLzE0WGVicXhtbGg1b3ZT?=
 =?utf-8?B?V2Fkb0REMXZjZEhTRkJoK2dJT25JZHFTUVRqaEd1UjMrc3VSdmlscncxN0Yv?=
 =?utf-8?B?Q2thUW44RmYwL2QrRnphaHNINXU3UXQvQnRCKzdkbVhhU0lSK0tNUXl6aCtn?=
 =?utf-8?B?clVEMjYveFFPQVUyY1ZLUU9RQlBFQXpyRk92RmxJQkd1aEdubTJYQTNBMGN6?=
 =?utf-8?B?WUtyNDQxcFBkNVNOb05TUzk3eDFOelBQaXUxSlJ4NnloSGh3RkFka21vYUVh?=
 =?utf-8?B?V0pHNWVRdjV2aTI4TGZ6bWNjZmFUUU05aUpwUGlKQU5rczlJS0xVcDZSWW1t?=
 =?utf-8?B?dVNNVml6a2NWcURSRXJZcFM4MnR6Y2tNU3ovNGtDREloaDJQc0s1OWJRN25m?=
 =?utf-8?B?YklqRFRtd0xJbHNtMXQyOGRWalRzZnVvM2szd2lwU0dzL25nZFdFQzEvWEtk?=
 =?utf-8?B?dTdMZy92RUM1NnFOb1M3Nmx2Z0pIMUNuLy9HdkxwdWxhUzRjUm01WENCQnUz?=
 =?utf-8?B?OVo1MXhOajM5eXo5STRteWk3OFh5T2pHZ1NkbWN5N29maUY2cXIxb0JhMW5y?=
 =?utf-8?B?WmlMSUMwN2F4M1krS0ZVMVVsblloUXE3MU1jUFJTSnlvbnRMdFBQY01yUHZY?=
 =?utf-8?B?TnJuVHhHR1dQZEtvVndnQjBUUkl1THBVeDlvMlFFVDdCemlKWHRXTnpMNE1L?=
 =?utf-8?B?a3ZFbUlIZHUxdC9iUWRiWHAxdGsydVVsd2RCTldBMFF2N0p1RS9Sa0MrS1VF?=
 =?utf-8?B?YkVyZnVYRk5waDR2VFh3VERCMy9tSXVtWEdFTUVQdGYrZEJwaGxXZ0lTa2Vo?=
 =?utf-8?B?SG5vV3dhdUtwVnkwNmRlZ0Fkd0FaL2Fzc3lSaGR1R1BZcUlzNXgxYVpGbWw5?=
 =?utf-8?B?WXlIcDU2enpUWVFCU2xpc2VDcnNCQnJuQXRZQU1VVWc4di9uWjBmWm5yaUFG?=
 =?utf-8?B?emJOaHRSaEFySUJMdjZxVGN6emtKNUgxYllqbDlBckZ4Y3ppeDhkd3ZKZERH?=
 =?utf-8?B?SFZOL2d0UEhVc0Y5THNDQVUvelM2Yk5YZDJLdDFUODVkNGRsYUZBUUMzdjVW?=
 =?utf-8?B?aERIL2NzZWNRTFdlQzV2MnAvYWFKS09laEF5NWkxS0ZreFM2bE1hQW45S244?=
 =?utf-8?B?SzhUQ0gxUVRxUTFzdWtZSkFDWDQ4U0d2UjBHdVU3d0NiS1FpZ2NHUlY1dVl5?=
 =?utf-8?B?eW9xTlArOXJwMzJIREFVbWVFSjA1MzZxcUUvTjNtWE1GRWE4YkxSYTZ6cXpp?=
 =?utf-8?B?Z0lWYUNaRWs1ZmpVWVBZZUFtWndlRDR5NGd6aStnakNQR2ROR29CUXJLemdl?=
 =?utf-8?B?eklYOTJIVzZDRUJDaXk5aFowaktjaHY5bU9RSi85NHZXcjVjRjdHMTVKY1l2?=
 =?utf-8?B?TGdPUWFwSTI0ZE9sNGFubGdzRVo3dXo0RWIwU3hTT0RaaDAxN0xHckRSSjFV?=
 =?utf-8?B?UElSbk1LR3RnVVB1N2dFZmN1ZFRLdS82ekgxajJaYS9RbGxZenJOQk9na3Rs?=
 =?utf-8?B?VTdHM1NYbmxyT2pkSkkzaXZabE1Kc3VtdUtycGhYbHZKelEvOUFoK0huQW5Z?=
 =?utf-8?B?b3F4R2FCMFBVMytZc0tvc2NPbzVvcmJQWjRtNkZENnA5MlNnT05uTllwM3lh?=
 =?utf-8?B?Mm9nQXFiVkNNdlNrbFArYkd2VmRsRDgxLzQzWGpOTHBkS3JPOHgyMjM5bVNR?=
 =?utf-8?B?UWNqRmg5anFGaVpHQlVGNm1NUEVDWmt4dHVjYUFjRGgxNDIyUVN1N0M0VG8z?=
 =?utf-8?B?aVVyL1czQk94V3QvOWVqQkZSOXBsMGRSR1V0ZVFDUUlYazNCQml3QytzQkZo?=
 =?utf-8?B?S3l4NW5sdEhhc296OUYyVmFVN0dpSlA1ZFl5d1dDWms4OXlBWC96dWVBa1l0?=
 =?utf-8?B?cUxVWE16Z2UrL1hYQS9hZ0xINEdhSFN2c1VBcGtIUmpndCtEZEkvUXFJeTBY?=
 =?utf-8?B?a0RRRm5ZeElnMTltUDZKcWI3UEJVY29aUHZ1TE1NYitMRnh1dzEwdThiWmcx?=
 =?utf-8?B?enBNUTR6bXAyMmN3Q1pUY3FKTUNQYmllWGdab0xCR3JjTjBHMzNOei9pSW9W?=
 =?utf-8?B?NGlaSU5uaFo1djh0NlhSS20xUWRtSjBpOWxsMGFRZ29IeGtyMTd0bE9wbGpN?=
 =?utf-8?B?cWVwRFh3eXZ2ZnRwWGxlYjVpVmpxWWJ1Y2dhM0ZaeXRyU2t6dWtsOWVkQTVO?=
 =?utf-8?Q?myJQL0StVYalYn08=3D?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 954ba623-ccba-4c43-e0cb-08da3c8c04c7
X-MS-Exchange-CrossTenant-AuthSource: AS4PR07MB8658.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 07:15:30.1673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u/a0Iewrz1GoeyDQNzFapvYYYVlkuN5of+BVl38Mfj4oZmgilUj7RIMOdn2OBGqccAqr8cgEnj7v6f00SsWGnNmnKw2wuWwN/zqEnOecLJc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB3332
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Wolfram,

On 21/05/2022 11:50, Wolfram Sang wrote:
>> +			/*
>> +			 * We drop the mutex here, because device unregister
>> +			 * will take sysfs lock (kn->count) which, as LOCKDEP
>> +			 * would think, depends on this mutex
>> +			 */
> I have to ask: can't lockdep be fixed or the lock somehow be annotated
> to prevent the false positive?

I would be happy to test any other proposal, I personally didn't find other working
approach until now. This particular patch actually has an advantage of reducing the
locked region, which makes sense if only userspace_clients is protected by the mutex.

-- 
Best regards,
Alexander Sverdlin.