Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 23 May 2022 12:28:50 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Zheng Bin <zhengbin13@huawei.com>
Cc:     rafael@kernel.org, Pierre.Gondois@arm.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        gaochao49@huawei.com
Subject: Re: [PATCH -next] cpufreq: CPPC: Fix build error without
 CONFIG_ACPI_CPPC_CPUFREQ_FIE
Message-ID: <20220523065850.lhnpsc2u3dxzzwx7@vireshk-i7>
References: <20220521032438.2504155-1-zhengbin13@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220521032438.2504155-1-zhengbin13@huawei.com>
Precedence: bulk

On 21-05-22, 11:24, Zheng Bin wrote:
> If CONFIG_ACPI_CPPC_CPUFREQ_FIE is not set, building fails:
> 
> drivers/cpufreq/cppc_cpufreq.c: In function ‘populate_efficiency_class’:
> drivers/cpufreq/cppc_cpufreq.c:584:2: error: ‘cppc_cpufreq_driver’ undeclared (first use in this function); did you mean ‘cpufreq_driver’?
>   cppc_cpufreq_driver.register_em = cppc_cpufreq_register_em;
>   ^~~~~~~~~~~~~~~~~~~
>   cpufreq_driver
> 
> Make declare of cppc_cpufreq_driver out of CONFIG_ACPI_CPPC_CPUFREQ_FIE
> to fix this.
> 
> Fixes: 740fcdc2c20e ("cpufreq: CPPC: Register EM based on efficiency class information")
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh