Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1724938ioo; Mon, 23 May 2022 01:35:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3UHw3mpiaazypOZ6vgmEG2480QQUCSmEWqdzm+rU2kPMME0M00GHEZ9wa8FaVvs4gJeSL X-Received: by 2002:a17:90b:17c5:b0:1dc:e0a6:340b with SMTP id me5-20020a17090b17c500b001dce0a6340bmr25328705pjb.34.1653294935000; Mon, 23 May 2022 01:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653294934; cv=none; d=google.com; s=arc-20160816; b=Ro0E/glYvjHSuUhMNFa0MwUISfjip/pK7JXylCDcPEL3uck6XuHQTbeBaChQ6kppvo jrUftL1GQ1DzUYYPuVJ9CuHoQu0xmPnRKKEMRrfug8I51qFx7DraBD1GEKuH8r3kjhh0 SSeE0ZABBndZYyadSL8OwKIC6MdoSemmTYCY2IgBJPTKfG9XN/wXsyAKA67/hxKyOMFo 9XzNCd9RzWqe/9MYS7HRYQadcVJlo8uxJr6riFWpx0mGFgB8gmEDoMATavalTbVz4OXJ N2QmAXL+GMYbMEAaQPciEVzt82Su44I0BUw1Fnz3K6sZwBN0Yl1R7p2FrqyYpF8sAeTo i4Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :dkim-signature; bh=nQd9mRIHd5HSKD0thiQmrkrrJ499m3Sgzr8RpImTClw=; b=bqS00djvl4c5oUlJOrRKffNRH5G5Pny5IVFCdBDSRgI562PcNstR/eCr8a8Uma7u7p FrliEcxYvgHujZpb27ymCuU45SY8NHtZtuIn5ffobbam24w75Nme1q+r+WK2iP+TOEYV UArMrP5W61Upumo1gsTTGtoeMWFeSX7SR3z9Xu1P9U9Ib2GFCKCcOdIEh92joklOxRPi r+c4NGWkHYtooKVj0dhnetcAgmZaZqjLf3Dz5EM6+58e2ewJgOD6FWJ2jCijY/EBHhgd Pk7y7jSkY9p06sLg83fv/R+n1R2Ud1AJnyE3m/GEe0eTGTMWIEkbe8S8DpGyR+eT4522 NWAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=uexTZvcT; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id g27-20020a63201b000000b003816043f118si9587815pgg.781.2022.05.23.01.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 01:35:34 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=uexTZvcT; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 326612B9; Mon, 23 May 2022 00:54:44 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231142AbiEWHyi (ORCPT + 99 others); Mon, 23 May 2022 03:54:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231208AbiEWHye (ORCPT ); Mon, 23 May 2022 03:54:34 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 144182124C for ; Mon, 23 May 2022 00:54:31 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 00DC52223E; Mon, 23 May 2022 09:54:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1653292469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQd9mRIHd5HSKD0thiQmrkrrJ499m3Sgzr8RpImTClw=; b=uexTZvcTXG1n68dSnxbq7ygIbq0oAIhBbYviFY52m8xr/0EBvdPUB/S0U5K9EvXeEDKErD RHFHq7f/1Ike13lwAzuc6I27hJSaQN/IG12Sbtp+zusbKuj8xfub5iJloNmhkL/aX0rM62 rlXAgEPVPQijHnlA+Y5MiSfhQ5MDOiE= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 May 2022 09:54:27 +0200 From: Michael Walle To: Jiaqing Zhao Cc: linux-mtd@lists.infradead.org, Tudor Ambarus , Pratyush Yadav , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mtd: spi-nor: macronix: Add support for mx66l2g45g In-Reply-To: <20220522054802.1719443-1-jiaqing.zhao@linux.intel.com> References: <20220522054802.1719443-1-jiaqing.zhao@linux.intel.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <04c432289041752d113c15245361ade8@walle.cc> X-Sender: michael@walle.cc X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 2022-05-22 07:48, schrieb Jiaqing Zhao: > Macronix mx66l2g45g is a 3V, 2Gbit (256MB) NOR flash that supports > x1, x2, and x4 operation modes. I presume this one supports SFDP? Please provide an SFDP dump, see [1]. If it supports SFDP please try to use the SNOR_ID3() macro [2]. Also please add what was tested in your commit message. Same goes for your patch 2/2. -michael [1] https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@walle.cc/ [2] https://lore.kernel.org/linux-mtd/20220510140232.3519184-1-michael@walle.cc/