Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 23 May 2022 15:32:32 +0530
From:   "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     frederic@kernel.org, paulmck@kernel.org, rjw@rjwysocki.net,
        x86@kernel.org, linux-kernel@vger.kernel.org, jpoimboe@kernel.org
Subject: Re: [RFC][PATCH 9/9] arch/idle: Change arch_cpu_idle() IRQ behaviour
Message-ID: <YotbuODSnj+M+KaY@BLR-5CG11610CF.amd.com>
References: <20220519212750.656413111@infradead.org>
 <20220519213422.119695559@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220519213422.119695559@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BJUu8Id8Ytkf3mCheZ36oMcSQJHu00mUDt/cm9uLGyqrcVMISP2LcL1GSt3a?=
 =?us-ascii?Q?9YCr1HxMfFY3fu08C+gADnPkUwHEM0B8ZfosRAQiNfhdkdko37OV9ab3usjB?=
 =?us-ascii?Q?BCcTcEM04WTQE1iKlveQHZqJBytY0xVcQIZRFJBBP4qhNPbjSS4RWR43hMZm?=
 =?us-ascii?Q?qo7mOEy+TC/nxSA5YRJun1gV0l6mzhBYVekc7ojdow2Z+07giGnPYxIw+h7X?=
 =?us-ascii?Q?gas5vbP8w+1Eod4MAqG9dN+6/kMNSAF75xKKJ2KFnzef2cN/cmGgc7l0V1dX?=
 =?us-ascii?Q?A8UgwbKz1xW1Y0bL7KC+VaGYwpJEz4alV8gJXO0ONh6lu+WLVqx5MNEAXoZf?=
 =?us-ascii?Q?lqBE5TrolkCt7C+5Tb0VRHp92W4nR/pQexJa3/KaC5kSHtGE71gKobs4Mkv0?=
 =?us-ascii?Q?Q7KV0Uw8XpuIAt47wWDs3SkbXrN2/4g+c8Xg1t7AR4n/fbthwYMZxMPSSPdM?=
 =?us-ascii?Q?Ixi6/OVd50L2kxp+8N0VyNs2BaXz4IxAGPe3sGsI1CUbv3Km/ipoohqpyux6?=
 =?us-ascii?Q?YK+95LkPPlypzj65FzHWEvEazeHOaNEvYbA6KB8A/gJuZOvMFP/5aSXGi/TV?=
 =?us-ascii?Q?1SKf98iQ3dG9qAW/oAI/UqO/ZEkMiCSobDiyfV6VEFClvxwAs5En1a2Os7hX?=
 =?us-ascii?Q?F91ME+2QE2xEWZ2/Ap8izhjH2EFGiH45HQ5xwv3P/nNOFwCHoLm2NtIOCbo9?=
 =?us-ascii?Q?07lh1CO2RMwCf+W3MKoU4LbltibwFsICDWFoKLU1W9VJ/01JtUCD+dDSxshz?=
 =?us-ascii?Q?IznnkJZhPK3J0ggCcHoV9foaz6ACLAmNAJunHs6HOlJqwF4hQySmmbljMxrc?=
 =?us-ascii?Q?zBIwg0rsazMVO3MLyPpYD0eHGMaYAhc7fgJJWFSJ/rSEXyP6Aq8IryMwJm37?=
 =?us-ascii?Q?7y5y4SIFeZUwSTW+OT53ANBOJqA/CdXDpmwrhfLzbtkKhHfpb93z8OeszMQt?=
 =?us-ascii?Q?7coB3PLQ48r6HDUFfLGP63IhacXyiEXIFk3AT46tQfeAk1/jzd14xO3jwUmV?=
 =?us-ascii?Q?LsFBuqpXw+pp8Rx2J9yFaS5J9YnlMjxCCgkonv+B5QBR4S9qqr5zG8wbuFtC?=
 =?us-ascii?Q?7nNv1jQ82CEDngBzZNI/u6fJLWG+RmgqYSOBVKbPjalbcsjECmV97VcMwIAS?=
 =?us-ascii?Q?YeYi5o8apKJYPe/MHdVwiYvgGf20GMZ3/m9pt2N1di0gWt9sPJK53upfCyz6?=
 =?us-ascii?Q?iaD6uFkFRBTXVwTod87UiSSluL1Ain3f2kUzentAVOTUu9RqI3pDwPXhN5m4?=
 =?us-ascii?Q?6jqfB7rdsaar/WA/EkpXqFxyD5h61PM1/aShdfk9lbDrhV2DJP7ehTNUwlZ0?=
 =?us-ascii?Q?pzKQIQYn3oiArGm2v2bWLUGBnHzp+yuszCL9hmThGgI1zeYhpQTfmpNURKr1?=
 =?us-ascii?Q?nSEHbZyXI8aKSkTHejYCp5b09K7jLMNAx1wMGS6RXJBZV6rrL2ZPI90LzoAK?=
 =?us-ascii?Q?XqnSPg74YMVpZSWt/wqPUDqlgn5X5oW3ELP4f1DB3PZO1+ImVnf8M3KkUv6k?=
 =?us-ascii?Q?l+mKr+lOMbM5XWnUreE59mvrZ/6egcm+Hm9NUeBatlPIdsD9f0jpVpNnMh35?=
 =?us-ascii?Q?iLsr8l1/plHgyAB6l3XcIHUTTPLzlL3UXcWcM074m6TC4uHRn4cVRDi/4qjj?=
 =?us-ascii?Q?K+RQuN1UBQxH7vkbsPjg76UyhIEKVWOY4ThR299jLW6CvuCjXe/eKfkFob0T?=
 =?us-ascii?Q?yPiKAIhUsxf7YHdTZqJst8SAUDRsoAB43n06PmTuoBF8Q0KmKxczgKrAH62x?=
 =?us-ascii?Q?LGsSNJkVXQ=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebf34ccd-be0b-4888-5b01-08da3ca3623b
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3286.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 10:02:45.2833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WfBpy9TQ2LVBJOexx0Ib99tCIhQgt/fsiibI6KWmjbhX2ylZ9R4h3DPImDPVcGIlhF/8xzxl6NSf6zWNsMkUxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6547
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 19, 2022 at 11:27:59PM +0200, Peter Zijlstra wrote:
> Current arch_cpu_idle() is called with IRQs disabled, but will return
> with IRQs enabled.
> 
> However, the very first thing the generic code does after calling
> arch_cpu_idle() is raw_local_irq_disable(). This means that
> architectures that can idle with IRQs disabled end up doing a
> pointless 'enable-disable' dance.
> 
> Therefore, push this IRQ disabling into the idle function, meaning
> that those architectures can avoid the pointless IRQ state flipping.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---

[...]

> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -699,6 +699,7 @@ EXPORT_SYMBOL(boot_option_idle_override)
>  void __cpuidle default_idle(void)
>  {
>  	raw_safe_halt();
> +	raw_local_irq_disable();
>  }
>  #if defined(CONFIG_APM_MODULE) || defined(CONFIG_HALTPOLL_CPUIDLE_MODULE)
>  EXPORT_SYMBOL(default_idle);
> @@ -804,13 +805,7 @@ static void amd_e400_idle(void)
>  
>  	default_idle();
>  
> -	/*
> -	 * The switch back from broadcast mode needs to be called with
> -	 * interrupts disabled.
> -	 */
> -	raw_local_irq_disable();
>  	tick_broadcast_exit();
> -	raw_local_irq_enable();
>  }
>  
>  /*
> @@ -849,12 +844,11 @@ static __cpuidle void mwait_idle(void)
>  		}
>  
>  		__monitor((void *)&current_thread_info()->flags, 0, 0);
> -		if (!need_resched())
> +		if (!need_resched()) {
>  			__sti_mwait(0, 0);
> -		else
> -			raw_local_irq_enable();
> +			raw_local_irq_disable();
> +		}
>  	} else {
> -		raw_local_irq_enable();
>  	}


We don't need the outer else clause anymore.

>  	__current_clr_polling();
>  }


--
Thanks and Regards
gautham.