Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1783715ioo; Mon, 23 May 2022 03:16:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyg5Bydq7VqmqWa5udB7tujcpy1ywtHlzgmr9F5sdq/e9Bn6nr862vjvdQAMrmdYMpVlVbq X-Received: by 2002:a17:90b:2241:b0:1dc:d4d3:3047 with SMTP id hk1-20020a17090b224100b001dcd4d33047mr26222332pjb.128.1653301019426; Mon, 23 May 2022 03:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653301019; cv=none; d=google.com; s=arc-20160816; b=rsjREWdktWwChhSHvhJmbHfJonbOkaz5Uhd8iFdBFM/wG0go30tBVVu8GJXfGGj8lD sIA9vEU3iPAZ0jjP/eRJb3gvnYUbChpY64C111SxQZDMwpbuCBGLA4Nqku3e4Qzsmu6X x1vMbnhQcF0UVVRkgLCCNGQ06DO5Gmw1874IvbnkVInzYTMi71djRQRPNMhiGeZBYpMX 0iOAZDuyIVxqmw2yPkyM6hK39PahBOOXhZrsIvjUUoANt+KndFnG4luGTy0hnO7FfvL6 cvSeg8UiSAMl3uTNDMe2VUHvw6E1Im5OYK3J2AB5afdTz65OOKBcqY6fUT1WSzRkw6bh hA3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=j8uqO6uQ4ZVj6x5j3Kl+olRHxX/AM+5LdyICh38VHXE=; b=OVY3PtMPTzQhCo2BsJeGXHgh0yisuH1wZeLRzMy7yIBZ2k4+3fA3ECT1LeGH7Jg8Po eVwvdHv+SprsuG01sp13WiZ6zT1ha+H2BlyRa0XYIPfkvUmP9cYaAN5WJYCILNNXGc3Z 1RFRlvtl3i5IgDGiAv2tDQ4VGkf9gd7YjkTgOHuMjRA57er+msjLNnwvFRSU+8wawwvZ XEo+/ZlXPjczll8oe0YmN7876RvrNwCsrVsB/aoVH3bqJeqPm3qxsDHHvwCLyBjMK7C8 Bc3bTCSfnXAvwg/qwFQVWzQENmsKj1WW9H8cOiDzdteVPodlrvvlrr7zAVKFEEp/ryIV wxSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fC9+RpjM; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id w2-20020a170902d70200b00158aac8cd3asi8282906ply.351.2022.05.23.03.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 03:16:59 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fC9+RpjM; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 55866403C9; Mon, 23 May 2022 03:16:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234006AbiEWKQq (ORCPT + 99 others); Mon, 23 May 2022 06:16:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233995AbiEWKQn (ORCPT ); Mon, 23 May 2022 06:16:43 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C67B14D09 for ; Mon, 23 May 2022 03:16:42 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id u23so24741939lfc.1 for ; Mon, 23 May 2022 03:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=j8uqO6uQ4ZVj6x5j3Kl+olRHxX/AM+5LdyICh38VHXE=; b=fC9+RpjMk78CzVqFkNwOUai6bcQM0Tesa/wSc2z0nc1VHyYbtwAA/YK9QMSEOKDPgH kdXs5N30fwwWeaLGky3V1M3nn9x2Ews948w5x3UcGetJJiK8MivYnNKOx4gk/7k24//X GVYiJOhGnGqQqp07xLC1ZIU8lJ43U5kGttsu8NMt9uY7gxl0MR+zTmdNtkIsb4Z53WtN Wvykrz9XD+zOTuuMVsayJ5j/mLr+hjNXLik8B+6POPxntfLso+wNK4aqEb47lbQmtCOx Z+nGxbcapTHTjd0+MWxZ4k12vkIV56W2+Ir0XckPrFqWDstrJE52AZZbXUWaN8KEPrvK lfHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=j8uqO6uQ4ZVj6x5j3Kl+olRHxX/AM+5LdyICh38VHXE=; b=TYHERl8PVH9C+78gKX2LKlIpxiez7sTkkynhXyQjmAhA++2tdpXhSSduMzSSfc6vcK 3IZUdw/iTlcMNdMsQydDRxu95YO550BgtVe0CYPgE8YhF3QaEzKcczcxIDtoGCBwK/Jl EVBlfZ6LIxWivkI0ks0R53gqRVL8MwRRuxNI2nYJETtP5Bn4kv8JGX4tsDD/rEyQIUZg u+p+jdNgebX8hnr5Bnzrhi+KgYjcDIVO2ddMi/UpqbidCmQPFqNLIUQe/EWGnS7iZLhD sSDIMelUUwiYZ/bZWjHLpfcEOqbLSQxXyMxjQpitHP6QoON4/6tQzhnQbBpvVw3Wh3gV 80Tg== X-Gm-Message-State: AOAM532BaWweWgCF39x6VGqKwTaDqMzakGwt9O+zlDhCni5DnGsc8DBA 6qRddOERay8NePoDS9MRdXvctcKsiuuONRGK X-Received: by 2002:a05:6512:6cc:b0:478:6e03:964b with SMTP id u12-20020a05651206cc00b004786e03964bmr3550540lff.283.1653301000478; Mon, 23 May 2022 03:16:40 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id n3-20020ac242c3000000b0047255d211e8sm1898666lfl.279.2022.05.23.03.16.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 03:16:40 -0700 (PDT) Message-ID: <4cbbd4c2-6d39-da8e-d0fc-c49ba9b8ae7d@linaro.org> Date: Mon, 23 May 2022 12:16:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant Content-Language: en-US To: Tamseel Shams , jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzk+dt@kernel.org Cc: geert@linux-m68k.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, alim.akhtar@samsung.com, paul@crapouillou.net, linux-fsd@tesla.com References: <20220520145820.67667-1-m.shams@samsung.com> <20220520145820.67667-2-m.shams@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220520145820.67667-2-m.shams@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/2022 16:58, Tamseel Shams wrote: > From: Alim Akhtar > > This patch adds a new compatible string for FSD-HW's > ADC variant > > Signed-off-by: Alim Akhtar > Signed-off-by: Tamseel Shams > --- > - Changes since v1 > * Addressed Krzysztof's comment to use soc-specific compatible > > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 81c87295912c..ded0e3f85991 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - samsung,exynos-adc-v1 # Exynos5250 > - samsung,exynos-adc-v2 > + - samsung,exynos-adc-fsd-hw The soc is fsd, so compatible should rather be: tesla,fsd-adc What does the "HW" mean? > - samsung,exynos3250-adc > - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - samsung,exynos7-adc Best regards, Krzysztof