Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 23 May 2022 14:27:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Josh Don <joshdon@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Tejun Heo <tj@kernel.org>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org,
        Cruz Zhao <CruzZhao@linux.alibaba.com>,
        Josh Don <joshdon@google.com>
Subject: Re: [PATCH v2] sched/core: add forced idle accounting for cgroups
Message-ID: <202205211525.XlF6P8dM-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220520235138.3140590-1-joshdon@google.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DSu8JcXn9cl8vcI18h/KZoaYgcC88MFXkB+F0VNluOgFbLqdwD6iPoUQcHx5?=
 =?us-ascii?Q?vVKokOqF99RPRS7kDwnUGHUjFr5p6BdwHul71oR5+28Lf0o3qISNkfc8FKlC?=
 =?us-ascii?Q?ghy6kQmTQLZ87QWqVgFUsBn4JLLy+fVWhWJJvxJpCQZuZ5n+I6uAXjWxibpn?=
 =?us-ascii?Q?drnYPRd/g1IlTWOVHZ1emssbFBPvKHMMcysSHdBYOJ8Fbm3CWYs+6OSjWnCm?=
 =?us-ascii?Q?fUaJqJynvZkDsjRdV5s3ZLnWcAIIHQIdzuo1IWpoCc9YXmnGlA56MpRdLDBf?=
 =?us-ascii?Q?FjLJI10VUinKwy4v4K4FbufS+FMiXxmWmVzFz58QZTqpwpYU0txuCXKTGEeF?=
 =?us-ascii?Q?luLJWib9NYINp7fz78KSY0A49RIdIU11Px+hThluUz92ipaR1wiBV2DP7eMC?=
 =?us-ascii?Q?6T0MXbnbX5sRj8gTiS4sPGHBpY6w0A7lBZsdQtadlWXFa4U8sxbLx44jX2n+?=
 =?us-ascii?Q?im6BWH+ZRoQ/XF3rO580OvFLqy+oTSWV2nGidBs0pJW2zsoQ2VOR1kRI7aMF?=
 =?us-ascii?Q?AYU9wpEJVLPZNQ4OXtzqnVRlYsxJPF6vVPNLLYOsQ817wvyDhaoZBu/tpF80?=
 =?us-ascii?Q?F8vcGaQoJNPqCXxdXTGXFkb1GP6xS7Oo2Z2zwkHlyUy9atMlzNv3wvwO5Afk?=
 =?us-ascii?Q?rVgkltasHSqRujfM1uWyarT1S/EHyyFMtz//ZG+4O1GNi5UmNs83pgQg4CLx?=
 =?us-ascii?Q?ebblteXFrIPM/6e//73Z17RGI1sdRxz22fL90+gSUxsnFGAFqh+I39JTSE66?=
 =?us-ascii?Q?psGPHNPENztYAWRKQkugJVb5bt456YWmm5sa6h9dOTAyhlIO08C/4YewRwiN?=
 =?us-ascii?Q?EQX5b/LIUEAXLUKmsDpCtAUWzsoT5mMO2ddEzrBpWd8rDCzb6OpF3jEXiRRa?=
 =?us-ascii?Q?A404ft7QJZTzxsV0f8LMAMdLoIxyR9UG+zbbe8Q6hqyGNkrUOmCUqlQX+C/J?=
 =?us-ascii?Q?rUe8/WlXBKGbhf7bclhsu/I3twXhiAvkIfwRtoyjZ63DNQSjpCrSZ4pttYX8?=
 =?us-ascii?Q?aafCvm1PgoztDzpUY0wKdJlI1uDVHouPLTG1gmTxO63+3JSnc+7P0jy7Vo1k?=
 =?us-ascii?Q?8DenLEWEGlD/BdmIjwqaYcwGSgPQDpP1qmSxzbbfjOLNxQl/Ylj1xb5Rr2Lc?=
 =?us-ascii?Q?6J+3cknKcI62/fX1nKvSx7IlV90s23j95xUDReXD+Aog8jOGTNFCOojtTdcX?=
 =?us-ascii?Q?vfHTpiJtUHOjC9zC3MjGtQKbux87n/I81yEokFS7+J0yn9Ps+lR3yDGFCGwV?=
 =?us-ascii?Q?ZngIIx0gYOXHXZa+my1IJ0DhLyArweEJmcg9xMUN73cmtLL+XncpKY6P3Grd?=
 =?us-ascii?Q?tRZREN209nopSDO5kRGsR8xWR6d9IxwOmbqaRS3FP5/M0bG+BRrTXHARNhC6?=
 =?us-ascii?Q?22cO8h5R0leUe3EnEMQZ9716kGrWNfkHFU1g/arRtpp56lmkR9E2oAfpJX3d?=
 =?us-ascii?Q?LS5t8dS7/NgQcxxs9/QglXH+HXkHRhiJqPuZ10Cy+8bCT00Fd00gANeQNor4?=
 =?us-ascii?Q?SjcxDdIDirevtl4R6GsULQbVl39XFukKKCsnJXs2GEW3TWZ/9Ys5kUY0AfFf?=
 =?us-ascii?Q?tly1CszwBGecZlNXcHvpQArcctjK9H81ZoY2q9n5GYKT6JfqxQ2rYJVAGTEB?=
 =?us-ascii?Q?0G0UsE2Rh961OjrIcyRTUKmR7xFpcjV72WEVrMTYdNTl/XmiLvt2czOD8Wfe?=
 =?us-ascii?Q?JKL7mtcChdrY3NmhBZ5ZGruWU45MvWBEAoUz0o3FgLwbrKHUFvKfQKqEMtwX?=
 =?us-ascii?Q?MbdwFKH/qjlKfWBT6uoNJ4RC9eF8eJ8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6443bb33-3c02-47f3-b76a-08da3caf51ef
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 11:28:12.0141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lSxmjpylgOKJpTn7LGIPj7Kc/qBA7Yb6eU2TmQzgk3FpSEqwokA2mn6XlZs+TH0rP1A5L+tDaSDWiMgly0TqrdZK9WuNPQm+RoROqm6yUgY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2434
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-23_04:2022-05-23,2022-05-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205230062
X-Proofpoint-GUID: Jvmae3U4vlC1qtdq_HAdLM9LxY6s8lOt
X-Proofpoint-ORIG-GUID: Jvmae3U4vlC1qtdq_HAdLM9LxY6s8lOt
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Josh,

url:    https://github.com/intel-lab-lkp/linux/commits/Josh-Don/sched-core-add-forced-idle-accounting-for-cgroups/20220521-075311
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220521/202205211525.XlF6P8dM-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/cgroup/rstat.c:489 cgroup_base_stat_cputime_show() error: uninitialized symbol 'forceidle_time'.

vim +/forceidle_time +489 kernel/cgroup/rstat.c

d4ff749b5e0f1e kernel/cgroup/rstat.c Tejun Heo    2018-04-26  460  void cgroup_base_stat_cputime_show(struct seq_file *seq)
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  461  {
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  462  	struct cgroup *cgrp = seq_css(seq)->cgroup;
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  463  	u64 usage, utime, stime;
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  464  	struct cgroup_base_stat bstat;
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  465  	u64 __maybe_unused forceidle_time;
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  466  
936f2a70f2077f kernel/cgroup/rstat.c Boris Burkov 2020-05-27  467  	if (cgroup_parent(cgrp)) {
6162cef0f741c7 kernel/cgroup/rstat.c Tejun Heo    2018-04-26  468  		cgroup_rstat_flush_hold(cgrp);
d4ff749b5e0f1e kernel/cgroup/rstat.c Tejun Heo    2018-04-26  469  		usage = cgrp->bstat.cputime.sum_exec_runtime;
936f2a70f2077f kernel/cgroup/rstat.c Boris Burkov 2020-05-27  470  		cputime_adjust(&cgrp->bstat.cputime, &cgrp->prev_cputime,
936f2a70f2077f kernel/cgroup/rstat.c Boris Burkov 2020-05-27  471  			       &utime, &stime);
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  472  #ifdef CONFIG_SCHED_CORE
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  473  		forceidle_time = cgrp->bstat.forceidle_sum;
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  474  #endif
6162cef0f741c7 kernel/cgroup/rstat.c Tejun Heo    2018-04-26  475  		cgroup_rstat_flush_release();
936f2a70f2077f kernel/cgroup/rstat.c Boris Burkov 2020-05-27  476  	} else {
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  477  		root_cgroup_cputime(&bstat);
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  478  		usage = bstat.cputime.sum_exec_runtime;
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  479  		utime = bstat.cputime.utime;
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  480  		stime = bstat.cputime.stime;
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  481  #ifdef CONFIG_SCHED_CORE
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  482  		forceidle_time = bstat.forceidle_sum;
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  483  #endif
936f2a70f2077f kernel/cgroup/rstat.c Boris Burkov 2020-05-27  484  	}
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  485  
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  486  	do_div(usage, NSEC_PER_USEC);
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  487  	do_div(utime, NSEC_PER_USEC);
041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  488  	do_div(stime, NSEC_PER_USEC);
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20 @489  	do_div(forceidle_time, NSEC_PER_USEC);

I think this will cause MEMSan warnings at run time.

041cd640b2f3c5 kernel/cgroup/stat.c  Tejun Heo    2017-09-25  490  
d41bf8c9deaed1 kernel/cgroup/stat.c  Tejun Heo    2017-10-23  491  	seq_printf(seq, "usage_usec %llu\n"
d41bf8c9deaed1 kernel/cgroup/stat.c  Tejun Heo    2017-10-23  492  		   "user_usec %llu\n"
d41bf8c9deaed1 kernel/cgroup/stat.c  Tejun Heo    2017-10-23  493  		   "system_usec %llu\n",
d41bf8c9deaed1 kernel/cgroup/stat.c  Tejun Heo    2017-10-23  494  		   usage, utime, stime);
0575a42c9f10cd kernel/cgroup/rstat.c Josh Don     2022-05-20  495  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp