Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Eiichi Tsukata <eiichi.tsukata@nutanix.com>
To:     "rafael@kernel.org" <rafael@kernel.org>,
        "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "mtosatti@redhat.com" <mtosatti@redhat.com>
Subject: Re: [PATCH] cpuidle: haltpoll: Add trace points for
 guest_halt_poll_ns grow/shrink
Thread-Topic: [PATCH] cpuidle: haltpoll: Add trace points for
 guest_halt_poll_ns grow/shrink
Thread-Index: AQHYbm+UA1e/KWx/QUazBlfDuzNMCa0sVRcA
Date:   Mon, 23 May 2022 11:33:58 +0000
Message-ID: <C4795509-E6A9-4587-BC82-001781D0D963@nutanix.com>
References: <20220523063543.99335-1-eiichi.tsukata@nutanix.com>
In-Reply-To: <20220523063543.99335-1-eiichi.tsukata@nutanix.com>
Accept-Language: ja-JP, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gkyh0GVnZmxXec1qGBBSobJZH6CDigMowCBK1otwYozpzcnemxN8GuUWy9Ac?=
 =?us-ascii?Q?H2BS/S4pUb/7ygeJyW+rjyRA1h5p/El9J5P0l7U77XBoi66grrDLbU/nPkAM?=
 =?us-ascii?Q?1yqw+3J6Xat2wkcBZCvNPVUZbP1EhIH/7jm789DBx6MDkM9vDyKgqVtGY6NE?=
 =?us-ascii?Q?qkviD9fiiQjDWbDVoFVXv6+TTbB6w4f23eY2UP9HyzjZeAHST/TiuzHBZ2hY?=
 =?us-ascii?Q?+Z7nmiYWBFQ36IObIui2OD2hG+T+hlHMm8iVuWgUpr3KMOD0XIJFOcgMCZPP?=
 =?us-ascii?Q?+ANovV/AkRV0CXErY9W1FM93DnHBB3PkJcNwHgs418G88nNcoRYUZZs2xnLX?=
 =?us-ascii?Q?0m1Acw8X0InK5sUgAA8VvRmLzHqqIgcWDIzjA9c83WrhgAgK0x9WSLgi4S5P?=
 =?us-ascii?Q?gR+86D86efhwlDjxqMflH9PgMUsgKsNGcRv9Zy7ynRRv1StnDeyPzkuCOMED?=
 =?us-ascii?Q?+qV4DHsAc6iM7AaHjfyvt5QAGyYtUICw9imVUqd3SImuGTor4EROeH96yTsc?=
 =?us-ascii?Q?lyqjfhqDaxCS1CoItUXpHELY3jxj/ql9pt477aXNOXvSXinaFvhaM2ug33jE?=
 =?us-ascii?Q?aMLiS8Iyv7zNWL4WiGBaghUD4qYDcsSzn/TUriNLYELtBt1K5ubADAM9kHz5?=
 =?us-ascii?Q?K1DazxqpUCNcixoILUWqhvlIFZh4T1EnoCS+nxhVAkbg5oh9Wx/jSIECG+Sq?=
 =?us-ascii?Q?zN2Aihg0vFKIhVyP8FXCLbcgM6l50IId7+3KCtOSkN0JCHIPVIXS3Kx5X59S?=
 =?us-ascii?Q?MAmwskAxIFm8OgQdLe+UmqJf7N3ZHVaxRZucaGO5dp9CnpLYFgMv0/KlfpgV?=
 =?us-ascii?Q?DwwNuPpfKPPk4T9tRSpenMOeVciYqzVZMxhtIn5qm6rwVcLIJjuQ/bnnIIku?=
 =?us-ascii?Q?8TMMgjoYSXcZIV7j8NHlk4aCuAJ6fl3wB1KXPxE1rdANNlMHtNOLsezFQMMk?=
 =?us-ascii?Q?b08vUH4hc+Uf9CJWGLdCpY3/u9NKFgd9rCfmffAKz6IOf3OIofBas0C8E3Al?=
 =?us-ascii?Q?5h4v+J53sacxm7bBwa9fShm8XQpB/oo391MIt6V+XTLNIVntHCb0vjBhQUUt?=
 =?us-ascii?Q?dBE2cujJP8xxF7trrchc9yTNUS24mgP3tlkWwpA3gpufxLDMe5RY6/e3AT94?=
 =?us-ascii?Q?4ugICMjEnMLsZ+MsUT3KLFz5CI6mXlueWKN6P6ocgJQVawH07gLaLZUDDDgf?=
 =?us-ascii?Q?zfunnScRbmh3jLbF9/zwkxtwX3Jqqw7LXoPZps/CY3aPpKlFZZIvsKbafjdJ?=
 =?us-ascii?Q?+bH6XGQGac8r7p4XgYpN73CgKEAcZMAqN+wlJOtQVjY8FvdCA41Jz1vsjKNL?=
 =?us-ascii?Q?MeOur34KTsW1m6SlU4qBxs+PSeH9ZWzRQsI7LbdZYE2Rx2n8/NaX8VlWaJnB?=
 =?us-ascii?Q?Akb+enD9mDO+tzBTWDGnqaKw9UpEi6xxAcLVg5+6SZsm4rOKYfG0x6LAYBV+?=
 =?us-ascii?Q?Bxu9/HrAaoC7up+on6cgecZJbuZAs8aJKeM89C6zTPTbQ6E4lk6AJbbIXeE+?=
 =?us-ascii?Q?G7cgKizQ/PEUYrWNP5cf/IzVAkq/9GbdfjsSMOI3nV9prIIgXzPN1rFe7uaS?=
 =?us-ascii?Q?lHgOSnQx+yk8WSl2DCnAMkHOPPZWfTcNQBTLLJfzNStkGMed9W1G+FWpZ9tE?=
 =?us-ascii?Q?rND2isgKSa5wp+gedTbJEraXSr8w2VI8cOoW2Xo0hS1oiGCYTFrKWiF5LyPT?=
 =?us-ascii?Q?TVlueCDgmtG4jaIEigBFN08Mu57qExZouQoknRqMq/FKO4uJ0jIk7XSKhgqx?=
 =?us-ascii?Q?6J91lb/iED9kPeXOVYJiopYMj9+xOFw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CB12388BEE067B4183BC6DF7BA890F2B@namprd02.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR02MB8041.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2aecd54c-0d27-4002-4c36-08da3cb02094
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 11:33:58.4378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MJsjOvJpUq1YEAROxTm9PfYhGSB3E9dQqDNGMKlSszph79ZPkhx4EBhtS0CdswJJDt1/fg91tleM8hDafBoFkQyXVSV6hTKXkBq8NPkVGD8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7379
X-Proofpoint-GUID: Wv9OtyCt14SFpEmW8jguP2h5wY9R6fng
X-Proofpoint-ORIG-GUID: Wv9OtyCt14SFpEmW8jguP2h5wY9R6fng
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-23_04,2022-05-23_01,2022-02-23_01
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 23, 2022, at 15:35, Eiichi Tsukata <eiichi.tsukata@nutanix.com> wr=
ote:
>=20
> Add trace points as are implemented in KVM host halt polling.
> This helps tune guest halt polling params.
>=20
> Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
> ---
> drivers/cpuidle/governors/haltpoll.c |  7 +++++-
> include/trace/events/power.h         | 33 ++++++++++++++++++++++++++++
> 2 files changed, 39 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/cpuidle/governors/haltpoll.c b/drivers/cpuidle/gover=
nors/haltpoll.c
> index cb2a96eafc02..9a6eca41a484 100644
> --- a/drivers/cpuidle/governors/haltpoll.c
> +++ b/drivers/cpuidle/governors/haltpoll.c
> @@ -19,6 +19,7 @@
> #include <linux/sched.h>
> #include <linux/module.h>
> #include <linux/kvm_para.h>
> +#include <trace/events/power.h>
>=20
> static unsigned int guest_halt_poll_ns __read_mostly =3D 200000;
> module_param(guest_halt_poll_ns, uint, 0644);
> @@ -77,13 +78,14 @@ static int haltpoll_select(struct cpuidle_driver *drv=
,
>=20
> static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)
> {
> -	unsigned int val;
> +	unsigned int val, old;
>=20
> 	/* Grow cpu_halt_poll_us if
> 	 * cpu_halt_poll_us < block_ns < guest_halt_poll_us
> 	 */
> 	if (block_ns > dev->poll_limit_ns && block_ns <=3D guest_halt_poll_ns) {
> 		val =3D dev->poll_limit_ns * guest_halt_poll_grow;
> +		old =3D val;

This sets wrong old val. Will fix it in v2.

Eiichi