Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 23 May 2022 14:17:14 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     andrew@lunn.ch, calvin.johnson@oss.nxp.com, davem@davemloft.net,
        edumazet@google.com, hkallweit1@gmail.com,
        jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org,
        kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk,
        pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org,
        wens@csie.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [PATCH v3 1/3] regulator: Add regulator_bulk_get_all
Message-ID: <YouJWnMQJWzLU9QR@sirena.org.uk>
References: <20220523052807.4044800-1-clabbe@baylibre.com>
 <20220523052807.4044800-2-clabbe@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="IaE4B5GdbTL8QUGo"
Content-Disposition: inline
In-Reply-To: <20220523052807.4044800-2-clabbe@baylibre.com>
Precedence: bulk


--IaE4B5GdbTL8QUGo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 23, 2022 at 05:28:05AM +0000, Corentin Labbe wrote:

> +	*consumers = NULL;
> +
> +/*
> + * first pass: get numbers of xxx-supply
> + * second pass: fill consumers
> + * */
> +restart:

Please fix the identation of this comment so it looks less like an
error.  TBH I'm not sure it isn't easier to just use krealloc() and have
one loop here, or just write two separate loops given how little is
shared.

--IaE4B5GdbTL8QUGo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKLiVkACgkQJNaLcl1U
h9BwMwf+MijZTV5zm6UVWDR+lDg3thlPKizYFdm0ORirfhyPz1mOojb8dZVKFqfo
EqyWBvVdP3rvimtQslIs1E3hG0ppjzv918+He7B4lvABrpEx6IBtXWMv9qQKNTz/
/KLitIR9hZ9axRV4e600OXhw2Yg2ut8MbBesfPiCqGDirBt4bk8ghhMbYhnIgii6
vuDPmr2YhTNRcuYyiVCVO3McrmWnJDSE9h2YUr0wsdtc1FuKJjwQPMSNAs2PvUsm
K/AiRfovshtkzll2TCZukYkFObFRYCf/xbYnXG0IyfRWoXzJKspimwQF94SHMuK9
DPMxLud0JF0QLM7X/MD08Njpb/4h7A==
=r53l
-----END PGP SIGNATURE-----

--IaE4B5GdbTL8QUGo--