Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 23 May 2022 14:27:15 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        NXP Linux Team <linux-imx@nxp.com>,
        Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v1] spi: imx: mx51-ecspi: fix clk polarity and phase
 configuration for CS > 4
Message-ID: <YouLs1xoxOCdyBlU@sirena.org.uk>
References: <20220523073143.778664-1-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dE31JipDzIkqI+Sx"
Content-Disposition: inline
In-Reply-To: <20220523073143.778664-1-o.rempel@pengutronix.de>
Precedence: bulk


--dE31JipDzIkqI+Sx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 23, 2022 at 09:31:43AM +0200, Oleksij Rempel wrote:

> -	/* set chip select to use */
> -	ctrl |= MX51_ECSPI_CTRL_CS(spi->chip_select);
> +	if (spi->cs_gpiod) {
> +		chip_select = 0;

What if someone mixed GPIO and regular chip selects and 0 is one of the
in use chip selects?  Ideally we should check for an unused chip select
here, though the current change is still an improvement since we'll at
least only write in the chip select field.

--dE31JipDzIkqI+Sx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKLi7IACgkQJNaLcl1U
h9CxGQf9H/g5UyTrEeUzmcTSlNIAMnppIbjCjex9k6S57Xm+hDke4Pu3hHQmxRe7
gBeCNC2A6VJWqPTY0L1M7atQO/FAOpMMoUjCkw7w/aM1Oz42j6HL20euo7HL/lud
olVB7SeBhWwQMriA0M5QUiDkxFi5Zx5xb3vCWPdPqdHf3T1nu45Y8vPGdv0cWGbT
ogcKA5d0UYF4RCH24yAe1r2nRCWQerheg8MxgcY5rP0uFJZABL2aAvUKk/iydXEN
pUEPXVdcfv+rrf82Sz1Zz8Y+hmDe0F6OqWz40xT+Dbhdoo9KEkHtmkSnxD2EZFLR
VQmADajaeyoUXMUtQFbO3gLDs1TzBQ==
=KLbp
-----END PGP SIGNATURE-----

--dE31JipDzIkqI+Sx--