Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <106dbe1e-3e2f-09f3-7787-61500626a4a9@amd.com>
Date:   Mon, 23 May 2022 19:14:39 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v4 2/5] perf header: Parse non-cpu pmu capabilities
Content-Language: en-US
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     acme@kernel.org, irogers@google.com, peterz@infradead.org,
        rrichter@amd.com, mingo@redhat.com, mark.rutland@arm.com,
        namhyung@kernel.org, tglx@linutronix.de, bp@alien8.de,
        james.clark@arm.com, leo.yan@linaro.org, kan.liang@linux.intel.com,
        ak@linux.intel.com, eranian@google.com, like.xu.linux@gmail.com,
        x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220523033945.1612-1-ravi.bangoria@amd.com>
 <20220523033945.1612-3-ravi.bangoria@amd.com> <YotOJL0dJmKUQnlI@krava>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <YotOJL0dJmKUQnlI@krava>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDl6SXZMdi9wTnVhWElDUDJWZEFheWxQd3pCQ3l0YS9pMnpnUTI3eVQvVGxp?=
 =?utf-8?B?d1VndDdEazF3THMrT3JXRFNvR1l5b2xXUGQrWitoQlpRS0tieHdvTTRLOUNr?=
 =?utf-8?B?UVRaYWRuemZhREtFUVg3ek5sNUY3dEQxbHc2alpUVmtUUGZUY0lhcldldjdI?=
 =?utf-8?B?cE5VMVhvbFZ0cDd6Q1lQRWxMc3RZaHBrTFBqNkEzLzJLRXZvdXZRcDJWcGZk?=
 =?utf-8?B?cHgwUy9TTE5ENGM4TGlPQVoyaTRwSHovQzJMN1pGZXJZSERNYTM1Q09GRUdK?=
 =?utf-8?B?TTlxa09qd0xab1ZqUXIwMjBjb2hNZ1ZMVzFwZE53WjJFTkhGZHBGMHd0NTFr?=
 =?utf-8?B?cFJMbjF1UEVadU84aHFScGtxVzcyZHoyczVmajBnZmhsSWxUKzRNRUREUWtv?=
 =?utf-8?B?dmxoV0QyV09FZVBYaS9rbkFZTVp3eTUxWFBJUjRMM0c1QW5ERHRKOGt6dGNM?=
 =?utf-8?B?Y2ZjR1l2aHUxYVpiaWNFelJURkZRZldlL0Y2aFQ4QzZ4NitxcExNNWtlTGx3?=
 =?utf-8?B?ZEYzTDFwWEJOUUprL1NjaEZwVGFmeVBIZ3VybXhKSzNGOExzTDA3VFNhalVT?=
 =?utf-8?B?c2ZjVjVZcWtLeWJ3WEcrV0FFenhiaENIYzVzbno1em4xVmdzWjJWWk54cy9E?=
 =?utf-8?B?emxuS0wzZWRLOXpWOTh4OXR0YU8xL3RVY25kVFJSWmoxRDFPNzg4ZnM0c0Uw?=
 =?utf-8?B?eHBldDliYk5BSG55VmkyeGJVYjJNNk1ldmx6TVhSaWljeVBjOVFPTk9ocGdR?=
 =?utf-8?B?a3ZVZ3hIbHBRQmIrdjN5aisvSzFwZGRqTzZIbGt4a0hpOFF4dkJjSUZxUjM2?=
 =?utf-8?B?WVZzVlVhOGZ6eWI4ZC9WOUl4bmVuUlVBd1VUYUJKNFJncUVISUxVTlNGVnpH?=
 =?utf-8?B?NFZSeGRKdytoMS9VREhtdk5vdmFCRmNtVWxKVzJIOTFYODFVcnhVcnZWbnU3?=
 =?utf-8?B?UUlPOVdDblRzQmZrVGs2QmJlQ2J3TStYRXdtOSs2MzE3NGNpTmpkeENjdTFF?=
 =?utf-8?B?R0lqd1YxS0xsTTFhUzhtdncyYXJDb1hvem9XSy9LNW45SitrYWlzV2cxR3ZV?=
 =?utf-8?B?S28xdjV5dHdTbC83eUt1Vkl2NkpSc0dZZEtKVld1S2VSYkZ0d2FpOTVmSjc4?=
 =?utf-8?B?NWlwYWxJdmt2QXk5QWhKeUFTaE1OQlhWcTBwclhiYnJzcGxBRk1DcTRpY3NK?=
 =?utf-8?B?REdZbGFkdXBsM1NxclRJaUZLS2d3OU1XVEpKNFVGelpMWTFoVGRMS1RnMFIy?=
 =?utf-8?B?eDZHaWplaGZFclAzc0svdmhOV2VqcDg1N0FsZ3FiQzZxU1dqenNNL2NwMUZB?=
 =?utf-8?B?Q3lBdFBMa3J2SC91RlBwOVhwZXZTQ1RBWkJVUGVaeEV1ZFBpcytmb1BIN1Zy?=
 =?utf-8?B?b2ZoRG9BU1FaUFViNkZkNEpBTDU0Y1d1Vlh6VklrL3JILzN5ZUQydWNVd0xl?=
 =?utf-8?B?a0ZGUDR1NmE3U0ZrRkpScE5YZGxwTVJUSVhYMngvSXBkaXJ4Ni9rWGdDeVhP?=
 =?utf-8?B?VDhCZXg3OFRWT2ZNa1cwbGpsbWl6UDRNbVoycjZGTWdDQjB3Z0pzTUY1ODgw?=
 =?utf-8?B?aTcyQVc0U3BPaFFITXpPNjBVVjk0ZG0yMlFyR0V4SmNpeTJjMTFLbWJaR1Y3?=
 =?utf-8?B?U1JNZTMydTl4VUZ1RktkeFhJeWllcmFycTlYSFJFSUlsNFhTK3JZV3FkMngx?=
 =?utf-8?B?c2pYNU01NldqWTNoK1F5T2JKazQreGRBQnZ2Q0pQZVkrai9PczZaM2Y2SW85?=
 =?utf-8?B?eStoYVVCOHFRMFU5N1hEbERSby9QN3FVN0Fsb2N3d1NRMDJjYVc4U0VYcFlY?=
 =?utf-8?B?SzZ6azliMnBRSlc1L2d5SHAyUG9KV1pzUGlKRGtreTZtZ2p0Q3pTUElQbXZt?=
 =?utf-8?B?c1ZzVUVIdVg2ZTNqaXVqOUtSUXVEMTMwTWdsN0g0V1owaS96SFlKVVNZdnJG?=
 =?utf-8?B?OXltUlpzWG8vT1pNdVI3S2VhOUMweVAwL0tWQks1cUVGeEVnZTVnTmhGNEdO?=
 =?utf-8?B?UTdQdlROWkp1WDc2ZGIwSU5CY0JhZ002cjBYaU4wVWpoVWZZam8zNnRaaDBU?=
 =?utf-8?B?TGVCWjN1Z2R0ODBYZ0tJb3pzZm03Mm1SMDBZYktsRUFWdjZTTEtSU3FKVUtw?=
 =?utf-8?B?U011U1lkandIUWMzNkxFWjJvSk9pcjZpcGtHeEFlNTc0dGVWbGFqVW5Ydi9i?=
 =?utf-8?B?L1d3QTZLdExPY0VLUWFPVm9DQy9xUC9zbmR4VU41cTBWRlVjM3JERUszT2JG?=
 =?utf-8?B?Tk1zUVFOYkREenRKT2xXQkc2MTJzMVhPM3gybmxoYU9iTThUeS9Eek04WlZw?=
 =?utf-8?B?bXZ3TE1KVnUwTS9zUng0M3BWajExNzVQa1FBVEwybmRybUMyd04vZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3084eb4a-0918-43ce-3de8-08da3cc26b30
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 13:44:54.9897
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: npk1PO95JggU/SM3TUwc2773UW6y0zbU8tlMGl1IKcjLK7GPvDSmmmNeEaBeVWbS7yu37v3eOKzsvFzoqDPJLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4163
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23-May-22 2:34 PM, Jiri Olsa wrote:
> On Mon, May 23, 2022 at 09:09:42AM +0530, Ravi Bangoria wrote:
> 
> SNIP
> 
>> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
>> index a27132e5a5ef..b4505dbb9f4a 100644
>> --- a/tools/perf/util/header.c
>> +++ b/tools/perf/util/header.c
>> @@ -1580,6 +1580,67 @@ static int write_hybrid_cpu_pmu_caps(struct feat_fd *ff,
>>  	return 0;
>>  }
>>  
>> +/*
>> + * File format:
>> + *
>> + * struct {
>> + *	u32 nr_pmus;
>> + *	struct {
>> + *		char pmu_name[];
>> + *		u32 nr_caps;
>> + *		struct {
>> + *			char name[];
>> + *			char value[];
>> + *		} [nr_caps];
>> + *	} [nr_pmus];
>> + * };
>> + */
>> +static int write_pmu_caps(struct feat_fd *ff, struct evlist *evlist __maybe_unused)
>> +{
>> +	struct perf_pmu_caps *caps = NULL;
>> +	struct perf_pmu *pmu = NULL;
>> +	u32 nr_pmus = 0;
>> +	int ret;
>> +
>> +	while ((pmu = perf_pmu__scan(pmu))) {
>> +		if (!pmu->name || !strncmp(pmu->name, "cpu", 3) ||
> 
> should we check for the hybrid names as well?
> there's a helper perf_pmu__is_hybrid,
> aybe you can use that

Yup. Will include those.

Thanks,
Ravi