Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1967855ioo; Mon, 23 May 2022 07:16:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzStCuxcRfqddvSVDUkiQFtdqIcGlc1N2E4Y6cxv928ZznLcnBGNDJhKg+cwIKZv1snx9TW X-Received: by 2002:a17:902:b694:b0:162:6ea:30 with SMTP id c20-20020a170902b69400b0016206ea0030mr11402420pls.95.1653315389194; Mon, 23 May 2022 07:16:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653315389; cv=none; d=google.com; s=arc-20160816; b=kSihJjeuwt0agXn27o2xB+77Mob+ay2gc6sGqAT//2KMYGvNre35mDait18oGck9AP r58ZPZVMRcMh/r8D9xSk784z7jllyOq1sjFTYXfaUi8Ww415YfzwxieJIo2MXI+T+Fe/ 222ITNUKUovtc7sCB9NaEvTvM+beN1G8wKhbEv1bRzeRCsy0jU6izAVnOoYUdcoAjt8G 2S8xEkm4jOdIaPtzqu0FgbHscy5112TGCh7V8NdKu06J9G0BL1h12SP3yRj1pDncQ4EM QDHGLtLD47sq1asA9/xYI3dl7RZae9/YQAs1BNGozU5BBLY1t+1w+X7OKCrmF7AlxJYv 7DeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=H767C2i0qpntP2Hc25tbjn02oMYnv32wuUYy29Xv2ng=; b=W70LMRn9G4FQTWx2vfRnoNxfhFvZHbRxnI/sh+AD3tj+Narfj6j3lbY/AvKNrq011y CSUfTUu6CeEz1qHtZQ5CelJZJscLDBmrrDWndhKiBDqZGyYU0bJWh13ixLSuaVMGLd0g +l5JfShkHLQt3C0UU4TqW5r+H2VKuvRvroMvnPaaLa+BwN4OPWFxQ/wEf2egDlOgfU18 zQnx2fscUXuMZX9q+BR3pJZ+p8NNM+2agmCMfAshy0Rro8FYa/PeOi4KM/0o5jcNeLwh PI2PzP5ahLCex9jApVnM04N36D+mcEPoNnySmVVNg26hhUIvT+usBIdcOAiygbsC6iau qEWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=VKeQ6xPh; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id r23-20020a632057000000b003c61ee0c7f6si9951377pgm.552.2022.05.23.07.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 07:16:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=VKeQ6xPh; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E69025997B; Mon, 23 May 2022 07:16:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237042AbiEWOQT (ORCPT + 99 others); Mon, 23 May 2022 10:16:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236992AbiEWOQR (ORCPT ); Mon, 23 May 2022 10:16:17 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD7A853A60 for ; Mon, 23 May 2022 07:16:16 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id g3so12599584qtb.7 for ; Mon, 23 May 2022 07:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H767C2i0qpntP2Hc25tbjn02oMYnv32wuUYy29Xv2ng=; b=VKeQ6xPhdr+J56IKqkCNNphoFA9/Dp/YQhSmkGwfWDKX1rbeX8HmFE31UJPFRkHOFx uEhxIkgD8DHNx4OWFSVU1Nqh6ZQwz7m/4I5ANeTsgKMLiKJLRkc35PzktklEcXUTAWp1 MMPXycGF/aRmwO5QdDU2rJ1O32iAeffGYuTnGw2LAmGa4n1yzj5y+FLvaTbCp676rYBH //o4NKTmMCRpfHL/yl5hNQvqG5opsemec2n3ZTxWXnYwr0ITu1IO6e/47ZJIXEIt22+u jtmbKxyXVxT2hxvIl6MDdYWeJe5FeELdljLp9cAYp8viRD9ZX1IEroTJZ41CkKrDo+zN qx1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H767C2i0qpntP2Hc25tbjn02oMYnv32wuUYy29Xv2ng=; b=fGAw08k5K9OIucjO17D3qyLwmHSyjupnr16eSgVAhCerlmq4KZ/ac2ukL5lVUQLxS8 UJFMUW9xmE8ZASsIN8zH2iWHGh8RKtAyiOb/K2aJxRhgiZrOwUK8Ie6s70NQNEtEyWjk cQx/DzGnl+gWKWCuad5PIGbZvUW9vKWIwgGQmMqM7m5kxdp+uiR83Ei4FDs4PsU37x6N 4dg4rbxyncoExgESo6Y1R4OHvQkD03bubcmZgplF9YWzgaoUWw1bLKd25/1IdroZKzwX 09YEXy6y3Utf9On1AgYFmTPeUwqoPpBWUXu+ttI9DhcFP8dq3k9i5apZtVhi1QnIwFT5 EMJQ== X-Gm-Message-State: AOAM530qnru6gc6UKNAUI5OTk4l5nd8/5EHSBF8IJRJs3jIYh83eizUL r859g61MKa1N7PJ8zHG3iz3MQ/eHxU0spA== X-Received: by 2002:ac8:5889:0:b0:2f3:bb3f:b0d2 with SMTP id t9-20020ac85889000000b002f3bb3fb0d2mr16130738qta.593.1653315376387; Mon, 23 May 2022 07:16:16 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id c19-20020a05620a165300b0069fc13ce1e5sm4348806qko.22.2022.05.23.07.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 07:16:15 -0700 (PDT) Date: Mon, 23 May 2022 10:16:14 -0400 From: Josef Bacik To: Yu Kuai Cc: axboe@kernel.dk, ming.lei@redhat.com, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH -next v3 6/6] nbd: use pr_err to output error message Message-ID: References: <20220521073749.3146892-1-yukuai3@huawei.com> <20220521073749.3146892-7-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220521073749.3146892-7-yukuai3@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 21, 2022 at 03:37:49PM +0800, Yu Kuai wrote: > Instead of using the long printk(KERN_ERR "nbd: ...") to > output error message, defining pr_fmt and using > the short pr_err("") to do that. The replacemen is done > by using the following command: > > sed -i 's/printk(KERN_ERR "nbd: /pr_err("/g' \ > drivers/block/nbd.c > > This patch also rewrap to 80 columns where possible. > > Signed-off-by: Hou Tao > Signed-off-by: Yu Kuai Reviewed-by: Josef Bacik Thanks, Josef