Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp1998376ioo; Mon, 23 May 2022 07:55:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVsU8B3Ou2kAvt9Kjf4NFu7EMGJgjCtVHMFg6LqV6vOTdy1ccqAKqLcjrGrnO5uatUkKLc X-Received: by 2002:a17:903:22d1:b0:162:166:6a96 with SMTP id y17-20020a17090322d100b0016201666a96mr13287182plg.127.1653317741006; Mon, 23 May 2022 07:55:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653317741; cv=none; d=google.com; s=arc-20160816; b=WSOwCMzQi1430dI0PWBkro30gl7o2A5/SfK8JUHfSzfBVbqvjwfD5ZNoISZ1SGEYAI TvE3f/BRcfT6NwmZoud0NYzBN+f8avlqir7Dj7w4F5GUCY7jkD1fC+3y9h1ad2U4nYcr Ls2vQwfPwNmdiMBpokMUKZwSzGhd8C3bE9kC699ObvZ/PTbhPLdgt0Y3uwrgXNSB7EDO 9317mfHAHDsFh1iElxBnLpBhfkEkAqhttrWfYJskza6qn4foZ0myyxTlSfeseyhbC0Zh gRC9xlECANEFoARtyrLVd4coPYLLaqX3RKiv4IxZ+ilQ9KWVYOWYhqAvqdqf+NGL9bCb 5iFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lAsfZ94mPmdCtSLuY+yTmU/kf8t1RWq4c+zfwIS3kZU=; b=ZcB+7+oXGIQ3AOxC3HOG9C1LnvS1MiAJymKXg7l1PZP3vJJOW89oUAKEqD1i6XlMuS PU/NtQYa7U+NkDxZE8Si2ZPvywop3B9FqJuIZOPf2A2vF0HPzRRuiCrlbk7p0ZGJ+xhE DDQKC6/DxY7OoLX1tXZ47b1JDC7CM2wfFaeGeQAgkKENiZOyC0Ak4O3POo1WHj3fh4PW n0vPOHsFr3WHGVfcYR8LKsMoBAESlLBiJPIminCu1mJGuX7eWQRsdL3VD1iYbnif5nsI RqGxbtkUfOxh3k+3VEkk8NAkwjPmdhjRKUO5UKUPJeMRg88lXNoH4ChfwXUxohPe6nWz X2mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qL3OCqHc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id w12-20020a65534c000000b003c165f24f4csi10995765pgr.593.2022.05.23.07.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 07:55:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qL3OCqHc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9AD905B3D2; Mon, 23 May 2022 07:55:39 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237385AbiEWOz1 (ORCPT + 99 others); Mon, 23 May 2022 10:55:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237309AbiEWOzY (ORCPT ); Mon, 23 May 2022 10:55:24 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 362E05AEFD; Mon, 23 May 2022 07:55:23 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id w3so6706052plp.13; Mon, 23 May 2022 07:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lAsfZ94mPmdCtSLuY+yTmU/kf8t1RWq4c+zfwIS3kZU=; b=qL3OCqHcHzyKI5hwEV6UajS56blAArm+NUR5fTeRmpHvBTF2luIyJ0ScsLgXZJOktO AF+2XMLz6+6H7LaZw3wtPUtT2Dr+4Kw6bV6pOwQV3I0sQgHyK9n3jm2RFDteLOjtxfmg md34NvnoGVWei0z081yCNsxplR+5EOZMtzGTDcjJb7Bk86yaGlqqyHz2YHa7w7/uP5yQ W1Vdv3MY9pBEomJvjedvwOBD7nZTr9KwQT/Y2VbgfX6x45Vm9FZy+R4QfW+6P5FSp8sj L9iUxeFcwd5G9AcJFDobomkNWm20xsxRiRWJaHYzrnUnhp+bA0nMBFZAz/XRdjsGXlrR kBcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lAsfZ94mPmdCtSLuY+yTmU/kf8t1RWq4c+zfwIS3kZU=; b=XddCAtc0KqcJee7TmelQnvX243FhLci/a+ihnfyizWM9n5VBXkVfGF9BV2dh8fQe8O XtUbs/o5Mu1rnTG8xJN4zYsnpgFBATW0VffjxjsMUa2Jn0UwhsKmLW3u14NGvzLhOheu xnEq9hSUZPZQ/QafDlblzu9M2ziJCqfs/rTPkEAJ1MObXFbpDeaiIstvP/msA5hNBN3H tkL2EwqZQ47RQLo5cgvd0MtCYQFpfDFkZl70mxar9A43/T+1LUFmRxoH7smLkKHd7Mct wwPHTI7a/6FmX4Nt7c7ipgarNXbvNoIGiLj583CgUnikZdm9uXQhlmdxf1IbxWQuNm+a HLhA== X-Gm-Message-State: AOAM532JfmD2mUQDWiJRtkfq5GU5o0LXbgoY3XNOP93kDBEvqOT1o+9M UseREfhvCT/cXLie7P+xTJne+QfFtHB/9w== X-Received: by 2002:a17:903:124b:b0:15e:84d0:ded6 with SMTP id u11-20020a170903124b00b0015e84d0ded6mr22841886plh.141.1653317722732; Mon, 23 May 2022 07:55:22 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id o13-20020a17090a4b4d00b001df264610c4sm138116pjl.0.2022.05.23.07.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 07:55:22 -0700 (PDT) From: Miaoqian Lin To: Russell King , Krzysztof Kozlowski , Alim Akhtar , Pankaj Dubey , Tomasz Figa , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: exynos: Fix refcount leak in exynos_map_pmu Date: Mon, 23 May 2022 18:55:13 +0400 Message-Id: <20220523145513.12341-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() checks null pointer. Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT") Signed-off-by: Miaoqian Lin --- arch/arm/mach-exynos/exynos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 8b48326be9fd..51a247ca4da8 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -149,6 +149,7 @@ static void exynos_map_pmu(void) np = of_find_matching_node(NULL, exynos_dt_pmu_match); if (np) pmu_base_addr = of_iomap(np, 0); + of_node_put(np); } static void __init exynos_init_irq(void) -- 2.25.1