Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a7bbd451-e054-c69c-6e39-e73320878b8f@linux.intel.com>
Date:   Mon, 23 May 2022 23:03:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: Add support for mx66l2g45g
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>
Cc:     linux-mtd@lists.infradead.org,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>, linux-kernel@vger.kernel.org
References: <20220523143002.1754922-1-jiaqing.zhao@linux.intel.com>
 <fde9bd5a-7161-9222-4719-4279b2416163@linux.intel.com>
 <35d64d702798d437245090ce96ae29a8@walle.cc>
From:   Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
In-Reply-To: <35d64d702798d437245090ce96ae29a8@walle.cc>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022-05-23 22:59, Michael Walle wrote:
> Am 2022-05-23 16:33, schrieb Jiaqing Zhao:
>> Use PARSE_SFDP for now as the SNOR_ID3() patch is not merged yet, will
>> switch to it after it is merged.
> 
> Fair enough, could you resubmit it with
> { "mx66l2g45g",  INFO(0xc2201c, 0, 0, 0) PARSE_SFDP },
> 
> Looks odd, but is the same as SNOR_ID3(0xc2201c), so we can just
> switch to the new macro without any more testing. Or Pratyush can
> replace it inline while committing this patch if the SNOR_ID3()
> will make it in before.

I'll add a TODO comment in case we forgot it.

> -michael