Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3581525lfo; Mon, 23 May 2022 08:26:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbjeEzl4wQ/dL6qhMRZUNkMN1nANy2gwPwos+rbjhujhBpeFPPWOQICTJ3QpHWzZXcaYGc X-Received: by 2002:a17:902:b698:b0:158:faee:442f with SMTP id c24-20020a170902b69800b00158faee442fmr23843814pls.75.1653319589251; Mon, 23 May 2022 08:26:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653319589; cv=none; d=google.com; s=arc-20160816; b=wJKzQKBS3LFSz/c5hYtyC6Y8XbtUQK9282WdNvtEfRXlxeWoL9eZ/NcIXD0RY6OaPE npa8H9NApRvVgcgwZM+trCNXrfUH8pIkXOZPkkeO3ixNjhuX6TS5w0LU8k4KjzvgUUn/ BqcMxbuHCZQMVjtPIH0HhqTIN4JgpS7peV4rvyPeylXD1CjZcctkGxT9jktDMQTrghil zvmHjvignPcafHGnbdAWoGGZA92H/SB42cVN8ldwp8aQYfxvd3Boz1CFu22uHFLYwBMl 0G7x8XA03oOj4EwbihiDF1vNUW/1ziesk6tM4FBfMmdOthh68OM2VYlXbzW4G9etKL6z kzXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WBefDxvxtxt5IxjHT2/tgFIZi4ggidKlFNejNdBd/G4=; b=oys19NNrGiHsQD3DBTK7eABNG7loiL9zBU1SUO+8LaUv/CTuBXSzkYY2elFkSCYZHZ nmjt13epCvyQykP+q+/Tl1jjnzAuW7C3km+ceBZn4sb+8m6h+e9veZHqg8NQ+TiSXxy0 A425jF0L0BtTiPovGmvVi6wbaoA2rA2ICHfqPcPrQNsqOOyRCoKv1ZLJ1vMf4cj/lPZt yYHj0ImscELPuL24wO7DEaygRkRNaAuop8rdDBk4TqURFDr4StiOY9g0wRaSCQ8mfn95 zDxL8sKlrclpj6FFiEUqY0pplXQ3OSnelRh3KO+ff4DSGaNkUkdUeiUdbuyFxsUf3L79 BOfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xSpPWAZs; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q19-20020a637513000000b003c618493a2fsi11128736pgc.798.2022.05.23.08.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 08:26:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xSpPWAZs; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A817A5E14C; Mon, 23 May 2022 08:26:24 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237922AbiEWP0S (ORCPT + 99 others); Mon, 23 May 2022 11:26:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237876AbiEWP0Q (ORCPT ); Mon, 23 May 2022 11:26:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D089532FF; Mon, 23 May 2022 08:26:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BF605B81014; Mon, 23 May 2022 15:26:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EC89C385A9; Mon, 23 May 2022 15:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653319572; bh=Tn18BFV/rU6iBwpcbPUyBxptSd3tEtMVOtluoy49Yi0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xSpPWAZsmg72NIc2h88A/wShFKIanQjFYWsbA6cspbAR46ED9hMchHbtVsuR/Bvib nZwp+S/JSnFUeONrEVJ5Dl2JVlIaDLq8XywanIcRMvGimAQvUl9Mc/El00hQRoWUQg laC0SUpyAVSveesmiS8xPBPS23AH0vh5etZh7tP4= Date: Mon, 23 May 2022 17:26:09 +0200 From: Greg KH To: "Denis Efremov (Oracle)" Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, dan.carpenter@oracle.com, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, stable Subject: Re: [PATCH v5.10] staging: rtl8723bs: prevent ->Ssid overflow in rtw_wx_set_scan() Message-ID: References: <20220520035730.5533-1-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520035730.5533-1-efremov@linux.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 20, 2022 at 07:57:30AM +0400, Denis Efremov (Oracle) wrote: > This code has a check to prevent read overflow but it needs another > check to prevent writing beyond the end of the ->Ssid[] array. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable > Signed-off-by: Denis Efremov (Oracle) > --- > drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) And only 5.10 needs this? What about all other kernel branches? thanks, greg k-h