Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <913bcf4d-dc78-dacb-4891-43a882f50017@linux.ibm.com>
Date:   Mon, 23 May 2022 18:09:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH] powerpc/64s: Don't read H_BLOCK_REMOVE characteristics in
 radix mode
Content-Language: en-US
To:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
        "npiggin@gmail.com" <npiggin@gmail.com>
Cc:     "aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220520155721.10211-1-ldufour@linux.ibm.com>
 <d87cca6d-8cc9-3347-f74a-28f12889cfe1@csgroup.eu>
From:   Laurent Dufour <ldufour@linux.ibm.com>
In-Reply-To: <d87cca6d-8cc9-3347-f74a-28f12889cfe1@csgroup.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 20/05/2022, 18:15:39, Christophe Leroy wrote:
> 
> 
> Le 20/05/2022 à 17:57, Laurent Dufour a écrit :
>> There is no need to read the H_BLOCK_REMOVE characteristics when running in
>> Radix mode because this hcall is never called.
>>
>> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
>> ---
>>   arch/powerpc/platforms/pseries/setup.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
>> index c9fcc30a0365..654d2b999c25 100644
>> --- a/arch/powerpc/platforms/pseries/setup.c
>> +++ b/arch/powerpc/platforms/pseries/setup.c
>> @@ -803,7 +803,8 @@ static void __init pSeries_setup_arch(void)
>>   
>>   	pseries_setup_security_mitigations();
>>   #ifdef CONFIG_PPC_64S_HASH_MMU
>> -	pseries_lpar_read_hblkrm_characteristics();
>> +	if (!radix_enabled())
>> +		pseries_lpar_read_hblkrm_characteristics();
>>   #endif
> 
> As far as I can see the function always exists so the #ifdef can be removed.

You're right, I'll do that in the v2

>>   
>>   	/* By default, only probe PCI (can be overridden by rtas_pci) */