Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   =?utf-8?Q?Lu=C3=ADs_Henriques?= <lhenriques@suse.de>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     Xiubo Li <xiubli@redhat.com>, Ilya Dryomov <idryomov@gmail.com>,
        ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ceph: fix decoding of client session messages flags
References: <20220523160951.8781-1-lhenriques@suse.de>
        <1e1f7397d516f8b9780b08763f6338cd4ce83506.camel@kernel.org>
Date:   Mon, 23 May 2022 17:34:26 +0100
In-Reply-To: <1e1f7397d516f8b9780b08763f6338cd4ce83506.camel@kernel.org> (Jeff
        Layton's message of "Mon, 23 May 2022 12:19:27 -0400")
Message-ID: <87y1ysky25.fsf@brahms.olymp>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jeff Layton <jlayton@kernel.org> writes:

> On Mon, 2022-05-23 at 17:09 +0100, Lu=C3=ADs Henriques wrote:
>> The cephfs kernel client started to show  the message:
>>=20
>>  ceph: mds0 session blocklisted
>>=20
>> when mounting a filesystem.  This is due to the fact that the session
>> messages are being incorrectly decoded: the skip needs to take into
>> account the 'len'.
>>=20
>> While there, fixed some whitespaces too.
>>=20
>> Fixes: e1c9788cb397 ("ceph: don't rely on error_string to validate block=
listed session.")
>> Signed-off-by: Lu=C3=ADs Henriques <lhenriques@suse.de>
>> ---
>>  fs/ceph/mds_client.c | 14 +++++++++-----
>>  1 file changed, 9 insertions(+), 5 deletions(-)
>>=20
>> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
>> index 00c3de177dd6..1bd3e1bb0fdf 100644
>> --- a/fs/ceph/mds_client.c
>> +++ b/fs/ceph/mds_client.c
>> @@ -3375,13 +3375,17 @@ static void handle_session(struct ceph_mds_sessi=
on *session,
>>  	}
>>=20=20
>>  	if (msg_version >=3D 5) {
>> -		u32 flags;
>> -		/* version >=3D 4, struct_v, struct_cv, len, metric_spec */
>> -	        ceph_decode_skip_n(&p, end, 2 + sizeof(u32) * 2, bad);
>> +		u32 flags, len;
>> +
>> +		/* version >=3D 4 */
>> +		ceph_decode_skip_16(&p, end, bad); /* struct_v, struct_cv */
>> +		ceph_decode_32_safe(&p, end, len, bad); /* len */
>> +		ceph_decode_skip_n(&p, end, len, bad); /* metric_spec */
>> +
>>  		/* version >=3D 5, flags   */
>> -                ceph_decode_32_safe(&p, end, flags, bad);
>> +		ceph_decode_32_safe(&p, end, flags, bad);
>>  		if (flags & CEPH_SESSION_BLOCKLISTED) {
>> -		        pr_warn("mds%d session blocklisted\n", session->s_mds);
>> +			pr_warn("mds%d session blocklisted\n", session->s_mds);
>>  			blocklisted =3D true;
>>  		}
>>  	}
>
> Good catch! Should we send this to stable too?

Ah, yeah.  I didn't explicitly tagged it as I assumed the 'Fixes:' would
be enough for that.  But it's probably better to do add the 'Cc: stable'
too.

> Reviewed-by: Jeff Layton <jlayton@kernel.org>

Cheers,
--=20
Lu=C3=ADs