Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758845AbXEPHfW (ORCPT ); Wed, 16 May 2007 03:35:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756595AbXEPHfH (ORCPT ); Wed, 16 May 2007 03:35:07 -0400 Received: from ppsw-4.csi.cam.ac.uk ([131.111.8.134]:52192 "EHLO ppsw-4.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756414AbXEPHfF (ORCPT ); Wed, 16 May 2007 03:35:05 -0400 X-Cam-SpamDetails: Not scanned X-Cam-AntiVirus: No virus found X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ In-Reply-To: <20070516071300.GB14222@infradead.org> References: <464034CF.20700@wpkg.org> <20070516071300.GB14222@infradead.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <6621E298-9B98-478F-AD6E-23559BCB4FF3@cam.ac.uk> Cc: Tomasz Chmielewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, netdev@vger.kernel.org, Krzysztof Halasa Content-Transfer-Encoding: 7bit From: Michael-Luke Jones Subject: Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS Date: Wed, 16 May 2007 08:35:01 +0100 To: Christoph Hellwig X-Mailer: Apple Mail (2.752.2) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 23 On 16 May 2007, at 08:13, Christoph Hellwig wrote: > Not even trying to support LE is a clear merge blocker. Maybe > Krzysztof > can't actually test it himself, which is fine - but not even > pretending > to be endian clean is not what proper Linux drivers do. w.r.t this comment, a working implementation LE implementation can be viewed here: http://www.hohnstaedt.de/ixp_npe/0.3.1/ixp4xx_npe_driver-0.3.1.diff Search in this file for "swap the payload of the SKB" (it's in mac_driver.c) Michael-Luke Jones - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/