Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2101263ioo; Mon, 23 May 2022 10:05:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxACXdPwib/DWrPh2X8cRq3mPwEQIDJ2HBs2rOVmamzqTrG/QRr5IKzqqYTZVUV3HRKGfwW X-Received: by 2002:aa7:9f4b:0:b0:518:1402:cf6 with SMTP id h11-20020aa79f4b000000b0051814020cf6mr24498381pfr.15.1653325532998; Mon, 23 May 2022 10:05:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653325532; cv=none; d=google.com; s=arc-20160816; b=hcgEtS3++fGcgCkgwA1kHCw3hNdbxrA9kdvt9uTcdPMa5YlumFqXJcl6YYz6OcoXxt Tv1t650vHESshBHqezr+RIMrawgixbMM7RLOGszZuk6UgolCLFUo8wwGcnFLeyFldI/2 frM9tIg+iWTemjqfNDZv3UfHWmxnuLvbKcIZAnX22XxkcwzTii5lDKSOD5xgg2/WGAaq 8HBCFnltAg6FoaKDX7I9bwvnOVNv0wNQxTmxYmaPR4qUcUOfafgCVfZznLByqOi+8n6d h+2tcwvjc4jIivLAyQJWt/8ISpjik3+SauXOuUkZ/tG/m4HR0RDCoHYHM25GtHUtT4BI tmPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cxuTNkDnxIGXtOjXs0qkhnho7UrB+HqijnWwHsR3lQU=; b=FoLqdkHNtyLLyaULLkUZuMfFANvC69kaCfbQ/f0Qt21fRI1TCo1nuTBKs3o0TrlAQB GtPtUqP5n6mzcoIdYwuHUlx2DtOvYKyeIRyY391pEZNUzH31StlhKsdQyiek7S7KAlvH NaGZpUORKTxj2bLxVvE9hjqpr7Ymubxllj53wccHcYU3/D0zXdjgHAiBOTNQRKwwrBoy 35DPfwxhJq93Mx7cd9HNto2lkkhqstg9wrkMC7mIbJQmC9d3HyjKrsY2nRzzgq5aeAEp VQxvjOyB8jWV5dE6RZmyNNu2G1D5NuiileDJeNlAzk603V0uKtA73YhhLLO8/EuHWi+3 TBBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PMlYIsf2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 2-20020a630302000000b003fa15e58d86si6052198pgd.427.2022.05.23.10.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 10:05:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PMlYIsf2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C41AC69CF6; Mon, 23 May 2022 10:05:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239340AbiEWRFQ (ORCPT + 99 others); Mon, 23 May 2022 13:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239260AbiEWREo (ORCPT ); Mon, 23 May 2022 13:04:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6679262BC5; Mon, 23 May 2022 10:04:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0FBCDB811E9; Mon, 23 May 2022 17:04:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70933C385A9; Mon, 23 May 2022 17:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653325480; bh=KK64IlH3w9eeVXqXAmJOrVOhdQ3ukjaBlyzBvMQ66Vc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PMlYIsf2mLr9+jZUE/Bohx45SOZuSlPqPkuwcfxzN8PxD+zwC+rSnpFf6MaDvF+nX CO24Bj4uKLUnvhsZZmHpxFay21bmFeomOBlyqwt8DJV8HlGDnucb4jvPcMosnAxj7K i7cjjMwh3Fyn8of4hr6I+l+7StMkFLwfAXl4Ro5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Ulf Hansson , Kamal Dasu , Florian Fainelli Subject: [PATCH 4.9 07/25] mmc: core: Specify timeouts for BKOPS and CACHE_FLUSH for eMMC Date: Mon, 23 May 2022 19:03:25 +0200 Message-Id: <20220523165745.966956440@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165743.398280407@linuxfoundation.org> References: <20220523165743.398280407@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ulf Hansson commit 24ed3bd01d6a844fd5e8a75f48d0a3d10ed71bf9 upstream The timeout values used while waiting for a CMD6 for BKOPS or a CACHE_FLUSH to complete, are not defined by the eMMC spec. However, a timeout of 10 minutes as is currently being used, is just silly for both of these cases. Instead, let's specify more reasonable timeouts, 120s for BKOPS and 30s for CACHE_FLUSH. Signed-off-by: Ulf Hansson Link: https://lore.kernel.org/r/20200122142747.5690-2-ulf.hansson@linaro.org Signed-off-by: Kamal Dasu [kamal: Drop mmc_run_bkops hunk, non-existent] Signed-off-by: Florian Fainelli Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/core/core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -61,6 +61,8 @@ /* The max erase timeout, used when host->max_busy_timeout isn't specified */ #define MMC_ERASE_TIMEOUT_MS (60 * 1000) /* 60 s */ +#define MMC_CACHE_FLUSH_TIMEOUT_MS (30 * 1000) /* 30s */ + static const unsigned freqs[] = { 400000, 300000, 200000, 100000 }; /* @@ -2936,7 +2938,8 @@ int mmc_flush_cache(struct mmc_card *car (card->ext_csd.cache_size > 0) && (card->ext_csd.cache_ctrl & 1)) { err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, - EXT_CSD_FLUSH_CACHE, 1, 0); + EXT_CSD_FLUSH_CACHE, 1, + MMC_CACHE_FLUSH_TIMEOUT_MS); if (err) pr_err("%s: cache flush error %d\n", mmc_hostname(card->host), err);