Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2121075ioo; Mon, 23 May 2022 10:30:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgbC7sv+204tVm7uVh3oAcHxZC4AVuBZsQYEoMjSi21cAJAquYdjCLUH6o/j0eya94urNV X-Received: by 2002:a05:6a00:1588:b0:518:8ce2:7753 with SMTP id u8-20020a056a00158800b005188ce27753mr10571584pfk.51.1653327044458; Mon, 23 May 2022 10:30:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653327044; cv=none; d=google.com; s=arc-20160816; b=gOuEi5rOTcm9wHopCotbCoHUUJ2a1YBKGcysV89+LptwOl+WeJlOsgage2lgnNMIn/ ixp5im/13EAQ/72/MSo7nvDo8279Hr9iVUQfewSJzvcDB3hop8LK89yA7s4UWn4nxjZ5 PqL5dltmzV4w8ds7HPUPRo8poRfYocGeF9Br40DJiBjW6dV86QJuj4Q4zsCiPPXEMBA2 hI1bYRn9F/EvFbdwP5mLFHa7XlkhVefAvYbZxPxv0k/zVUpcIyOnFgOe9LcW2jQsHuaR SFflQEWHfWYnOEzTF4q/P2HVc57Jh/e1zslSKcIxK27VObgAvbI8E9mBmRkM7ysuXGJ3 NIpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=h/UE5DAgjOPClCoDBrLMRMITXJSPzNLLZ10dH1hzLsA=; b=VrzWQ2PUOhD3l8JZDErJsfHULZUZlVwCT9MixjMC3ObWCkakDwdK42NGJNyYbptuK3 yuKQOv1pKUMBfJguTfjRaA4NbFONP4iuYTP7tvxm3bfY0MOfkHRpKsFii2QzxLRv/az6 XFh2oghlM5vhr9ROoYUQ+FTjQZz/yuyO+NETxudZd9rG2yK/1siNSf5DDzAQgf42fvro NCN4u7+DgzYvPae1TZZc6/f4MINcoE1UYmGndD+Ejec3nKQKe/19LL5rxKmO3L0vvRNq HMqPjGcYAn0grcwny4gstzM01KIlpBLXvuDJEUWxaTi/zEHd3ohmV3nxf9U29hkljodi P+3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cd0y1+UU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d11-20020a056a0010cb00b005189905de2asi6190887pfu.172.2022.05.23.10.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 10:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Cd0y1+UU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A160425C77; Mon, 23 May 2022 10:30:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240348AbiEWRZf (ORCPT + 99 others); Mon, 23 May 2022 13:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239691AbiEWRR3 (ORCPT ); Mon, 23 May 2022 13:17:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C448B6D968; Mon, 23 May 2022 10:17:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D9DC60EE2; Mon, 23 May 2022 17:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A304C385AA; Mon, 23 May 2022 17:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653326233; bh=o5YtqxkUYupf5MqFxlK83h7HgWm6uI/kZfcY6w2ynMI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cd0y1+UUcE5iXMVs9usZc0odsstHKbzrrWxrKiPGmjewPHAOPygVPsl+HI/Lgq/K6 7i6pmewtJEC2Nu1XTlY1flA0bYnzVMzheE2kYAAsstpcfnQeyYwY1G3ZTwRrgM5lB/ 8W3avawU+BJPpheocclL0J3uzXQnawVnUAZfn/xo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Greg Thelen , Yu Liao Subject: [PATCH 5.15 018/132] Revert "drm/i915/opregion: check port number bounds for SWSCI display power state" Date: Mon, 23 May 2022 19:03:47 +0200 Message-Id: <20220523165826.585851687@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165823.492309987@linuxfoundation.org> References: <20220523165823.492309987@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Thelen This reverts commit b84857c06ef9e72d09fadafdbb3ce9af64af954f. 5.10 stable contains 2 identical commits: 1. commit eb7bf11e8ef1 ("drm/i915/opregion: check port number bounds for SWSCI display power state") 2. commit b84857c06ef9 ("drm/i915/opregion: check port number bounds for SWSCI display power state") Both commits add separate checks for the same condition. Revert the 2nd redundant check to match upstream, which only has one check. Signed-off-by: Greg Thelen Signed-off-by: Yu Liao Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/display/intel_opregion.c | 15 --------------- 1 file changed, 15 deletions(-) --- a/drivers/gpu/drm/i915/display/intel_opregion.c +++ b/drivers/gpu/drm/i915/display/intel_opregion.c @@ -376,21 +376,6 @@ int intel_opregion_notify_encoder(struct return -EINVAL; } - /* - * The port numbering and mapping here is bizarre. The now-obsolete - * swsci spec supports ports numbered [0..4]. Port E is handled as a - * special case, but port F and beyond are not. The functionality is - * supposed to be obsolete for new platforms. Just bail out if the port - * number is out of bounds after mapping. - */ - if (port > 4) { - drm_dbg_kms(&dev_priv->drm, - "[ENCODER:%d:%s] port %c (index %u) out of bounds for display power state notification\n", - intel_encoder->base.base.id, intel_encoder->base.name, - port_name(intel_encoder->port), port); - return -EINVAL; - } - if (!enable) parm |= 4 << 8;