Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp2124305ioo; Mon, 23 May 2022 10:35:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvJYXrueUZgYi6pAcnjx0ECze0m8O6/SGeGTjOKiJrbW+n+UxlV/tByyRxTVd5wp2Nq59c X-Received: by 2002:a17:90b:1bc6:b0:1df:cb4b:836e with SMTP id oa6-20020a17090b1bc600b001dfcb4b836emr91032pjb.117.1653327311002; Mon, 23 May 2022 10:35:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653327310; cv=none; d=google.com; s=arc-20160816; b=pFL4l8lKJF2wsFR7BgE6cqTARaZELhe24ZIorxF4av8FrP+/Ao0xgL+w2C1e6nVIbh Sb0rpaaD6X/wKVvN6R5Qxdfz73b3j58hsztPpcMxkAsMULbksawh9KNVfNPz+oTuHZj+ WZsb9qMz42e39NGQ9imIGwX3+986Foi6K9ClOjl0ja9A8rnl5PSBkq11Jnv3zA6ghEdi Dl8IvujTLIPx7aU2U5Z8Iv12X7irEyGJBqzXjInUGeA2gZS0EVPc4OQSvWQvUq9WhrSP 2eyTU/KopsVvd5IRwAlkT/FfZTm6Q9qK3belKL7v/bccutys4dVN3kyI2IVDI09/GBm9 ejBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4ou8EMc+GeXJhaUiS4Jjaqik3+kdp9xKFOpnuqnFVRA=; b=xPPVwYsosqvr9/NKfSE3l4f33FmBi1VWzJ5Jb4Cc7ik8ifDhtMvmqOgZU+D8LI1w7o U20DMNuqwOhAB6M6RALbv8Lt7jRIOTgVKwzdSmR0rZ7/pBahxizB6NRrsVFzaaGYNM9U qERzaNzqSigFHNwBGorZ2qckwYQN4zZEbP/YHH3Xm5ly9KD6zIs8niB1LHdNZ0Mg7zgJ aigNJfm4RJVw0cdTk4AIa/1JRuEr0XMYS2sRzHEct5+8IO7o3vhLUHru2CDw4iuGwptG Np6fXQjloCIpr9o6AHH+9IRxSEGuGWdIWWvwZ2b9d6W8OuCOOym+gZVFMDwt7BEO8Bbe X5ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z9xjDvLV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d22-20020a056a00199600b0050d2398a2b9si14768415pfl.221.2022.05.23.10.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 10:35:10 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z9xjDvLV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BF6D79CF15; Mon, 23 May 2022 10:33:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239767AbiEWRcc (ORCPT + 99 others); Mon, 23 May 2022 13:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240576AbiEWRVG (ORCPT ); Mon, 23 May 2022 13:21:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA55063383; Mon, 23 May 2022 10:17:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6E7EBB8121A; Mon, 23 May 2022 17:17:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC8CFC385AA; Mon, 23 May 2022 17:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653326275; bh=xkOMtRcSAF4tvoeHESppoblqzKn/AtmYDZuKUi5GB7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z9xjDvLVsTgMjBSuItEvYfplFLqgm3FdVJPVnxA1utz1R3YTpxef6ATukD4xosbPw u8hsFhWcBW/FMYf8PAWMam2sC3ttAAwcx41jqY+xiC2rHd4h0yXY8IEYOPAqGSPLmy 0y8o0ch27aF4btYKdGvg6Hlt3nyqIIOw/WNtjE1c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Terry Bowman , Andy Shevchenko , Jean Delvare , Wolfram Sang , Mario Limonciello Subject: [PATCH 5.15 011/132] i2c: piix4: Add EFCH MMIO support for SMBus port select Date: Mon, 23 May 2022 19:03:40 +0200 Message-Id: <20220523165825.482033516@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165823.492309987@linuxfoundation.org> References: <20220523165823.492309987@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Terry Bowman commit 381a3083c6747ae5cdbef9b176d57d1b966db49f upstream. AMD processors include registers capable of selecting between 2 SMBus ports. Port selection is made during each user access by writing to FCH::PM::DECODEEN[smbus0sel]. Change the driver to use MMIO during SMBus port selection because cd6h/cd7h port I/O is not available on later AMD processors. Signed-off-by: Terry Bowman Reviewed-by: Andy Shevchenko Reviewed-by: Jean Delvare Signed-off-by: Wolfram Sang Cc: Mario Limonciello Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-piix4.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) --- a/drivers/i2c/busses/i2c-piix4.c +++ b/drivers/i2c/busses/i2c-piix4.c @@ -753,10 +753,19 @@ static void piix4_imc_wakeup(void) release_region(KERNCZ_IMC_IDX, 2); } -static int piix4_sb800_port_sel(u8 port) +static int piix4_sb800_port_sel(u8 port, struct sb800_mmio_cfg *mmio_cfg) { u8 smba_en_lo, val; + if (mmio_cfg->use_mmio) { + smba_en_lo = ioread8(mmio_cfg->addr + piix4_port_sel_sb800); + val = (smba_en_lo & ~piix4_port_mask_sb800) | port; + if (smba_en_lo != val) + iowrite8(val, mmio_cfg->addr + piix4_port_sel_sb800); + + return (smba_en_lo & piix4_port_mask_sb800); + } + outb_p(piix4_port_sel_sb800, SB800_PIIX4_SMB_IDX); smba_en_lo = inb_p(SB800_PIIX4_SMB_IDX + 1); @@ -843,12 +852,12 @@ static s32 piix4_access_sb800(struct i2c } } - prev_port = piix4_sb800_port_sel(adapdata->port); + prev_port = piix4_sb800_port_sel(adapdata->port, &adapdata->mmio_cfg); retval = piix4_access(adap, addr, flags, read_write, command, size, data); - piix4_sb800_port_sel(prev_port); + piix4_sb800_port_sel(prev_port, &adapdata->mmio_cfg); /* Release the semaphore */ outb_p(smbslvcnt | 0x20, SMBSLVCNT);