Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3664667lfo; Mon, 23 May 2022 10:45:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXwQsMI/X8CP4JOEWcR7obGDkNFLaf52/YYAWjGeCT1/zp/11UIYW2M7NkAzgCDAuTWgV5 X-Received: by 2002:a05:6a00:1487:b0:518:b952:889b with SMTP id v7-20020a056a00148700b00518b952889bmr2442618pfu.43.1653327914403; Mon, 23 May 2022 10:45:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653327914; cv=none; d=google.com; s=arc-20160816; b=Nr/uIFkr8QvrEjbdutzq1jDV5I60LZlHLfDJkYQQfHPQpRDioOsgEETI02PJ/7lvur HyRuq6biwjAHJSGUwlID+jxnEB2VW1CGFwRpFFShzWXtsHeujawu6+zOVvHCHVZMIu9v Jkc50B0K1rW/qbiZeUm05fJJtHN3FIwuV2xiXz3egzgTZJCWEocPwNSHxNNSH5fKru2x vm0utVewrcsVa3o2V49WR2W7mCpqtzzc4vaIe82b9KNgFsKMcsgCidVocOApQuK8R/fa TS3+vqQS/iUkPQ1GY1/aQEHBEESv/kWT0JwhZU49bJCV7FfqVZm8IWlrQiL0Mg2tOAzf j9GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UpEUJ0win9bVCFX1TqyHUns1H5Y0MD+MCeFClTx7TkM=; b=jhuUOXNawtIGm8EwarXhXap/5hQdF/qmG452GvT9dvggYrGw2BatNTdDykwVCs4sid npwPO1UwKzqD1/kwgzs0frnzoRp3smSAiBRCqR4B3jO4i0KcCCbM22ie/zYi8tFTBp1n QUCSVTBOKVTNtIO78HFvJ9PPt/uAy6vISskerTO12Oa/7+mz9Nns21mw40Wg4r4FcVNl hzK1XiKlGoAbQ0SLAbkF/BRSGIPoWurfk/41MYBXANibMBIlna/nShLxCnf+YS7Abg2X pUAZrWBsmfspke+k4ylQVmXlP+vpy2w/IJspmJUhTcBJt4/L8tsVQ71qeNqBb7+92YeD W52A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=khYrhC1a; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id c20-20020a170902b69400b00156ea908d59si10191233pls.304.2022.05.23.10.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 10:45:14 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=khYrhC1a; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2C72BD680D; Mon, 23 May 2022 10:44:56 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243208AbiEWRli (ORCPT + 99 others); Mon, 23 May 2022 13:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242445AbiEWR1n (ORCPT ); Mon, 23 May 2022 13:27:43 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 510BE7CDE7; Mon, 23 May 2022 10:23:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0BF35B811FB; Mon, 23 May 2022 17:23:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6515BC385A9; Mon, 23 May 2022 17:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653326599; bh=hKElF9otkgLbePNPxfSEj+iBFI7kjq0H8+dEpqV4T/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=khYrhC1az22OSCysuIXz9AfvbTsboDHQQR54swbKzGQNFlyc2cOaE2MWwg6bBx0la JYYGZEMMqaERMoUHyBOIHcS1YGZu+RHWlejzB2Unl75Ly7b6kosMlS16lCk6XtmOqz Xo4At3wKo2HGViNJsqNqGq/wX+fbw/iEQH+tnTbM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.15 109/132] gpio: mvebu/pwm: Refuse requests with inverted polarity Date: Mon, 23 May 2022 19:05:18 +0200 Message-Id: <20220523165841.573244770@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165823.492309987@linuxfoundation.org> References: <20220523165823.492309987@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-König [ Upstream commit 3ecb10175b1f776f076553c24e2689e42953fef5 ] The driver doesn't take struct pwm_state::polarity into account when configuring the hardware, so refuse requests for inverted polarity. Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") Signed-off-by: Uwe Kleine-König Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-mvebu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index ad8822da7c27..1448dc874dfc 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -707,6 +707,9 @@ static int mvebu_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, unsigned long flags; unsigned int on, off; + if (state->polarity != PWM_POLARITY_NORMAL) + return -EINVAL; + val = (unsigned long long) mvpwm->clk_rate * state->duty_cycle; do_div(val, NSEC_PER_SEC); if (val > UINT_MAX + 1ULL) -- 2.35.1