Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3670142lfo; Mon, 23 May 2022 10:55:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEzxMRDnwSlv6c56UHEtM9pOz9KsWIGusdinMn/EHl4R6T1ytZZdd6CvGLGZZQRJeLO0On X-Received: by 2002:a17:902:cec7:b0:161:cfc9:45f6 with SMTP id d7-20020a170902cec700b00161cfc945f6mr23892063plg.136.1653328547179; Mon, 23 May 2022 10:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653328547; cv=none; d=google.com; s=arc-20160816; b=MjgUGSsreHNVAxPeBH1f5icKc1AlwmNDsBAN5r8U7i8CJ9az6rUwsCc54TbIWtzz3+ GRl25T0aJjDtcyScMSxByUa2bYjpDzI8uNQzbw4n5pJt2ratHI0RQ4+37jUR6/DC6tiU vp+5gEKbXBZSwhzsIppNuUDtMO9Cqkf3mskjQ8kdyjsmixXoOQNra0yrZM1CPqcpALf1 x/y3GGKQf6+NOUL+pKI9VmHnvZyzK6w5Q3c9k7QD0kVpWpVUeTFCOe4dOLU2IusnI0bH 9LO581hjOq5NmjQUX9UoOge1bRmo+ee5tpy92Br3ERQRk9uProMuD9P9X1x2xpQvRXZX NSGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4ou8EMc+GeXJhaUiS4Jjaqik3+kdp9xKFOpnuqnFVRA=; b=xMuCuzEsymvqZfGAmD7fy01uUEX7GP1nyvDZDbCkRts2BMa2iQeWFaBcexubmKlFKE eVPayGEsda4upz21bZLcU8SslezxoiSzg5WXqcrdpypq2HqPM9YjBb6evMChyAH2c98O Nl4reeSEPowxbKjEjhf9V8J2flgOUzN+oDBpQctHnM+2Hzs44lYlSqBY47kQ4SnWeb60 TBEIL4Fq3mNFCGKw44QZZLYtYRCCrSeAzDmgbyB8Xl/Ob2mGAdT4iiUT+DStBP8pfqrZ nnq6nHgLHy9ShNOB+wQhPrD80nwFC/Qv8aUmtiWTZgeMFbyN/dGCb2F3u/fyiVQ7+dA+ BleQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iRXv1moW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id bb19-20020a17090b009300b001ca6c627df7si13249014pjb.117.2022.05.23.10.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 10:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=iRXv1moW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 523A81078B6; Mon, 23 May 2022 10:55:21 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243385AbiEWRv1 (ORCPT + 99 others); Mon, 23 May 2022 13:51:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240608AbiEWR3L (ORCPT ); Mon, 23 May 2022 13:29:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27EAC36681; Mon, 23 May 2022 10:26:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C6CB61148; Mon, 23 May 2022 17:24:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3464AC385A9; Mon, 23 May 2022 17:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653326692; bh=xkOMtRcSAF4tvoeHESppoblqzKn/AtmYDZuKUi5GB7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iRXv1moWv1oi9qkbq4CPea59edi5xUXj6ngli05MzjMLEhc1dDWtfnOwZ7a/Xzmcf +86tdtSKfUWwUCn8HarsRs02KvnV4epqrC7Hf+B3GCG9WbAspjBR4ekiPBEQ8r58I+ JubCPfPlCP6qCkYm5vah0TSlKO3Pj4iliJZa1AnQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Terry Bowman , Andy Shevchenko , Jean Delvare , Wolfram Sang , Mario Limonciello Subject: [PATCH 5.17 010/158] i2c: piix4: Add EFCH MMIO support for SMBus port select Date: Mon, 23 May 2022 19:02:47 +0200 Message-Id: <20220523165832.274162265@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165830.581652127@linuxfoundation.org> References: <20220523165830.581652127@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Terry Bowman commit 381a3083c6747ae5cdbef9b176d57d1b966db49f upstream. AMD processors include registers capable of selecting between 2 SMBus ports. Port selection is made during each user access by writing to FCH::PM::DECODEEN[smbus0sel]. Change the driver to use MMIO during SMBus port selection because cd6h/cd7h port I/O is not available on later AMD processors. Signed-off-by: Terry Bowman Reviewed-by: Andy Shevchenko Reviewed-by: Jean Delvare Signed-off-by: Wolfram Sang Cc: Mario Limonciello Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-piix4.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) --- a/drivers/i2c/busses/i2c-piix4.c +++ b/drivers/i2c/busses/i2c-piix4.c @@ -753,10 +753,19 @@ static void piix4_imc_wakeup(void) release_region(KERNCZ_IMC_IDX, 2); } -static int piix4_sb800_port_sel(u8 port) +static int piix4_sb800_port_sel(u8 port, struct sb800_mmio_cfg *mmio_cfg) { u8 smba_en_lo, val; + if (mmio_cfg->use_mmio) { + smba_en_lo = ioread8(mmio_cfg->addr + piix4_port_sel_sb800); + val = (smba_en_lo & ~piix4_port_mask_sb800) | port; + if (smba_en_lo != val) + iowrite8(val, mmio_cfg->addr + piix4_port_sel_sb800); + + return (smba_en_lo & piix4_port_mask_sb800); + } + outb_p(piix4_port_sel_sb800, SB800_PIIX4_SMB_IDX); smba_en_lo = inb_p(SB800_PIIX4_SMB_IDX + 1); @@ -843,12 +852,12 @@ static s32 piix4_access_sb800(struct i2c } } - prev_port = piix4_sb800_port_sel(adapdata->port); + prev_port = piix4_sb800_port_sel(adapdata->port, &adapdata->mmio_cfg); retval = piix4_access(adap, addr, flags, read_write, command, size, data); - piix4_sb800_port_sel(prev_port); + piix4_sb800_port_sel(prev_port, &adapdata->mmio_cfg); /* Release the semaphore */ outb_p(smbslvcnt | 0x20, SMBSLVCNT);