Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7bf021df-2755-6937-629f-b3ed9281804d@redhat.com>
Date:   Mon, 23 May 2022 13:24:32 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf
 c2c
Content-Language: en-US
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ali Saidi <alisaidi@amazon.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, german.gomez@arm.com,
        benh@kernel.crashing.org, Nick.Forrington@arm.com,
        alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com,
        james.clark@arm.com, john.garry@huawei.com,
        Jiri Olsa <jolsa@kernel.org>, kjain@linux.ibm.com,
        lihuafei1@huawei.com, mark.rutland@arm.com,
        mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org,
        peterz@infradead.org, will@kernel.org
References: <20220517020326.18580-1-alisaidi@amazon.com>
 <YoQRg1r7HuwiO3bZ@kernel.org> <20220518041630.GD402837@leoy-ThinkPad-X240s>
 <32e5a3b7-9294-bbd5-0ae4-b5c04eb4e0e6@redhat.com>
 <20220522061533.GA715382@leoy-ThinkPad-X240s>
From:   Joe Mario <jmario@redhat.com>
In-Reply-To: <20220522061533.GA715382@leoy-ThinkPad-X240s>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/22/22 2:15 AM, Leo Yan wrote:
> Hi Joe,
> 
> On Thu, May 19, 2022 at 11:16:53AM -0400, Joe Mario wrote:
> 
> [SNIP]
> 
>> Last Comment:
>> There's a row in the Pareto table that has incorrect column alignment.
>> Look at row 80 below in the truncated snipit of output.  It has an extra field inserted in it at the beginning.
>> I also show what the corrected output should look like.
>>
>> Incorrect row 80:
>>     71	=================================================
>>     72	      Shared Cache Line Distribution Pareto      
>>     73	=================================================
>>     74	#
>>     75	# ----- HITM -----    Snoop  ------- Store Refs ------  ------- CL --------                      
>>     76	# RmtHitm  LclHitm     Peer   L1 Hit  L1 Miss      N/A    Off  Node  PA cnt        Code address
>>     77	# .......  .......  .......  .......  .......  .......  .....  ....  ......  ..................
>>     78	#
>>     79	  -------------------------------------------------------------------------------
>>     80	      0        0        0     4648        0        0    11572            0x422140
>>     81	  -------------------------------------------------------------------------------
>>     82	    0.00%    0.00%    0.00%    0.00%    0.00%   44.47%    0x0   N/A       0            0x400ce8
>>     83	    0.00%    0.00%   10.26%    0.00%    0.00%    0.00%    0x0   N/A       0            0x400e48
>>     84	    0.00%    0.00%    0.00%    0.00%    0.00%   55.53%    0x0   N/A       0            0x400e54
>>     85	    0.00%    0.00%   89.74%    0.00%    0.00%    0.00%    0x8   N/A       0            0x401038
>>
>>
>> Corrected row 80:
>>     71	=================================================
>>     72	      Shared Cache Line Distribution Pareto      
>>     73	=================================================
>>     74	#
>>     75	# ----- HITM -----    Snoop  ------- Store Refs -----   ------- CL --------                       
>>     76	# RmtHitm  LclHitm     Peer   L1 Hit  L1 Miss     N/A     Off  Node  PA cnt        Code address
>>     77	# .......  .......  .......  .......  .......  ......   .....  ....  ......  ..................
>>     78	#
>>     79	  -------------------------------------------------------------------------------
>>     80	       0        0     4648        0        0    11572            0x422140
>>     81	  -------------------------------------------------------------------------------
>>     82	    0.00%    0.00%    0.00%    0.00%    0.00%   44.47%    0x0   N/A       0            0x400ce8
>>     83	    0.00%    0.00%   10.26%    0.00%    0.00%    0.00%    0x0   N/A       0            0x400e48
>>     84	    0.00%    0.00%    0.00%    0.00%    0.00%   55.53%    0x0   N/A       0            0x400e54
>>     85	    0.00%    0.00%   89.74%    0.00%    0.00%    0.00%    0x8   N/A       0            0x401038
> 
> Hmm‥.  At my side, I used below command to output pareto view, but I
> cannot see the conlumn "CL", the conlumn "CL" is only shown for TUI
> mode but not for the mode "--stdio".  Could you share the method for
> how to reproduce this issue?

Hi Leo:
I figured out why my output was different than yours.

I did not have the slang-devel rpm installed on the host system.  

In my original perf build, I missed the this output in the build log:
 > slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev

Once I installed slang-devel, rebuilt perf, and then reran my test, the pareto output looked fine.

When the TUI support is disabled, it shouldn't corrupt the resulting stdio output.  I don't believe this has anything to do with your commits.  

Last, it looks like you should update the help text for the display flag options to reflect your new peer option.
Currently it says:
   -d, --display <Switch HITM output type>
                          lcl,rmt

But since you added the "peer" display, shouldn't the output for that help text state:
   -d, --display <Switch HITM output type>
                          lcl,rmt,peer

Joe