Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3683516lfo; Mon, 23 May 2022 11:19:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdRwPUxB1KTRu4oG3gp/aqX85aZxjvaV3YcIsbGLyHhTF93a08rgcF/csMqL9CBO/dFJbw X-Received: by 2002:aa7:9e1e:0:b0:518:3ee0:57a7 with SMTP id y30-20020aa79e1e000000b005183ee057a7mr23515921pfq.42.1653329972457; Mon, 23 May 2022 11:19:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653329972; cv=none; d=google.com; s=arc-20160816; b=x1MO3RtXku+f9/3vx2N9aMEbvZXnBOOLRXdqrhApqnP+QgQTxN7gxAsVGupPZ4jZ9Q kedES1sqe0SElLIzZzjm0efkV2Godn86bvuj7eE5ieNZXR1fletzL+JIpW1pDQck/ygn ayuyBObCLi/Z1CqJZtz2294+pATElpUOxCNFwD8luA2kzYUc73vlRI5M4IxiIQKL1S41 pngKocQv3WnFXlSRX4HOWWLJy4YoZ74WHK8lmrWsYh7M35Ysu+787849iGZZjuY5VXt2 CjuGKKYeKbFPDc9aTaZ1Vo5BCpCyskvyUz72GZFE7ml+Cb1K3VhPh1hl3tUryYuEEM0q eNPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=69h0QSuZCv1nMKQfL6riCvGi85m8iNwvzaWibD6CH9g=; b=gwAwcNnQTQOGhRSREFIv3d0Yh8k1hwwILk6k8IqBS+xG+WgZH3CCmmhi/zk68OF78V FeMER32gaMSwRwahl5vuWCMZ/vOzkM2PmHvSV0Q0GRMZtCkk+HkPgdzdmGvcC7a5jXl6 g+D4Fdu+F80fFiMyviiRW6jOlhsITvyFqQUVgWaYYfPKOW5FKcs09CqQ+Dx4WKdSUMoe i3Vf86H/njKvIe/rd5id+/alPZvutjaeNP9fFIq1cuzx1jSSSPXJk7ZfzVNogKZrS1of AJacx+n+8YHlUoPV6YT90b0OnhmZefAqEFYjnkHGDxS2ILYdF/PttIjIcsB5RdDTLMIA MuiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="HlaHy+/S"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u17-20020a631411000000b003c69e8eb047si10643865pgl.140.2022.05.23.11.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 11:19:32 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="HlaHy+/S"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E7A4017854A; Mon, 23 May 2022 11:19:13 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbiEWSNJ (ORCPT + 99 others); Mon, 23 May 2022 14:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242409AbiEWRsf (ORCPT ); Mon, 23 May 2022 13:48:35 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 297B4AEE1D; Mon, 23 May 2022 10:37:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 3E35BCE1714; Mon, 23 May 2022 17:29:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FE1BC385A9; Mon, 23 May 2022 17:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653326944; bh=XK2F6p7d/WIZRUdb45MDYHJw0InqyYcOPlFCpErby0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HlaHy+/SaxGWYk4aSfhf9vPH1Bg4sGhWo2twwNsh7U4ZlURtqsk+6XoAPfPq1g94H bluuVyJ1Wgcg8eXJmrhJW7rjZmoR8lMyifpxbeU2jj9XjJckdbfdim9D2xsJHbfC1B HQ0Iygc5iXDpZ+R4q4K4sEeJgyvBNBypGru2hjq8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gal Pressman , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.17 108/158] net/mlx5e: Remove HW-GRO from reported features Date: Mon, 23 May 2022 19:04:25 +0200 Message-Id: <20220523165849.017693297@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165830.581652127@linuxfoundation.org> References: <20220523165830.581652127@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gal Pressman [ Upstream commit 6bbd723035badafe4a8eb17ccdecd96eae7a96d5 ] We got reports of certain HW-GRO flows causing kernel call traces, which might be related to firmware. To be on the safe side, disable the feature for now and re-enable it once a driver/firmware fix is found. Fixes: 83439f3c37aa ("net/mlx5e: Add HW-GRO offload") Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 4b83dd05afcd..3500faf08671 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -4828,10 +4828,6 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev) netdev->hw_features |= NETIF_F_HW_VLAN_CTAG_FILTER; netdev->hw_features |= NETIF_F_HW_VLAN_STAG_TX; - if (!!MLX5_CAP_GEN(mdev, shampo) && - mlx5e_check_fragmented_striding_rq_cap(mdev)) - netdev->hw_features |= NETIF_F_GRO_HW; - if (mlx5e_tunnel_any_tx_proto_supported(mdev)) { netdev->hw_enc_features |= NETIF_F_HW_CSUM; netdev->hw_enc_features |= NETIF_F_TSO; -- 2.35.1