Received: by 2002:ac2:464d:0:0:0:0:0 with SMTP id s13csp3689031lfo; Mon, 23 May 2022 11:30:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+/q9oQVpnKrAwwYqH0zw5GRn7ACxG1l6ElVn+UT0Jn9ugv2lUuj6qB5Gor/nsUk7hpMfy X-Received: by 2002:a17:90a:930b:b0:1bf:ac1f:6585 with SMTP id p11-20020a17090a930b00b001bfac1f6585mr338658pjo.88.1653330640839; Mon, 23 May 2022 11:30:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653330640; cv=none; d=google.com; s=arc-20160816; b=YXmNeHUJNmx08mkfa/XJ7H40Pw8e2xlkHtyD8dgnBRudm2YbPB0hbjpaK/IzF3Vs0s ERHvWOY/VktvKt+hkYm+IdUnB7t9HsufoifOD06CPySUwOPTFc5wEAUWSxM7QWLU/Y5G e0g3WEuim3yH1vVsyTSk+GzS9CfUhr7MT9QG+iJdI2O4wN519k2XPaNtlctqkuNURtOX ysF/hnFEjUb0Ik5KFIuMcp6QekOKNmAzvEyWz3QNRzz+us209WHxsZujsEWN5+b7lAL5 XA8aIpdrInHDAtlOA6Z9Nw3ZNsntZ5F/UL5QTkqVWyxSdT7ZFf4MaWOQD5h7IPjMGHfC AgUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rKgOLvnGjE+zlNtBDi/aLmMFimwJby3E+kWTz31hpB4=; b=PRFxK2QItRdb0zOXXIYHc97ahmuXHmd8YtzWxSzosdWesbgcwraVU9TKFCNfsAKSMf xsUf7K/41E8HXdR0bcl2mdbeIPMG0wXyN+O64H+PIFvy019t70qJkBOAlW4X+6jcZIcS jFe+eVRxCb7AXsPZB5EiJMCfepGV0pwM1dAi0CyyvOTfjTSx38CGtqIE9fBzc2HsB5Dl Q/Ycvkt2V+COQSjQpvgz4T+SeBFs8CmJRzY5c9cBxcRduKthi38dkLxsoGAMW1t6lqA0 CDTdIh1FKcaZq4AyFKLrlU0Gm9QtVMMyEJgn/CLqNdDFtxOtq229ATNw0D1Oi1OSqZqx fAwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hGZK86Bj; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id e20-20020a170902ed9400b001614cd9cc52si9745818plj.197.2022.05.23.11.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 11:30:40 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hGZK86Bj; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 68CF113F1E7; Mon, 23 May 2022 11:30:24 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243961AbiEWSKz (ORCPT + 99 others); Mon, 23 May 2022 14:10:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242795AbiEWRhr (ORCPT ); Mon, 23 May 2022 13:37:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 007165D5F3; Mon, 23 May 2022 10:31:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88134608C3; Mon, 23 May 2022 17:28:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86315C385A9; Mon, 23 May 2022 17:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1653326934; bh=hcRyfJ/pCYThU0VoLkwhw+m+Amf5znE5EpP8FRpqnL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hGZK86BjFvQU2rpc9Yk91dzqAxgWpyxA387kOxKFEmD7a2GOrCmv4GYlrU5StDLLm BcCs6HFW90ipCUC9D9AdOTX8zdDsNpDmLd2+JQsupHfMAkfcl0+BcCwyJxhQYLNj6G QGV9vy3syuzdfq2ammgvX4N1rils5/vrwhq+1Tnk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aya Levin , Tariq Toukan , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.17 105/158] net/mlx5e: Block rx-gro-hw feature in switchdev mode Date: Mon, 23 May 2022 19:04:22 +0200 Message-Id: <20220523165848.622257461@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220523165830.581652127@linuxfoundation.org> References: <20220523165830.581652127@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aya Levin [ Upstream commit 15a5078cab30d7aa02ad14bfadebf247d95fc239 ] When the driver is in switchdev mode and rx-gro-hw is set, the RQ needs special CQE handling. Till then, block setting of rx-gro-hw feature in switchdev mode, to avoid failure while setting the feature due to failure while opening the RQ. Fixes: f97d5c2a453e ("net/mlx5e: Add handle SHAMPO cqe support") Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 169e3524bb1c..d468daa7dc20 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3829,6 +3829,10 @@ static netdev_features_t mlx5e_fix_uplink_rep_features(struct net_device *netdev if (netdev->features & NETIF_F_NTUPLE) netdev_warn(netdev, "Disabling ntuple, not supported in switchdev mode\n"); + features &= ~NETIF_F_GRO_HW; + if (netdev->features & NETIF_F_GRO_HW) + netdev_warn(netdev, "Disabling HW_GRO, not supported in switchdev mode\n"); + return features; } -- 2.35.1