Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <cb6bcf221e28deb8dcaf5c02fba6c2257586363e.camel@kernel.org>
Subject: Re: [PATCH v5 1/2] fs/dcache: add d_compare() helper support
From:   Jeff Layton <jlayton@kernel.org>
To:     Luis Chamberlain <mcgrof@kernel.org>, Xiubo Li <xiubli@redhat.com>
Cc:     idryomov@gmail.com, viro@zeniv.linux.org.uk, willy@infradead.org,
        vshankar@redhat.com, ceph-devel@vger.kernel.org, arnd@arndb.de,
        akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 23 May 2022 14:09:26 -0400
In-Reply-To: <YovK86vEmOUUoBn6@bombadil.infradead.org>
References: <20220519101847.87907-1-xiubli@redhat.com>
         <20220519101847.87907-2-xiubli@redhat.com>
         <YovK86vEmOUUoBn6@bombadil.infradead.org>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-05-23 at 10:57 -0700, Luis Chamberlain wrote:
> On Thu, May 19, 2022 at 06:18:45PM +0800, Xiubo Li wrote:
> > Reviewed-by: Jeff Layton <jlayton@kernel.org>
> > Signed-off-by: Xiubo Li <xiubli@redhat.com>
> > ---
> >  fs/dcache.c            | 15 +++++++++++++++
> >  include/linux/dcache.h |  2 ++
> >  2 files changed, 17 insertions(+)
> >=20
> > diff --git a/fs/dcache.c b/fs/dcache.c
> > index 93f4f5ee07bf..95a72f92a94b 100644
> > --- a/fs/dcache.c
> > +++ b/fs/dcache.c
> > @@ -2262,6 +2262,21 @@ static inline bool d_same_name(const struct dent=
ry *dentry,
> >  				       name) =3D=3D 0;
> >  }
> > =20
> > +/**
> > + * d_compare - compare dentry name with case-exact name
> > + * @parent: parent dentry
> > + * @dentry: the negative dentry that was passed to the parent's lookup=
 func
> > + * @name:   the case-exact name to be associated with the returned den=
try
> > + *
> > + * Return: 0 if names are same, or 1
> > + */
> > +bool d_compare(const struct dentry *parent, const struct dentry *dentr=
y,
> > +	       const struct qstr *name)
> > +{
> > +	return !d_same_name(dentry, parent, name);
>=20
> What's wrong with d_same_name()? Why introduce a whole new operation
> and export it when you the same prototype except first and second
> argument moved with an even more confusing name?
>=20

Agreed. That would be better.

> > +}
> > +EXPORT_SYMBOL(d_compare);
>=20
> New symbols should go with EXPORT_SYMBOL_GPL() instead.
>=20
>   Luis

In the past, Al has pushed back against that since EXPORT_SYMBOL_GPL has
no clear legal meaning. He may have changed his opinion since, but I
haven't heard that that was the case.

--=20
Jeff Layton <jlayton@kernel.org>