Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 23 May 2022 19:57:05 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Olivier MOYSAN <olivier.moysan@foss.st.com>
Cc:     Tang Bin <tangbin@cmss.chinamobile.com>,
        arnaud.pouliquen@foss.st.com, lgirdwood@gmail.com, perex@perex.cz,
        tiwai@suse.com, mcoquelin.stm32@gmail.com,
        alexandre.torgue@foss.st.com, alsa-devel@alsa-project.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: stm32: sai: Use of_device_get_match_data() to
 simplify code
Message-ID: <YovZAf4S0XphBsco@sirena.org.uk>
References: <20220519124235.21100-1-tangbin@cmss.chinamobile.com>
 <69d5cef3-57c0-9bc7-a83b-a85ef1c4cf29@foss.st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="D+p6NkMZHcHp/pjf"
Content-Disposition: inline
In-Reply-To: <69d5cef3-57c0-9bc7-a83b-a85ef1c4cf29@foss.st.com>
Precedence: bulk


--D+p6NkMZHcHp/pjf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 23, 2022 at 03:28:48PM +0200, Olivier MOYSAN wrote:

> The current patch requires a change in the driver.
> Either changing STM_SAI_x_ID enums, or replacing data by a struct.
> For instance:
> struct stm32_sai_comp_data {
> 	unsigned int id;
> }
> struct stm32_sai_comp_data stm32_sai_comp_data_a = {
> 	.id = STM_SAI_A_ID;
> }
> struct of_device_id stm32_sai_sub_ids[] = {
> 	.data = &stm32_sai_comp_data_a},
> }

Either approach works for me (or a revert for that matter).

--D+p6NkMZHcHp/pjf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKL2QAACgkQJNaLcl1U
h9DuAwf7B4DIzNtZ0XzfzZJZ+4+f3o1jf4181qlohJddMInl8qu8NI3UjsBmG/6V
kbnPnNFNA8Dt0Y4M/1Qgsux2KKSf71TBiU4F0u1sLUWdmfmevcRSb3dDryoOxnhe
y1ztzF3lErZxTRTpbK0fhud5x3CQuOpHVtY0NsOmB3nAtOcebC7Y+NsV7duG68zR
FWHJUlYGhm0+D3EambBVFiT6hYxgMNk239MLMBCSLbpCaZTCj+9q0RCzYmG8F17Y
pzmwNKfe1F9xoWVWBgxz/EA5o2/jebc75dUdjLfz+y0eCGaHEYnugd6/cFSWLeQr
CZYC5j7tJ4vB8J7WFGhYwA+xMvoL8w==
=UNvf
-----END PGP SIGNATURE-----

--D+p6NkMZHcHp/pjf--